From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6319 invoked by alias); 15 Feb 2017 15:36:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4912 invoked by uid 89); 15 Feb 2017 15:36:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=junior, sergio, Sergio, environ.h X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 15 Feb 2017 15:36:18 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D3D0C05490C; Wed, 15 Feb 2017 15:36:19 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1FFaH3S024955; Wed, 15 Feb 2017 10:36:18 -0500 Subject: Re: [PATCH v3 1/6] Share gdb/environ.[ch] with gdbserver To: Sergio Durigan Junior , GDB Patches References: <1482464361-4068-1-git-send-email-sergiodj@redhat.com> <20170208032257.15443-1-sergiodj@redhat.com> <20170208032257.15443-2-sergiodj@redhat.com> Cc: Luis Machado From: Pedro Alves Message-ID: Date: Wed, 15 Feb 2017 15:36:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170208032257.15443-2-sergiodj@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00415.txt.bz2 On 02/08/2017 03:22 AM, Sergio Durigan Junior wrote: > We will need access to the environment functions when we share > fork_inferior between GDB and gdbserver, therefore we simply make the > API on gdb/environ.[ch] available on common/. No extra adjustments > are needed to make it compile on gdbserver. > > gdb/ChangeLog: > yyyy-mm-dd Sergio Durigan Junior > > * Makefile.in (SFILES): Replace "environ.c" with > "common/environ.c". > (HFILES_NO_SRCDIR): Likewise, for "environ.h". > * environ.c: Include "common-defs.h" instead of "defs.h. Moved > to... > * common/environ.c: ... here. > * environ.h: Moved to... > * common/environ.h: ... here. > > gdb/gdbserver/ChangeLog: > yyyy-mm-dd Sergio Durigan Junior > > * Makefile.in (SFILES): Add "common/environ.c". > (OBJS): Add "common/environ.h". OK. Thanks, Pedro Alves