From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38903 invoked by alias); 30 Oct 2017 15:59:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38893 invoked by uid 89); 30 Oct 2017 15:59:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=H*M:9568 X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 30 Oct 2017 15:59:30 +0000 Received: from dhcp-10-248-127-128.eduroam.wireless.private.cam.ac.uk (global-5-144.nat-2.net.cam.ac.uk [131.111.5.144]) by mail.baldwin.cx (Postfix) with ESMTPSA id E442910A8BA; Mon, 30 Oct 2017 11:59:28 -0400 (EDT) Subject: Re: [PATCH 2/2] target_set_syscall_catchpoint, use gdb::array_view and bool To: Pedro Alves , gdb-patches@sourceware.org References: <1509377531-21044-1-git-send-email-palves@redhat.com> <1509377531-21044-3-git-send-email-palves@redhat.com> From: John Baldwin Message-ID: Date: Mon, 30 Oct 2017 15:59:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509377531-21044-3-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00899.txt.bz2 On 10/30/17 3:32 PM, Pedro Alves wrote: > I noticed that we're passing down a data/size pair to > target_ops::to_set_syscall_catchpoint. This commit makes use of > gdb::array_view instead. While at it, use bool where appropriate as > well. > > gdb/ChangeLog: > yyyy-mm-dd Pedro Alves > > * break-catch-syscall.c (insert_catch_syscall) > (remove_catch_syscall): Adjust to pass reference to > inf_data->syscalls_counts directly via gdb::array_view. > * linux-nat.c (linux_child_set_syscall_catchpoint): Adjust to use > bool and gdb::array_view. I believe fbsd-nat.c will need a similar fixup? It doesn't use the values passed but does implement the target method. -- John Baldwin