From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gKMyIrzImGfzJR0AWB0awg (envelope-from ) for ; Tue, 28 Jan 2025 07:08:28 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YpkXRQKk; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 88C211E105; Tue, 28 Jan 2025 07:08:28 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D3F351E08E for ; Tue, 28 Jan 2025 07:08:27 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 698CB3858019 for ; Tue, 28 Jan 2025 12:08:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 698CB3858019 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YpkXRQKk Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id BA4CA3858432 for ; Tue, 28 Jan 2025 12:07:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA4CA3858432 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BA4CA3858432 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738066059; cv=none; b=c9o4MJrZaxcFbzYz8SAU/yTK/6eQKoDAw9Fkdtx5yLpR6bfPp+8zskxjAxJM/KHm+v87eL3eaWhoTbWWo8RUj2tJOCh3+Gk0V/1g68LN4XDUZuBg/G7KhF5F7dS+Z+Bk/7CrnneMLD7Z0E7wUhelZkoQDAdxHhSdCUWBu8qHERw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1738066059; c=relaxed/simple; bh=24kAG30av6gDW8JW8+EquULMixqycEApP4TbvxeKVfY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=InaWEGoRTDHJDilzo0OHkVtmhlRxekvusUmhPIF9yN+7gOuW23hQxVm5Wg+Boy2itfHYbpCybzk7rbbnjex3UHYrUO3GhI2aUsdx8+mf9eDl75ENFfqkZaJ7hFYLX0rpkP/PaLrSD8hKF7Hhk0T8Lx57ut4t+AhNxJ5D5DOnVjU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BA4CA3858432 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738066059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dM+EtNPnRw0YnDjJonGSHdwuuTLwFlP142pZw1oHZOc=; b=YpkXRQKko+9jywfBUAy0iwp4wd+jJ1moXBd1X+lYJ+MXNlrlpVrWi/ebQrPlOv7tDyaMo0 CzIdgFGIBSGGEMCSzwaKZz54Xza2p66vr/8nTPj8AujMx4tZ4n+LmipB+vejJUFzjUy3GE jyxkk9705RJFt6vuJIN2H8mHmOwJ9jA= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-602-zll2VZdXNuiMgzCniD_Cyw-1; Tue, 28 Jan 2025 07:07:37 -0500 X-MC-Unique: zll2VZdXNuiMgzCniD_Cyw-1 X-Mimecast-MFC-AGG-ID: zll2VZdXNuiMgzCniD_Cyw Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2163dc0f689so163389475ad.1 for ; Tue, 28 Jan 2025 04:07:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738066056; x=1738670856; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dM+EtNPnRw0YnDjJonGSHdwuuTLwFlP142pZw1oHZOc=; b=mEQfOi0uJU+ISqWNmbqv/Oy4afRZLWK7JqjZhUUhARC4Ygdt10i6CT7xtOtgRC5jvr MmFzjcvt0DjQf81tkyGDB6VGyOHTNBl5k2PnqMmusOCYzgSENeLAZfyxOpzQpQ7DGuWr SOXNIFaxrnDFVOmk7MD6Ry98Gwq20vAN6lHBwWMB3CJrUG/NnhLhVEcIgrAO2ToQnKWe x8vFAOGR61as7a/fDyAdKnit5mOCwQbXNPGqxcnYOB74/+BUPrGoLfw6GdtLXE18W1/8 MZ6jBanY2+NnAfDo0r2FHyllI9DXgjem2QKo/6HXeDjmyu+FgE6jIzZkgS35mnNZQ9WZ zPBA== X-Gm-Message-State: AOJu0Yw3ZBKIqus46SLUCw2Qv9PoVV9xgGOJTSk7VOI+J1bjGjlI3xRl 8fQaLa97BK7jakoXgrVV2rgNgyYayatI2jD0dcNqGjgr674FD9vx4VgmL90YHR1AKpackYXaU0J 1JyybEbibuAXn4sX5UG7C31Ptbn3MB6jm/TqJv3NtofZFhogYzUx+I7/80PhVWSm5TK8= X-Gm-Gg: ASbGnctNAcMMiXoxgvWS6cGQbvXBQ/aAOa9eFRJF2bjS3p8aGWGIqKupHo31mRarjLy Nkr/9sb89vehvOCGM7lkHgp/oVNegh5UF14qAtw98mYW2LS6Yzj6p4oJuNn94ix1sT83zzFXDxm 7fv578Mb2uAqt5eZu2MVthg9HHqQu0qmmj91C2dEcaBKGTFmQZCqLaHeH8Et7qY4UBEQvXg8D7g h3nsSWJgKukM43feAZgXDcrPyLhPYkklRoyFUixyf1JbLfYrg3IdTkjbirxC/FtNayKMRmv1IH1 84YgALK89eu4IG8Z X-Received: by 2002:a17:902:c946:b0:215:8f2e:eeda with SMTP id d9443c01a7336-21c35609304mr641955725ad.52.1738066056379; Tue, 28 Jan 2025 04:07:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IG+Pe+pXs6SLuydHXV8kdvxgFmMxTQMK7dlrN2fhBKWiDKM5Awq1tM35TS7KVgWXO6KYgt0Kw== X-Received: by 2002:a17:902:c946:b0:215:8f2e:eeda with SMTP id d9443c01a7336-21c35609304mr641955445ad.52.1738066056094; Tue, 28 Jan 2025 04:07:36 -0800 (PST) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21da414db2asm79232005ad.169.2025.01.28.04.07.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2025 04:07:35 -0800 (PST) Message-ID: Date: Tue, 28 Jan 2025 09:07:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/configure: fail configure if all targets requested with 32bit bfd To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20250123201338.158819-2-guinevere@redhat.com> <20250127181157.792d1d9e@f41-zbm-amd> From: Guinevere Larsen In-Reply-To: <20250127181157.792d1d9e@f41-zbm-amd> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: NRZlcmvPNR7h_Bvg82nVCoWUiptVrCWtsfT0o10yZz0_1738066056 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 1/27/25 10:11 PM, Kevin Buettner wrote: > On Thu, 23 Jan 2025 17:13:39 -0300 > Guinevere Larsen wrote: > >> As PR sim/28684 explains, it isn't possible to compile GDB with all >> targets enabled and not enabling 64 bit bfd. In 64 bit hosts, 64 bit bfd >> is forced, so the build works, but in 32 bit hosts, that has to be >> explicitly enabled. >> >> I ran into this when I tried compiling GDB on a mips64 machine running a >> 32 bit OS. Along with the errors in the PR, several other architectures >> are also required, notably aarch64 and other explicitly 64bit targets. >> Additionally, some 32 bit files required for the gdb mips target aren't >> added to the makefile. >> >> Considering the last comment in the bug says this isn't going to be >> fixed on the binutils side, I didn't think it was worth trying to fix >> the GDB side. Instead, this commit causes the configure script to fail >> if all targets were requested and 64 bit bfd isn't enabled. If that is >> ever fixed, we can revert this commit. >> >> I considered adding this to the top level configure script, but couldn't >> figure out how to detect the situation in there, so this was my next >> best idea. >> >> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28684 > Sounds like the right approach to me... > > Approved-by: Kevin Buettner > Thanks, pushed! -- Cheers, Guinevere Larsen She/Her/Hers