From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id INjPF7W8ZmasOi4AWB0awg (envelope-from ) for ; Mon, 10 Jun 2024 04:43:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=aMKv0w85; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=w8CnQrvw; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ETj8g1yO; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=1BJuxdYY; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 485541E0CE; Mon, 10 Jun 2024 04:43:33 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D38861E030 for ; Mon, 10 Jun 2024 04:43:30 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 515283858C60 for ; Mon, 10 Jun 2024 08:43:30 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id F2B043858401 for ; Mon, 10 Jun 2024 08:43:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2B043858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F2B043858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718008985; cv=none; b=tv59HSlqxmD9U0Mhtlzhoymw6LMBmHj+KvsII6SJNB5Wwxsx//eMXVgtRjTVinHIMF077IuVpxisF7zAc94dR3e57w/aZClI2NOsEAFQZsvJJ3dbDyNeTpEDZm2MCHE7Ie/N9RP8OtIhqJdnVQpqj0OpA6keMpuRxjxbnHKlRmg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718008985; c=relaxed/simple; bh=s44xfaPxHU6ln9BBbwxXfW7fiTeINQzY2H3ycKROYnQ=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=C+GdyXQ50/jZ2mpRau5LopOHUEjivwjIhtLpprSQSwGxnVjd+3vAyaHKEWw//HvkmGiCfsZeHnEhN+4wqVRFIzh7wj9VryUFEzOB60BeJpaV82qp6PAFd5R/zWPu8tsgfFO4cQqCcgMw5OfC0T+kmT/tmsTBatabWkrYQpY2JDQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D36FD1F7BA; Mon, 10 Jun 2024 08:43:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718008982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D3hOLVNmmsNQMueD5dT69hU6TWD78FWc8sdVkzXrKbA=; b=aMKv0w85BLJ7Xt4p+O+dfNh+islXG+zmxSHYsCsXgRzXwv1rOI44R811Odb0XBfAQt9uX0 rLOMYq3vwWyH+jgdm8kBlSqGAvMZWP22ATt4POuKbiL3QAJb7URWZbZdkACyuDmSB9VjRY 5TUtTz9zEvc9KPsn4R3IRojfOXzqbrc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718008982; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D3hOLVNmmsNQMueD5dT69hU6TWD78FWc8sdVkzXrKbA=; b=w8CnQrvwyhA7tE+bKdhUZKtid2vzL9nBhp+l0voVNzM+WSi6YEpa/QbLO2U/bPOObhisdV LNH0QuOHbNdar9CA== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ETj8g1yO; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=1BJuxdYY DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1718008981; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D3hOLVNmmsNQMueD5dT69hU6TWD78FWc8sdVkzXrKbA=; b=ETj8g1yOjyOQuF84cMOaSJWrRCwz0KXerAFx+iIeSmCh9ph/+RnCIIMUxuwDbK3U5zDzm1 jsjNSTBwr+amseJkDVgg4aJ/ejYJA30l5Kv+XqGqBZyTLTgaYpHSc4xPjIAdlIZYSVufhN zit0Qzl5HFaue8R5u8T1+16+9t1zovs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1718008981; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D3hOLVNmmsNQMueD5dT69hU6TWD78FWc8sdVkzXrKbA=; b=1BJuxdYY3iajPkQ9qAKCbMSDZRMp79DYQH1sXnuFum21ZYyu1U8xgR/moXSfTNXH9a5A6x /uZvTNGef16JQpAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BAEEF13A51; Mon, 10 Jun 2024 08:43:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NZE7LJW8ZmaCXAAAD6G6ig (envelope-from ); Mon, 10 Jun 2024 08:43:01 +0000 Message-ID: Date: Mon, 10 Jun 2024 10:43:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Don't use set auto-solib-add off To: Kevin Buettner Cc: gdb-patches@sourceware.org References: <20240607144135.32128-1-tdevries@suse.de> <20240609181630.715ec02c@f40-zbm-amd> Content-Language: en-US From: Tom de Vries In-Reply-To: <20240609181630.715ec02c@f40-zbm-amd> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.50 X-Rspamd-Action: no action X-Rspamd-Queue-Id: D36FD1F7BA X-Spam-Level: X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.50 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 6/10/24 03:17, Kevin Buettner wrote: > On Fri, 7 Jun 2024 16:41:35 +0200 > Tom de Vries wrote: > >> In test-case gdb.mi/mi-var-child-f.exp, we have: >> ... >> mi_gdb_test "-gdb-set auto-solib-add off" "\\^done" >> mi_runto prog_array >> mi_gdb_test "nosharedlibrary" ".*\\^done" >> ... >> >> This was added to avoid a name clash between the array variable as defined in >> gdb.mi/array.f90 and debug info in shared libraries, and used in other places >> in the testsuite. >> >> The same workaround is also used to ignore symbols from shared libraries when >> excercising for instance a command that print all symbols. >> >> However, this approach can cause problems for targets like arm that require >> symbol info for some libraries like ld.so and libc to fully function. >> >> While absense of debug info for shared libraries should be handled gracefully >> (which does need fixing, see PR31817), failure to do so should not result >> in failures in unrelated test-cases. >> >> Fix this by removing "set auto-solib-add off". >> >> This ensures that we don't run into PR31817, while the presence of >> nosharedlibrary still ensures that in the rest of the test-case we're not >> bothered by shared library symbols. >> >> Likewise in other test-cases. >> >> Tested on arm-linux. > > LGTM. > > Approved-by: Kevin Buettner > Thanks for the review, pushed. - Tom