From: Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3 4/4] gdb/doc: document '+' argument for 'list' command
Date: Wed, 21 Jun 2023 13:20:54 +0200 [thread overview]
Message-ID: <c81ed345-2c8f-f624-dec3-3f96015c9fb9@redhat.com> (raw)
In-Reply-To: <838rcd5arg.fsf@gnu.org>
On 21/06/2023 13:13, Eli Zaretskii wrote:
>> From: Bruno Larsen <blarsen@redhat.com>
>> Cc: Bruno Larsen <blarsen@redhat.com>,
>> Eli Zaretskii <eliz@gnu.org>
>> Date: Wed, 21 Jun 2023 12:45:45 +0200
>>
>> The command 'list' has accepted the argument '+' for many years already,
>> but this option wasn't documented either in the texinfo docs or in the
>> help text for the command. This commit documents it.
>>
>> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
>> ---
>> gdb/cli/cli-cmds.c | 1 +
>> gdb/doc/gdb.texinfo | 4 ++++
>> 2 files changed, 5 insertions(+)
>>
>> diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c
>> index a966142eaea..b7cbe673985 100644
>> --- a/gdb/cli/cli-cmds.c
>> +++ b/gdb/cli/cli-cmds.c
>> @@ -2822,6 +2822,7 @@ and send its output to SHELL_COMMAND."));
>> List specified function or line.\n\
>> With no argument, lists ten more lines after or around previous listing.\n\
>> \"list .\" lists ten lines arond where the inferior is stopped.\n\
>> +\"list +\" lists the ten lines following a previous ten-line listing.\n\
>> \"list -\" lists the ten lines before a previous ten-line listing.\n\
>> One argument specifies a line, and ten lines are listed around that line.\n\
>> Two arguments with comma between specify starting and ending lines to list.\n\
> This part is OK.
>
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index e4e374d138c..f9c3c90e16a 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -9149,6 +9149,10 @@ Stack}), this prints lines centered around that line. If no
>> @code{list} command has been used and no solitary line was printed,
>> it prints the lines around the function @code{main}.
>>
>> +@item list +
>> +Same as using with no arguments, but errors out if the line is
>> +past the end of the file.
> But here it looks like some copy/pasta error?
>
No, this is the main distinguishing feature between "list" and "list +",
the latter will error out if it is past the end of the file, while the
former won't.
--
Cheers,
Bruno
next prev parent reply other threads:[~2023-06-21 11:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 10:45 [PATCH v3 0/4] Small changes to "list" command Bruno Larsen via Gdb-patches
2023-06-21 10:45 ` [PATCH v3 1/4] gdb/cli: Factor out code to list lines for the first time Bruno Larsen via Gdb-patches
2023-06-22 13:25 ` Andrew Burgess via Gdb-patches
2023-06-21 10:45 ` [PATCH v3 2/4] gdb/cli: Improve UX when using list with no args Bruno Larsen via Gdb-patches
2023-06-21 16:07 ` Keith Seitz via Gdb-patches
2023-06-22 9:54 ` Bruno Larsen via Gdb-patches
2023-06-22 13:46 ` Andrew Burgess via Gdb-patches
2023-06-27 11:35 ` Bruno Larsen via Gdb-patches
2023-06-21 10:45 ` [PATCH v3 3/4] gdb/cli: add '.' as an argument for 'list' command Bruno Larsen via Gdb-patches
2023-06-21 17:25 ` Keith Seitz via Gdb-patches
2023-06-22 10:52 ` Bruno Larsen via Gdb-patches
2023-06-22 13:51 ` Andrew Burgess via Gdb-patches
2023-06-21 10:45 ` [PATCH v3 4/4] gdb/doc: document '+' " Bruno Larsen via Gdb-patches
2023-06-21 11:13 ` Eli Zaretskii via Gdb-patches
2023-06-21 11:20 ` Bruno Larsen via Gdb-patches [this message]
2023-06-21 12:44 ` Eli Zaretskii via Gdb-patches
2023-06-21 12:55 ` Bruno Larsen via Gdb-patches
2023-06-21 14:11 ` Eli Zaretskii via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c81ed345-2c8f-f624-dec3-3f96015c9fb9@redhat.com \
--to=gdb-patches@sourceware.org \
--cc=blarsen@redhat.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox