From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bODFFvwDVWqbWwYAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 11:27:56 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fMcFohIR; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fMcFohIR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4EAF31E09B; Mon, 13 Jul 2026 11:27:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 15F951E033 for ; Mon, 13 Jul 2026 11:27:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8ED9A4BA2E10 for ; Mon, 13 Jul 2026 15:27:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8ED9A4BA2E10 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fMcFohIR; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fMcFohIR Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013002.outbound.protection.outlook.com [40.107.162.2]) by sourceware.org (Postfix) with ESMTPS id 095994BA2E09 for ; Mon, 13 Jul 2026 15:27:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 095994BA2E09 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 095994BA2E09 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=40.107.162.2 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1783956447; cv=pass; b=RpgnQdBgch4RH85Mw0q97Xb2e3tPmJ75AVGsofW9rZ6eEIvfpJX7lLAs0qY9vcC2CdaB4rex4sRuePqkb4a1tHgM6sF3K/9z3fP6iY68Q/e7cTTpmfNUC7BFg9DEGyLcwEPTukrMeDLwFbSQCYDm/yNHdL9vWP/RM+zrRi/KwYs= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1783956447; c=relaxed/simple; bh=bokV0z5cvhWyCqLsi2IFhpKGOpqNpzyWknhTx8PuwvI=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=j6YOBp34gYWfKZ324Mp+l0aqeFXEH/2YOXRFWph8KJ1IrKgnVjYGEEvNvzUi1NFUXMB8amlJ0C7pTcZoRrj41TaZqItzuYI1Sm1FZnqvN+QxY94MOjhDeCL85N5MfhN1ffwrIzkRkDzcn2EQ+z2Iqb8L4/WZraC8eTupOcq3sAw= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fMcFohIR; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fMcFohIR DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 095994BA2E09 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=R7OgaSvACmzlGl8NEHvwx73nAmjVAWroWrllLzjcS+N7tbIw7CZGesaH4Gu0ibUmwaWRkRki3GnfuwVzSRkaxOnhEIFzpjcOeJDRPtLlIfuLYG9UURhVPpVAezZl42I5bh5rVplP2LfIC6HZrGZLvB2K4WpWxSBPu0aTnXHXaZOCGexwneGF4OKXIQVBatzoVlUMSeRDW07XlwVNhDmZrG3wCqlOq1ZIMzd0qRLtMs5znoqSJZsZQXKMy2zhLmYQzS6wUkqLGmjeEFaEI4o/DjIpPqva2mrdZn7fXqcxeKi9rmF+UUNBSVrJ78NO8GZ1l1YDv2nRvxLtQ5JzAF5MRg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yZO446S3xcXs6y+sunMslArg1D0jAoR2VAJAN6BbJgI=; b=MvF/aQkpeiK6DNL1v6ZfEHT3bPIflmB0nYEd/uq9GrKcZmI4vxnPRQHb/EvnQ9M6cwp9dyqGpDqAHiCev87qQV6BtU41Lbc7KeEXCjKYIRWhb2yHbYZq63jtJdF9Fs9MsuS7sY5a6r5OzH4weijZKG+jVoLzqQJ6NDnCz6T6ipP30Nkr9arOA9TGG7b1Xnwv0GEKOobMbblGWhyV28t5xdnBMMHfVSrrXFieUE5q+XwYXNb8eNJ/h9CK3l1f5kkXYndqA10Iw0+aszvf+munGGnxscQ+VknKOw9G1kjLOBUBdkYKbnbhHX1Mlb01Eh8/G+avIFAJXYL/jjasRhWgtg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=linaro.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yZO446S3xcXs6y+sunMslArg1D0jAoR2VAJAN6BbJgI=; b=fMcFohIR/9bUmP2TrpC9YjvfXLX2Ul6UVSmwVp+Eb0yDeddvpk4WCxwdzpzdIbPa21//EGmEeUZszugGb9CN9xZ/PAXOiCSG8Ql8ZlbAo3re1NdM1jzBUtPW288MYUCF3ytj4/rybZZ0UDxEonJ1hqNqnf6/x5t6UcScBAUcydU= Received: from AS4P189CA0059.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:659::29) by AS8PR08MB6533.eurprd08.prod.outlook.com (2603:10a6:20b:33e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 15:27:18 +0000 Received: from AMS0EPF000001A5.eurprd05.prod.outlook.com (2603:10a6:20b:659:cafe::26) by AS4P189CA0059.outlook.office365.com (2603:10a6:20b:659::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.19 via Frontend Transport; Mon, 13 Jul 2026 15:27:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS0EPF000001A5.mail.protection.outlook.com (10.167.16.232) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.223.9 via Frontend Transport; Mon, 13 Jul 2026 15:27:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=heULTm4Z0qjj3ryCwspqvl1sX8HztauH1CDlQKN0kDCftToDKcC6MRVMEAFDUYQ4wwSwbOoSRfQv01g2N43Rq3QK6JHXbIzMeTdIxLPTuzurL659NL6uiDcJxG/alAZepsv0yR/Hobvc8hrpeZhxZ9ZeFmsBAFtPphAQLUJDrnVpF0+uoGcQzwMQ16wMwIFmiugitVIXWZe4ZGVehXDR3X98RPsxFlzGvVXXUmCZJ0HaOEQNhouNDmkmgKnPdYjGmpyDNeS2zpZUM6RsyblC4Dk/ndl73BE/tiQf9bjY7zI2LmfcUvIzlgYjqm+nb3JOd/1vMSLzMoaco/IWEREakg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yZO446S3xcXs6y+sunMslArg1D0jAoR2VAJAN6BbJgI=; b=tpjvBBvLG8yUTxjhBitQM2k2jvkNuANfx0oA56DBjL5Wk2Q+r+a6jF6GBSpBnUTb3yIlWVpaMogUHtmKEhOlphwriX24w/E3GtxnlWvrdhq3r6gmwcozJSv45oQFLuyO5k/0bVDqrjjIIdkKPCxRF7IJTyu0LdHtiAjj6/fOp8hWNNi1Ivetk2EFHZwda6o7E6vtn6U1dCCsE55lQDGDHAiYOXQJJIAp6ML+eu7GRDedFktFgBV0DgP4I1LeOqkyebVU5CKCNrO/4uIGUhuGFFcXxpOtzCqbAPzFuH8MxMzcdM4NkuEc3nQ/mRS3Gb70tMDALRFBJq037/wVM25PMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yZO446S3xcXs6y+sunMslArg1D0jAoR2VAJAN6BbJgI=; b=fMcFohIR/9bUmP2TrpC9YjvfXLX2Ul6UVSmwVp+Eb0yDeddvpk4WCxwdzpzdIbPa21//EGmEeUZszugGb9CN9xZ/PAXOiCSG8Ql8ZlbAo3re1NdM1jzBUtPW288MYUCF3ytj4/rybZZ0UDxEonJ1hqNqnf6/x5t6UcScBAUcydU= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB8664.eurprd08.prod.outlook.com (2603:10a6:10:400::16) by DU0PR08MB8788.eurprd08.prod.outlook.com (2603:10a6:10:477::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 15:26:14 +0000 Received: from DU0PR08MB8664.eurprd08.prod.outlook.com ([fe80::9438:8617:f487:336f]) by DU0PR08MB8664.eurprd08.prod.outlook.com ([fe80::9438:8617:f487:336f%5]) with mapi id 15.21.0181.016; Mon, 13 Jul 2026 15:26:14 +0000 Message-ID: Date: Mon, 13 Jul 2026 16:26:12 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 03/10] target_fileio_read_stralloc: add an optional length parameter To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org, Luis Machado , Luis Machado , Andrew Burgess , Yury Khrustalev , Pedro Alves , Tom Tromey References: <20260707154900.94542-1-matthieu.longo@arm.com> <20260707154900.94542-4-matthieu.longo@arm.com> <87jyr41xqc.fsf@linaro.org> Content-Language: en-US From: Matthieu Longo In-Reply-To: <87jyr41xqc.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0017.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ad::15) To DU0PR08MB8664.eurprd08.prod.outlook.com (2603:10a6:10:400::16) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB8664:EE_|DU0PR08MB8788:EE_|AMS0EPF000001A5:EE_|AS8PR08MB6533:EE_ X-MS-Office365-Filtering-Correlation-Id: 49389142-0a6d-4f5e-6222-08dee0f339a1 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|23010399003|376014|366016|1800799024|18002099003|22082099003|11063799006|4143699003|56012099006; X-Microsoft-Antispam-Message-Info-Original: hPWHNZbzkq+Lpuax5h8bUJLHj6oZinGqO2EG8CBQ9zuvw/6OSeQvYGRccTa0xpExbMDwgnGL9MOs8BVqflj562PCyKWmK2nKXx0OLMsp9z50PMhg2zLFbJd+kvSPU1JTd0vGhs3d7070SRL+9PAKcqxutXwsDegj5B638zg/Y7hX4LFxD/LXQsQRF4J/D23Pvk2qm3kVGdw22+1pswzGOPFJ6yyEwyL1FxMzcB1/FzPQ7Qe7jGEG+/e3poPw8BA5cbacbkl7i8zSoNB+wtRluJVJNWGkeUL0R+pnggm8Rpb2pB3FVvv/PIx7tjfoMxToZ8CKjexAeh7vgnzV+knp5CB/7KfLbaPwmFLCK2bZ//7EP2KQtYE5+ZOKt8N0M2ijCXW5J0C87wwDmEVvPsx2R+UyX4bN4Dyh/41poMKnih+sI4uBtdZL2g6qFpfJzjGeLUM27Rok96jfp059uKsSaPZx5WvqdbFqS4aVIw2tuqTRHg7N4dSDXiftpRO4Fx/iHoW5o2K/FK6aIv3CmbE+BMxjgHlLjopVxLkyuioJyrbDxy8Zm+wppzSJbV02nFz/G5lCjB870Rnd8YJyNmxeWA7MDKFBHk9F8XhDBBJVRP1M3UeY6dRWumgVxwSMLvwxSEKQ9KXN1XybwLfho2U4QtqrG6c/LDzEV417oNICl3o= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR08MB8664.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(23010399003)(376014)(366016)(1800799024)(18002099003)(22082099003)(11063799006)(4143699003)(56012099006); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: qQeeqrRS8E3tSA566+8ATckPhLssoc6InzTKT6NSiaHuoVU6wiLneQDsGnaAqVWA/nddg6pYcRvEVNnU5SZBw2Jq8W1vCXKDbIh5aL/VMi/4WJETXq1G6Mma3b8T4NNpOsUFtrBYY/A6xQJZIE92COZcmJgBVwXY8NzG5nRDWCPzK82IMUPMVrsfP72GwJ+m/twO+RFLnOdefx4l5ZiuNO7z5hKD2LaAwfgprjT2VZtGX5QVU/OderxW9ZI6IgmeBMd6YEuN/doiHoe0C9wOu9SZe3aYF2AW5uHTGFW6XSZ1S1by0lZf8bDZuimEdnvzThinq7bpcyfRuYISH/Cw6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8788 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS0EPF000001A5.eurprd05.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9793b70f-803a-4ced-03d6-08dee0f31375 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700016|82310400026|1800799024|35042699022|376014|23010399003|14060799003|18002099003|22082099003|4143699003|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: QtIEQl+5q7cvYvQmww1RsTdIb/muplsnRToHjfMKBSuVfkzQlrabMgppZIKfoIWU2UQey/M0jyRyb0RCS8YpZA0l8OyPWZv7fXEhEjb6m+/jTaVQE25BrSZbz39+IjOScrYAkIzqmLCWj/h/TViScTwSBM3RbVwf1W6Fa1uUVRJl4eVQhKGGcDJn4UnSrcRkFUESSnlOvPqunMbZ0yQCP0G5wV5PFf1zDa17nHk8jfavbMcNGiFkYlcPL9tXc9k6omFW7MqOE+EhE/y3Q8rG/uzzH528BrtDcJpasWXglxNDNsSuRqcjGZeVaFy6yRoFLYfr74seeIjrbhsB0bm2q8Pm23Hoa7G0ZwKv75APWstX6CRFIOOqvnIq2vfcFSsDZZjpa/iqh6z7cH8czEP5eb8etEM5wcFtAtL+86aKSLLRdDW6uqg8QL4t9JHs9LUV2p7REkywxWTGpvUPOl3IX0IdSK7rYe+LQ5IzcOklXlBk+Sde0hVI1A316ujFN5ieyn4xhY6dnp7xwj+m8WtAn7zFzJa31qniIu53xiKywGok0DLrI05v3OEI+efpCKHXT5POD7Ohk7giw0+zpIAFDmyrxD4KbHDtro/feU9N3BKchXz5uVl6kJDECP0oXxIIKOjgJhXaOpEqjgwmx30hyheH7Ptv9NMcE7KqGIfxRfin97DRpG3Zj/GYQpSZ83LY3vYAjmggseaWOKYDgnHIKQ== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(36860700016)(82310400026)(1800799024)(35042699022)(376014)(23010399003)(14060799003)(18002099003)(22082099003)(4143699003)(11063799006)(56012099006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 7r3NzbXP3Wc8Yy98ZRJgJhg7Kh2sZrhSx4SEnGm3jFYbgndkttgkaFTdroVbhEBym6RTOP6YzVItAN/Fn0rubg3ZS9RcCUZVYu5ITHSuKXuOiuiFIqOlQPASDYhNUShcpDZPFHFBoHiMs+srrk07ROn1dD5Zgd4NdTXF1M4Zv/rWLWGy+8OxWRWFHDOAdNr3a9gTv4VThfokcAF2Leu/6NvHLpMb06sUrnJr4uNC3mkdlv3qbovDYUN74XGsUbbnHzNi9dxsBE3h+jKOGSrRzY0YNbTlRQvdXk8Z0J0HgI33cM9bWWPywn1/QrEq81IbPAJpNJg9fX6CUox8H9L40FpWShPVgA5t6oF5OWaNWx4Vw44M04DLszyRGoe9cYfrusoog96HpS05co/Gb2tv5RiRzuTqgVBncsLx7JcKpxSSED84kgsy0+GrG4E/LVcX X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 15:27:18.0812 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49389142-0a6d-4f5e-6222-08dee0f339a1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A5.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6533 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 09/07/2026 07:30, Thiago Jung Bauermann wrote: > Matthieu Longo writes: > >> diff --git a/gdb/target.h b/gdb/target.h >> index 22653138491..4215553033c 100644 >> --- a/gdb/target.h >> +++ b/gdb/target.h >> @@ -2336,7 +2336,7 @@ extern LONGEST target_fileio_read_alloc (struct inferior *inf, >> are returned as allocated but empty strings. A warning is issued >> if the result contains any embedded NUL bytes. */ >> extern gdb::unique_xmalloc_ptr target_fileio_read_stralloc >> - (struct inferior *inf, const char *filename); >> + (struct inferior *inf, const char *filename, size_t *len = nullptr); > > It's worth updating the documentation comment to mention the new parameter. > See the updated diff in gdb/target.h >> >> /* Invalidate the target associated with open handles that were open >> on target TARG, since we're about to close (and maybe destroy) the > diff --git a/gdb/target.h b/gdb/target.h index 22653138491..0df5a654f75 100644 --- a/gdb/target.h +++ b/gdb/target.h @@ -2328,15 +2328,19 @@ extern LONGEST target_fileio_read_alloc (struct inferior *inf, const char *filename, gdb_byte **buf_p); -/* Read target file FILENAME, in the filesystem as seen by INF. If - INF is NULL, use the filesystem seen by the debugger (GDB or, for - remote targets, the remote stub). The result is NUL-terminated and - returned as a string, allocated using xmalloc. If an error occurs - or the transfer is unsupported, NULL is returned. Empty objects - are returned as allocated but empty strings. A warning is issued - if the result contains any embedded NUL bytes. */ +/* Read the content of the target file FILENAME from the filesystem as + seen by INF. If INF is NULL, use the filesystem seen by the debugger + (GDB or, for remote targets, the remote stub). + + If LEN is not NULL, store the number of bytes read, excluding the + terminating NUL byte. + + The returned buffer is NUL-terminated and allocated using xmalloc. + On error, or if the transfer is unsupported, return NULL. Empty + files are returned as allocated but empty strings. A warning is + issued if the file content contains embedded NUL bytes. */ extern gdb::unique_xmalloc_ptr target_fileio_read_stralloc - (struct inferior *inf, const char *filename); + (struct inferior *inf, const char *filename, size_t *len = nullptr); /* Invalidate the target associated with open handles that were open on target TARG, since we're about to close (and maybe destroy) the Matthieu