From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9027 invoked by alias); 30 Oct 2019 20:06:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8802 invoked by uid 89); 30 Oct 2019 20:06:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*M:hotmail, Automation, Attached, Hx-incomingtopheadermarker:Count X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-oln040092067092.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.92.67.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Oct 2019 20:05:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JdbsRooQi/CH0g991ORsDpvaGGTM/4n77LJiFYmPjNy+go+ziSRVPhrzV8ACtvBVJkXzg1E8s3pJVXvSezl/+mTVCakimZk70D4c5f+oRajr5eZPlHtpFVdcIbEmihRPYt7unOmRSoetnuYNW7z1/AjDzhBzW7TZG3xd7INHuO4NU/OsX7rnAMQ1N7W65i47jSMZOUj8oCPtr8ND6ywr9Ei2fqRIoPWAhY4+ra58GTO5y/ikZZ11RdbYj5ItZSRbiVNslft0pnK9uLlubmP4IsH9ezlTK07O/U19cKxJ75KaXj4Kxy249mUGW6V0BjrikKbYiHFDw+UwLRaaBrgc/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7B2myiQvQau5t1tpy8ZLgLUQAPHAVhSVI3J7ujp03oA=; b=Gs+pDZYuQCAMYQN9HFY9AtXHr/awx95cWgexFfyNOG8R20p3RJ6Yl7iYURHp9Znq1tbsulw5Jiz5+WMxaI/tk2quNsmCMpw59cEWarTxMJOkmSqei1Hft1xUoqa9pVk/lhpftG2vtVogrynW8V2cgOOK9h35kjeCHt0E1fHl0/ob1r/FtATfuOZ2FmIkj1jTrG1qnFUJeh477fRySlHXBV5WS0XgUtQb/byg9E0vwsbgh1FoRl8q6GycYXVlcm74sALQ4JgH+qLcbtFu0JN5kFPBQy3StWn06rjOmg6mWcqMaXeKCVplSTzgPhoJnxdmjE+LAycDVUCy2G9BjnDzFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from HE1EUR02FT012.eop-EUR02.prod.protection.outlook.com (10.152.10.58) by HE1EUR02HT191.eop-EUR02.prod.protection.outlook.com (10.152.11.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2387.20; Wed, 30 Oct 2019 20:05:54 +0000 Received: from VI1PR03MB4528.eurprd03.prod.outlook.com (10.152.10.56) by HE1EUR02FT012.mail.protection.outlook.com (10.152.10.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2387.20 via Frontend Transport; Wed, 30 Oct 2019 20:05:54 +0000 Received: from VI1PR03MB4528.eurprd03.prod.outlook.com ([fe80::49b8:a7e6:9f6f:862d]) by VI1PR03MB4528.eurprd03.prod.outlook.com ([fe80::49b8:a7e6:9f6f:862d%3]) with mapi id 15.20.2387.028; Wed, 30 Oct 2019 20:05:54 +0000 From: Bernd Edlinger To: Simon Marchi , "gdb-patches@sourceware.org" Subject: Re: [PATCHv2] Make "skip" work on inline frames Date: Wed, 30 Oct 2019 20:06:00 -0000 Message-ID: References: <8fc93db4-8906-4f4e-53f4-225ebfa0115d@simark.ca> In-Reply-To: <8fc93db4-8906-4f4e-53f4-225ebfa0115d@simark.ca> x-ms-exchange-imapappendstamp: VI1PR03MB4528.eurprd03.prod.outlook.com (15.20.2387.009) x-ms-exchange-purlcount: 1 x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-ID: <177DBCA1C8C8E44C974CCFE7B7790B5B@sct-15-20-2387-20-msonline-outlook-45755.templateTenant> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019-10/txt/msg01117.txt.bz2 On 10/27/19 2:52 AM, Simon Marchi wrote: > On 2019-10-20 2:48 a.m., Bernd Edlinger wrote: >> On 10/19/19 6:38 AM, Bernd Edlinger wrote: >>> Hmm, >>> >>> I noticed that the patch does not yet handle >>> the step correctly, the count is decremented >>> although the inline frame is skipped and should not be >>> counted... >>> >>> Thus I will need to change at least this: >>> >>> --- a/gdb/infcmd.c >>> +++ b/gdb/infcmd.c >>> @@ -1122,7 +1122,6 @@ prepare_one_step (struct step_command_fsm *sm) >>> set_running (resume_ptid, 1); >>>=20=20 >>> step_into_inline_frame (tp); >>> - sm->count--; >>>=20=20 >>> sal =3D find_frame_sal (frame); >>> sym =3D get_frame_function (frame); >>> @@ -1132,13 +1131,17 @@ prepare_one_step (struct step_command_fsm *sm) >>>=20=20 >>> if (sal.line =3D=3D 0 >>> || !function_name_is_marked_for_skip (fn, sal)) >>> - return prepare_one_step (sm); >>> + { >>> + sm->count--; >>> + return prepare_one_step (sm); >>> + } >>> } >>>=20=20 >>> >> >> Attached is an updated patch that fixes this issue, >> and also adds the following after step_into_inline_frame (): >> >> frame =3D get_current_frame (); >> >> That I consider safer, since this function calls reinit_frame_cache (). >> It was probably just by chance that this did not seem to cause any >> problems for me. >> >> >> Thanks >> Bernd. >=20 > Hi Bernd, >=20 > Sorry for the delay. I'll start looking at this patch, but I first need = to play with > it a bit first and get more familiar with that area of the code. >=20 > In the mean time, I looked for your name in the copyright assignment list= , and don't find > it. I think this patch is large enough to warrant one Do you already ha= ve one in place? > If not, please follow instructions here: >=20 There should be an assignment on file, although it is signed by my employer Softing Industrial Automation GmbH on Oct 25 2012 and countersigned by John Sullivan on Dec 17 2012 The work that is intended to be covered by this assignment is mine. I am also the maintainer of the GNU Mempool package: https://www.gnu.org/software/mempool/ so I should be known to gnu.org, but maybe something got lost. Is this assignment sufficient for contributing to gdb? Thanks Bernd.