From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id msRlFGBGtmNwog8AWB0awg (envelope-from ) for ; Wed, 04 Jan 2023 22:39:12 -0500 Received: by simark.ca (Postfix, from userid 112) id 46D791E222; Wed, 4 Jan 2023 22:39:12 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=R9MXCUgr; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-8.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F21291E110 for ; Wed, 4 Jan 2023 22:39:11 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 25471385841C for ; Thu, 5 Jan 2023 03:39:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 25471385841C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1672889951; bh=taun2TqrPzYXTNTRgkIgTITGwyVJ00QxtG3G7fuOx1A=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=R9MXCUgr3feG/8B1jm9gnuQ8tHBS4K/F1l3ghi7mItb028a0/pYaJoGjqykZo+vd4 Ng6QFXwEuOrsh3RFf+ciWOo33kxbN4iZmy0LU2c9uDrxAgzogSk5M3SpsqKkx0J9oN Agjz+BLvN3ZDbwn0WGsYF3pE7FUKdeLe/4KxdDj4= Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id 057D23858D35 for ; Thu, 5 Jan 2023 03:38:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 057D23858D35 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 6558D300089; Thu, 5 Jan 2023 03:38:49 +0000 (UTC) Message-ID: Date: Thu, 5 Jan 2023 12:38:48 +0900 Mime-Version: 1.0 Subject: Re: [PATCH] sim: Move getopt checking inside SIM_AC_PLATFORM To: Mike Frysinger Cc: gdb-patches@sourceware.org References: <624505e8cc2a5551bef5de4e7c5fa0a0c21f3875.1672797663.git.research_trasio@irq.a4lg.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tsukasa OI via Gdb-patches Reply-To: Tsukasa OI Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2023/01/04 12:07, Mike Frysinger wrote: > On 04 Jan 2023 02:01, Tsukasa OI wrote: >> +dnl Determine whether we have a known getopt prototype in unistd.h >> +dnl to make sure that we have correct getopt declaration on >> +dnl include/getopt.h. > > this comment should note that this logic is kept in sync with other > projects like binutils/configure.ac. > > otherwise lgtm, thanks > -mike Committed with changes you suggested (since the logic hasn't changed, I consider this is a trivial change). Thanks, Tsukasa