From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id uFaVLnzOSWgj7QkAWB0awg (envelope-from ) for ; Wed, 11 Jun 2025 14:44:12 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=QOJaYTdT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B9A8F1E102; Wed, 11 Jun 2025 14:44:12 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 5DA981E0C2 for ; Wed, 11 Jun 2025 14:44:11 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D2944385735D for ; Wed, 11 Jun 2025 18:44:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D2944385735D Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=QOJaYTdT Received: from CAN01-YQB-obe.outbound.protection.outlook.com (mail-yqbcan01on20728.outbound.protection.outlook.com [IPv6:2a01:111:f403:241d::728]) by sourceware.org (Postfix) with ESMTPS id 0DC5F3858C39 for ; Wed, 11 Jun 2025 18:43:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0DC5F3858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0DC5F3858C39 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:241d::728 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1749667417; cv=pass; b=WPlptfN8Hven0p9whX3aGld+ll1fjCurW+W8hWGgURh3yH/Fe4cdcRMJUhun27i3Qo4yGEzk6RbvthMkrRCRNglhgr7SCQIJUWb7AD2hobQI23civ/gahcAJDo5oofKeMD7zGLVAFCeOL7mmK7KKPj/OmLNBmEnVO5NTmQwSx8g= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1749667417; c=relaxed/simple; bh=tzVjwW7/z+oCuD4tK44+Mg/eJccXh5h3eIn/+DAS2KY=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=WdxLFhasWh7esGiAjCLMQrmLLYDGV2FsmSR6NR6DZMNgPNXnS2ycRabBrVIhplpRe/SuqW1B5tcIcYzH5az/rHx5qTKF8DUIymH9aPbArivkBsv/FLZ7md/WTkKlpxM8FpMFMfG+f9zDEIo6MShaKsB+WoA13noeMFAiaXCNkUM= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0DC5F3858C39 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=YmI87JFcpj2SQiwY64buRLJT2JSB2gfQjqoyhVgAz6SaOxJUVfqQNyM7AXajQQwT5X0G+dZWhQKrI8wOGgABEfdFXsCsR6CHs4LDR3D8bKch+sHo0elEOGExqijWqCbggpgrhPgQIyP7jbHq+ZQq2kQkaPaHI2fi0t8riTCMx+c4LnS6VqB7bhaLG0hPW4qQZ1tYlyl4IxLEihvk1O+IG+/HAd3hHvv2V/AD4yZ+EFbsayIivmz/1G4FZ6r7ZWeeOTY/36kmaH/wClaHwNx5ueiOY+qgbXqCjZWXfZ/do+lHwhGdSnlZW9JELFFo/eocbwx8lFrskOy2YY36KNO5yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JXi/3LXC7HTifK4k24zT2Z62c8QtqcBCCBPo6B1kdVQ=; b=LD1+B+Px3w/7CrnNU924+aLzRzC+J4/YrQpgto5ifzhWknsG+Y6ex+QPh8m/DBR4S3kOYL6mXE8IlCNKgV5RLJ3/jc/HwhnOH4cEuJdtp9quFohsxqaT/tkb3bCvsHhxvuroU903vMffpYTp+0uUfg7Cd1sg/Alw0deGv7SAT1UuapIIfUZAyIEA6l99VAFww2wFC2mQ1eQmN6ltDwVI/qYib63tD/PZvMLB9hL0Xj3RPuR2+0EkfFtBwfgu6qOYQ++TMBev3Wkjan/r14/+vt7kb2GMQNB0oApesqGw0qO0FaqjU/uvewFAVXitR2R+iTEmZl/6o4TcYMh4IJIH5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JXi/3LXC7HTifK4k24zT2Z62c8QtqcBCCBPo6B1kdVQ=; b=QOJaYTdTQh9i8TEm2uuSJEtlIY8XZUu8qi0vgSkfvC23g2iK3thX/hi+qRADqvcLZghr7iUq9KnBFkT5b3Wl2kpnXJ/17rbtL9RQuMXjfxDAY0OpfaMivaGrcb4xRSN/z2n4vXvolH0PduwTsDZSKCC+KN958HmjHGRNbqbimKWHSzus9PrjCtp1HT7uZnGeOYwd+MKD6U/UVfsd/XWnbA9Zmcr3HVJlN7MQWFUAFqig6D/n0TyB+Ldqojv5lB8VYQbO5DXsBsrM1UqEo0gFJkafyq1RXIQlhpIvoO2pXYDStrvUkR2s0wCdHROIYIIoPyBg/FEkFRqIu7zdkoebBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::618) by YT4PR01MB9622.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:e1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8792.36; Wed, 11 Jun 2025 18:43:32 +0000 Received: from TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM ([fe80::d255:2adf:864b:1206]) by TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM ([fe80::d255:2adf:864b:1206%4]) with mapi id 15.20.8835.019; Wed, 11 Jun 2025 18:43:32 +0000 Message-ID: Date: Wed, 11 Jun 2025 14:43:30 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] gdb/progspace: add solib_ops pointer in program_space To: Guinevere Larsen , gdb-patches@sourceware.org References: <20250609194146.137730-1-simon.marchi@efficios.com> <20250609194146.137730-3-simon.marchi@efficios.com> Content-Language: fr From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQXPR0101CA0036.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:15::49) To TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::618) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TO1PPF18EA7E37A:EE_|YT4PR01MB9622:EE_ X-MS-Office365-Filtering-Correlation-Id: eb76af36-6443-41e7-1517-08dda917dd32 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?LzB5STFMZjB1cGloL20vd1dIUTBuKzBZU3grMXhURXJaTmlCN1pYN1Y1T0U2?= =?utf-8?B?NjFuYURUSE9FWmNKU1hKbk9HZytwZlpiV1pjVThyR000eHpEb3ZQT0JERmNa?= =?utf-8?B?K3hMMzNSUlViZXdOR1F4cldza0NiTUNvdUZTOXFHM3lINWRWWG1wVDIzUmV6?= =?utf-8?B?ZnZvdEczZ1pVV2VFVHRha0djdW1SVGdmZ2Vyd2ZOL0RMeEFnVmtweU5zb3lQ?= =?utf-8?B?RzBJcWZBbTJsMytLaHVlUjE5YUpFZ0xHckVmZ3hCTzFLUklQcFNJV0xiVG45?= =?utf-8?B?TGJjc0VJUHBhaTloT0NnelJZNGVZazhmZURQdU5TaWJYT1NvT2EycTdQSjhR?= =?utf-8?B?MHo1UDdRN2x3cEdvMUJyS2JXaGZMeHpodnMvYkh0dUxkeWEzK0xjMmVGb0h2?= =?utf-8?B?d3VkTDVUQ1RxemVUTzBzMjU3cFMrK3J0OEZBZVYrVlphMEZ4QTVzNzV4Y0VO?= =?utf-8?B?YkdVN3JpZTZVR3VWWm95L3lQSmRRU3I3bzhZRmRRUklBd2RsTHpqYXJMNlRk?= =?utf-8?B?eExHNXptVGIvYVV5bFpKa2RqMHdGbzYvWkNmSUQ4T0xNOGIvWkx3Vk92djBa?= =?utf-8?B?ZEVHYWtibmVvakNzcGtlaHNPYzV5RzJLNUdqNkhiZHlpbGJpd2xNMlJTYjdZ?= =?utf-8?B?K0RWL1RvYkVoK3Q1ZHd6ZzkvNzZlWTA4N1VxRDU1ZzA0eCtMbzl3UUZjcUFX?= =?utf-8?B?ZGtUa2FnbDJKN1dkWFFVMHczYm1zVTRPR0E1N01DUElJMjUyNlp3d1RPYlN0?= =?utf-8?B?SnNHMitnaWhxOTZUTWo2N3c5dVZnSitseVplQVBvZG9GM0dZOUhLRG9yVk9Y?= =?utf-8?B?NUx0N3JDM3l4NEY5YmJJbEppOGYwMFMvd3IzTWZPL0N5VEVWSlZWalk0U09K?= =?utf-8?B?ckRuTmZqemZEYXA1d3h0UlYvVVRtS1REaDhWQ0VLRlFDV1ZtUTJvNmtGRXpW?= =?utf-8?B?S0Y2SG9CWG1vMkJHZnh6K1RkMk5PL21TUWdKY1ZwWi9sblNmQjhZQTZyNytZ?= =?utf-8?B?WlQ3bWRDbC9SRU9lZi9qRE82N010aVN1K2ZJZHRVY1lNOW9OdkJBT01HSUtj?= =?utf-8?B?WW5zVURXdVE5T0hwVDhwYndVRlZtWUpYc0NNV3ZvaFJPZEJ0MERnNk44T25J?= =?utf-8?B?ZU94cnlSMHZkQVVUWHJqdDgxSDYzVW9uaG96eFdKWE5jS0dCblRFTDVrME43?= =?utf-8?B?ZzVFR2c2UWRENEJGd1IwNFJmTG5TY21nc0N2dTl5eVpRbGxYRU5lbTMrYito?= =?utf-8?B?eWR1SjVEZFpRVzZmVHJCQmJlODhkd0F4SkxTVng1MFRRVDNndzV4T01Gendu?= =?utf-8?B?Ni9DZUR2b3NscjVmazBmK3VSVklqdmtMNFZzUHRHMVZzM2NyQVJJb3BXNWRi?= =?utf-8?B?bXRTUkpXRjhyMVlic0E5T3R4TE1XTHpVSTdyMDkyeDlXYjhBaitSTm1adkRi?= =?utf-8?B?eHIyQnVTNWZ6R1phM3M5bWRlZ0tqUExWMUYxN3hOaGc4OHZYR01CTU9MNGVv?= =?utf-8?B?aHllUDFYUGRRNXNIWjJuanA2MUdHTXVjVFU2VlVlQUViZVZ6U2s4dEt6WlM1?= =?utf-8?B?ZHpWQXVGb0MyR3U2cmV4YmtCQ0IzMHpQVUJCOHFrWUg5a3RYanhwaUF2b09X?= =?utf-8?B?dEc1Tmk1MHAwR3FuL1MxYmtudCthM2owc1k3R0d6UXF0NE1QZWxqdHkrTUZl?= =?utf-8?B?bkxKY2VURDRoczgyQWdxYnZNTVZITlJGUHcvVktXVGt4NUdzNVRmM0RFb3Bp?= =?utf-8?B?QS9iRWhLTWRrVjFpOEZIR0lycUE1d3cxS0JtTnRoVUFNNjh2cXlZZ3FQUVFt?= =?utf-8?B?SERraFRRdkw0eEUwOHJ5Z1NTeXlKd2pMVzJRUHlCOE9SRDZwVUpEbUxlaWtS?= =?utf-8?B?aHBNNWdUM2dWeHJEd3JoUGhHdmF6MDRGK0taMDB4NTJOMHdiUzQ5QjR3bW14?= =?utf-8?Q?cWwdSVM5fqE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWFTc2JOTmNSaUh6eXg4dGdzNWRISXpoU2VZd0MvVkZzdlI2M2ZQdGF5OFRP?= =?utf-8?B?Y3d3UUdGWFRhem01UzE2Qm83WElGRFZWQzFnVjMzZ28yTEdOZXBPR3ZONUh2?= =?utf-8?B?cjREdXF0LzVUQTBmMWRWRHlGMnFBemNrY29kL0FtcjZRSmJVSWZNSWd2WEtO?= =?utf-8?B?NWxYSkhUMWFuTzJoWDg2eDlwL3ozblRHbXAvZVZoY3hOM3BrOVphbjhOMjJI?= =?utf-8?B?L0VXNk93UlpPRmpGZWlXd1RVd0tzQ0ZVbkFhZzlZRUpPYmpWbFp0SG5XTlZR?= =?utf-8?B?TmUybXAwaWsrR3FFdmhpQWNlUE9KbHR5UVpzd3dJN2hlc3BsSUZnM2IvR1Fk?= =?utf-8?B?aldLRlBsSEZMbnBYYmF4NzNaRFdzdFZKMnFnQkVJOWhPYlFpMGJjbmF4bkZT?= =?utf-8?B?ZTFSWm9nK3hEbk1acmNkVDBrOFNhczA5eXVEbDREc0dkTzhhalZVVlZ5akcr?= =?utf-8?B?a3FkY3RFM2h0WHd5MVMxa2dBMnk2VFFMTEpUMEFsUEJ4YlJDSFAvWWFZSEll?= =?utf-8?B?anJzYTlFY0Q1NDQxL0pMR0NSM2NmZFcrOCtMRlM3MmJYUTBabXVENHhaaFVi?= =?utf-8?B?NTVoaEpHSDQybXVPbzFDQmsxYTlwVTVRTjU0blYycnJ3aFR5RFlrOWViZkhz?= =?utf-8?B?YU1oZVZ4L1VoQlZOOWtIYVlYMGJZTHhZNGNTVlZ6YkFyNmp1NmprZ2xFVUEr?= =?utf-8?B?NHFpUE9yQWkxa3VnaGQxWTFrQTBRWnJsZTVzUmcyeUNWbzEzczNIekg1UmpZ?= =?utf-8?B?SkFkdUlYWVZLUTRBTWFwSzlMY3VEUDlWWU1XekUvVjVaYTgwUVRDcW8yNkFS?= =?utf-8?B?am8vNUZMdEo2V0VPa0tNZlFRb0g1N3FGQXNQczM0NU1FSGRtdFR0eE44aEVt?= =?utf-8?B?ZkxUNEdGSlhXQWVWMjhpWVFFRXlKYlovYnFjS0hMdkl5WlhiWXE4TEVBVzJG?= =?utf-8?B?dnV0TGwzREc2NzZ6Q3MwbGU4Rjh1bVRuZTZiTHV2d0hCSGg5MHZTaXRwVnd4?= =?utf-8?B?enJmYlhQTFFzTXMzN0x4SUFlSVBFZDlNVzhNb0FaYVE0QU5mdHo5aUlXUnNI?= =?utf-8?B?L3JyVStvb09UTUozbFJQV0wrWXBZYVErUmFNaFJnQms5aUM2S2xwakExV0pR?= =?utf-8?B?NGo1OHg0MlBKckh0U2xSSnFMRUN4UWMzWVFoQVJoT0ZibzltNkIwcWdDVXZT?= =?utf-8?B?MnErK0J6b0JJQXVjK0lNaFRFb0JDenArUEZOcjFMajg1Q256V2ZZSmwyL0FQ?= =?utf-8?B?RU5YRVFHRlJkOUs1eXBSdFFiQWVqUDlCRkJWTVE1ODdpQStUY0UrNFpVTGlZ?= =?utf-8?B?OWQxQXp3N1o5L3U1YllKQ3JWeUJhWC9qWlFHS0pFTjZ0WHNtQ1lmUzBpMmU0?= =?utf-8?B?bTFJdy9IRXFkQklJckVZYlQrTTZ6VkxXZm43ZjR3blpwYUE2c05vMmYySUFQ?= =?utf-8?B?UmVTRUV6VWxuODM4U2QrRTJ6bVF4RlBTVWRiNU5ycWhTcWFINmxPSnZvMVVI?= =?utf-8?B?MUF0bWN2NjdVOFlvZnhVaE9YejIrWkJZWHRLZWJGTHVBOHRSUFdYV1VMR1E1?= =?utf-8?B?Y01ETHVMS3hsVVFGVytiUXJ5dDF3UUZIVENIQzV4dG5IZVVRM2NiMXpHNTNS?= =?utf-8?B?cTgzZEtqblJid2ZETllxNGVEbVQrMGVWeEpNMWJnaVQvVTllTWllcVpxSWFF?= =?utf-8?B?WWk0cERKTGFiUk1BNjdmdDQ2OWw4YW84cFFRZm9jcFhGblRtaHgzQU83WUVS?= =?utf-8?B?WGhvNngxUzIxUlRTcDc3OVNJZnhuSklrRDJ3ZFpjanhIRVJVK056VFA4bU81?= =?utf-8?B?ZUpMejlFVHI5TFNWOXcybzFkbGdvODEvQ0k1NnhudituUVFUTmRMTjQzVHNj?= =?utf-8?B?VmZhN0lFTmJ5OU9nbkh3eWoxMXNJQ1hJVlM2eG92MWtpRUVJUm5lcTFFeExR?= =?utf-8?B?MnFiajM0RkpVa2ZPRkN5RFZqTWtKYU41cGd4RERKNk1PWk5xaDdHN09xWWtC?= =?utf-8?B?a0t6UTUrMlVqa3puVXF2NkJMTlhYUXBoZnFBemFRaWdkcmpMTDBiZHpmNmNz?= =?utf-8?B?UUxOaGhNbzc2U1M1eVV6UFY3cmNFZ0FtazJhYU5nWWVac0hvUkZ6UHJucDRV?= =?utf-8?Q?D1BWEtfxaxGYE8bdx3inwu5Ta?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb76af36-6443-41e7-1517-08dda917dd32 X-MS-Exchange-CrossTenant-AuthSource: TO1PPF18EA7E37A.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2025 18:43:31.9138 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GQdT7G18SR0BWDTfPtVrbc5qe8ks4UUf1WeOnafiNo2ybIRZFl3ZCOfMT3/jtitAPQzT4NjROsa5f/PFEJdtMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT4PR01MB9622 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/11/25 2:14 PM, Guinevere Larsen wrote: >> @@ -1273,9 +1277,9 @@ solib_name_from_address (struct program_space *pspace, CORE_ADDR address) >> bool >> solib_keep_data_in_core (CORE_ADDR vaddr, unsigned long size) >> { >> - const solib_ops *ops = gdbarch_so_ops (current_inferior ()->arch ()); >> + const solib_ops *ops = current_program_space->solib_ops (); >> - if (ops->keep_data_in_core) >> + if (ops != nullptr && ops->keep_data_in_core != nullptr) > > Can this function be called before the program space is fully setup? > > Otherwise I think we should either assume that it was set correctly, > or assert it. Better to be loud and easy to find the bug than > accidentally adding a regression in a hard-to-spot place. > > This goes to all other similar places where you check for ops != > nullptr. I don't really know for sure for all the methods. program_space::m_solib_ops is nullptr before you run the program, and I don't know off-hand which methods are reachable with an inferior that's not running yet. I'll try to see if I can figure it out. Simon