From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id o7P0Lm1v6mkjODcAWB0awg (envelope-from ) for ; Thu, 23 Apr 2026 15:13:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Zwr5yAK5; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Zwr5yAK5; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id ABE491E093; Thu, 23 Apr 2026 15:13:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AF92D1E093 for ; Thu, 23 Apr 2026 15:13:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3A5514BAE7E1 for ; Thu, 23 Apr 2026 19:13:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A5514BAE7E1 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Zwr5yAK5; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=Zwr5yAK5 Received: from OSPPR02CU001.outbound.protection.outlook.com (mail-norwayeastazon11013016.outbound.protection.outlook.com [40.107.159.16]) by sourceware.org (Postfix) with ESMTPS id 72C654BABF06 for ; Thu, 23 Apr 2026 19:13:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 72C654BABF06 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 72C654BABF06 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.159.16 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1776971599; cv=pass; b=rKBOsXxjjUNygrz555R9cuKICQwBhrbCMAz9YLoyxylKWuBmjbtYpk1Fvbq2J5EVwS568lnZ06j0PBl8nHuROMkemMnYyd7TPhhIV3QC+F2IHFT8ejYI3ZY0wziP24MRtFDid7G3hYDyaGSQQa+HoJoFvJEbAvJWVQkYJanzHhk= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1776971599; c=relaxed/simple; bh=J6TKAZiUfzhuPF0wBku9seZ9dciBYCp0+fAzug4osgk=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=ER6joSMfWjHrfH5KG029Zp/AYBdD3ToANkaHDAzNVrMK3podgg/fhcEKqJys03LTZ8I+g92MhYl5X1PaVBFlaKa4DKqOv93uAS5rSlJiyv5HR935YqDDeDG38IaHBjp/ZihrULUUa1Smv5Np/CK3EBrs9rLmZCSkVUdGF5XIXNU= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72C654BABF06 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=uLIbo+EnMQDELUdhxi9CHFKqK9zV+2+PtcflLLHNJANIoMay7YKCixH5P1mRPNKzRqwPQXyeG3GTi+2bdBSVMKx1/vD86k4ZSuyJ51VJojf9QKFitp/cCpVqdfS94plWtRY4v1KUaMC5cyArsB4DgIqkQElYWtC7DjFtTi4qt8SiGWJUcvrPJEB2Zt05icZc6WgSTlcHH5drszGx0Y0m6RpHHxrwAoAg9oaO5h9zlIyVxcoqox+3x8Z5gr7CDZ56zt3m8zhVg2mX/bsQEHcsWYAUiN7rVlyvJgXpbAwQOzklHmk15MOhjGZOwK/8wtjVpq5/VZlZ7IHbo/yAdsWKQQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B9vTD3UjCF3FzjoVtGhuSdaK53vAGn17JTgzl9cLQWA=; b=BhdIpLb1JVT0cUnEwEBJuCsDjRxEccgA/0NzaEPbTgyGlfoUXOSn9FJKhBRv7nBE0H5wBFppwBElVMWs87Kj1R9ZFDdig4hMRoNFHx1+SLOdDu2/Y0IZswE7BO9J8LTf7bYoeqc9sVJQqALZjueNKtK4lCbP5/3csJFMOcArj8/hKj0owTiS4/qLBA5xh5vyPdMXWHTQz6qA3RRUObfXteWfmTInq8r9tIJkfiW0/V5qUaMnd7c2kHLAvnc9rIIW4m1FFpQHlAYR+HOYmEQRp9FmmnLfLpgRv/qV/l8EeMZ4wWQN6BJGt84jibAKF4ECg/iQp67FOY60BePTXAFv3Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=tromey.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B9vTD3UjCF3FzjoVtGhuSdaK53vAGn17JTgzl9cLQWA=; b=Zwr5yAK5OK52NfhBGj87pS6zYV6/IEDw3Gqf3x1WxrX/la7+tDV6PRvt7MC06wLAu9a+/i9K+Jg1rc7ATARev4ldcX0ABf7OdlZrnWTMbk4fd+yOo8hQ0U8hogiiAWgWqjK4LLXCDem9EeorppduKyYWbnuZ8ajJBDUeaFgHJF0= Received: from CWLP123CA0206.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:19d::8) by AM7PR08MB5511.eurprd08.prod.outlook.com (2603:10a6:20b:10d::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.22; Thu, 23 Apr 2026 19:13:05 +0000 Received: from AMS1EPF00000047.eurprd04.prod.outlook.com (2603:10a6:400:19d:cafe::7d) by CWLP123CA0206.outlook.office365.com (2603:10a6:400:19d::8) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.21 via Frontend Transport; Thu, 23 Apr 2026 19:13:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by AMS1EPF00000047.mail.protection.outlook.com (10.167.16.135) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9846.18 via Frontend Transport; Thu, 23 Apr 2026 19:13:04 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=rf61GhEyjb1Z3mmheTDIwfSCUrHowW9rn6a/B+PRl6uxd9A+ARZYODwpLRG2CyhpxUuZW7xSp1+ctzGCk2bvzDtr1Zap8DfIZ7C9i5XBIXzPJDCWf8OplIuVMH2egS+axPmWp6hWuM8jcLexoJz1bKcEQG0XE7mSXPJxdvw4Kqz+2zJuZf/pukXHwoxgkFeG7hCAigt4eINmkL2i4BJK1KI6+NSy18/imnQCvClR5zqXg35InJLCyPx2/86ZjsJSwBkBECS8pduCXnCz0UcdSIhPskJw1k57ZP7niN9Lv7klfEPXct7NY8RFBJk1oN0e+uKuCh22sm+WIYrjZrVw6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B9vTD3UjCF3FzjoVtGhuSdaK53vAGn17JTgzl9cLQWA=; b=rCZf8BmW42xigVyS8MvCwoJX+w8SLRgqCHx7unrwBePClAs+r7sWNo3F5DHvUl9ck3LLG8LChPShEbsH+5Mc5rWkY+yhl+3FnyS2IS8m1hUpB3SToQgIyw87CZGPu7/BWdCXHpb0TGf5wTByiBPTVQIW5WRcV8YQE+elF1gxLyZ670lnL0tjyebNgYkSCeHxkkJs1V9jr85MntdDeZq7boodIZ0naZ0lUFlW+jfkeVnv9Ewkog7mUTkXYDw3P7IrvY9Q8LQGj+KwOgb0WwIV43zZMv4IQTuSNBO9XZjvPooqKcTJdgTJq48xrtPHlshSeR8/HINE9vQ802IOME05+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B9vTD3UjCF3FzjoVtGhuSdaK53vAGn17JTgzl9cLQWA=; b=Zwr5yAK5OK52NfhBGj87pS6zYV6/IEDw3Gqf3x1WxrX/la7+tDV6PRvt7MC06wLAu9a+/i9K+Jg1rc7ATARev4ldcX0ABf7OdlZrnWTMbk4fd+yOo8hQ0U8hogiiAWgWqjK4LLXCDem9EeorppduKyYWbnuZ8ajJBDUeaFgHJF0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) by GV2PR08MB8512.eurprd08.prod.outlook.com (2603:10a6:150:c2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.21; Thu, 23 Apr 2026 19:11:56 +0000 Received: from DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968]) by DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968%2]) with mapi id 15.20.9846.021; Thu, 23 Apr 2026 19:11:56 +0000 Message-ID: Date: Thu, 23 Apr 2026 20:11:55 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/4] gdb/python: eval_python_command returns both exit code and result To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260409105155.1416274-1-matthieu.longo@arm.com> <20260409105155.1416274-3-matthieu.longo@arm.com> <87ik9psdqk.fsf@tromey.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: <87ik9psdqk.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0380.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::32) To DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB8663:EE_|GV2PR08MB8512:EE_|AMS1EPF00000047:EE_|AM7PR08MB5511:EE_ X-MS-Office365-Filtering-Correlation-Id: a954f102-efed-4bcf-a386-08dea16c584b x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|376014|1800799024|366016|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info-Original: 0NRYAKiz9Y8GUKTaF9b6Ds01zN9WnWJcZapXrYXWYU1qOzKDyaNQVunb4QPY5s8CInh1hBT115JtUR/TisTRqJfbXK616Hjps7cXD1pzAuvUDc52n20/HBT78XmFdQftRl5cuSMQTFyWkZzmG+gYeK5xIGooNXCIN5B4HOBb+29svKJ43RvT05sotlKF8s8Fh7m03oqHYT+TPGHriSlnfvCC3vL1CI5EorVAvRQZTyqysQBtiC9ZjhswQYZ2DU4oWBuJ7x3cjRi8epl58FhcVCKfhbSkrcLGvEWvvd+CuNhWkQGBwg6X3n3HQTdZKSudlwxy0cIl/WX7CVUy99SujORBSBc7UXcUyqFbrQcXlWneEeifWyLq/lUVohJ+C1o7o+lRW50adf1LYgVDlqjwMxyZ6qcwuna90iypwLIDLNlx9FptWbSXlxUSe+9JoXVHrFMecZ+W6vasFWShsm3esvQeHFFGol1cWQpZ7iUoaLJoc78Vu+zDkwnIP75zjCzPIFld+NWztZYPgabUiCtTUAsKmC1/5A84lgLqK6EeuR8fTzKBXDgfbEh6O6ljr6jQljizOB1TlGjr6vWRU+yaPbTeIWEmz/PrrFwehtHJAq8W//ypHpAh9mJYCVzjy4rf8wtFmiJc3elBUqqGKA2fT0faBE9z2Bkltyl2/ZQLuhWbjS2XUw9Bjgv51NefpJJphquFwqKhf/0GoaJGaxxHaeXaLPYNulM3PeXupClxoiw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR08MB8663.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: LcPmHufp3U3eUDVW9PupcYnELOWS1FUIU9hg4TEyl81mH/SEdq3w9Eg3fjCXPox9C0huj9nhIbxlM0i6OP84BKmdI3aivoCe8/nByZWVBzt2ftqaAYlmQqTcjb3MIInPQmIL3p4a6LMoNaOD0H9ZWiYlCQZ+iAW1xoQMwJ/RNeNOs6yzHXyBSUnmCwEiARu++f2s4dns6M3hRGneQI6Gb+ZZb69LtVNNlaXzuRVZrE1YEMzaZCbLrJUnoQsdoxDQpcbu2aJuDsuwjs8C+KfucI1kEfZQfNQNUzRrJrYLgtGUFs1K/gJkxahsmTMzgngr0WF1XEDTLkT9k/iy56JGAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8512 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AMS1EPF00000047.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 613e87fb-911c-4fb2-35d0-08dea16c2f7c X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|14060799003|35042699022|376014|36860700016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: mgsgEZ9+ehM7mw3Qv5X3zOhHPOehcY+WDUOg2IRhcjPeSUfwbsrjt4K5nGVUgNWwXkww9RsRaqLBX0s+us/FhFT/0a/aWhc2XgsBvXAorcB5tfwy9wVqATt7M5suQJ+J03lL8fBKYct5vjtvGuzK1pGdByn7ant9TjhASzjgUnhpmjHSVH4lC8KxU+2BgzmWf/Wkf2pa+R+WAOVnTOPT3YrKGtMJ3KNL/EeL5N7ntwyOfixM5TdtHy++Tu+bJkTurGnLsLt/9ckUAqQkX5IG43oSMIxHwWbBic31wu/RM6saZcY+C2aZ+6TTwqPgol6sspGeTA4CzCCzTDikSN+kr1y23zWf06mb4mRVxUwTprVLkP7ALTBeiInTeBOSffLQidtgCiR2bYLWhK8R5xcSzTcgu6hxArH/SD4w6wHRfM/VertJuyfOJzS6MgaRe3GtEjnz273xJ/mYE93sjsWkXY9f5Boa+q6A8eZBTF08Fl2mCmwoKEi9PZ2slE3NcWGBAsI3V7Mk9j3aPXtF45f0Ab8ImcOypbPgdr7DVJwkC4VGlQlTXpjvutKe/rVVKxIoOdMr7qydd0D3/Qfrx6Jpfag/PO1BkdUug6sQ+3s+Kf6uWh+ZmQ9/ZOE1gbDyBcRzuKJk8l17duP/D499DAI6ZBuYu8S7dCLE3coktmj1skNA8x+dGwlKIle27jQUzVH/JM5vdx1EBpKvjpRdemwDzPu6YuqIBUI/qsEJiPY0RX50VUVQxMwNrMBD4tyDnjKBD7EMDHtFbHOQR95MHBXa8A== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(14060799003)(35042699022)(376014)(36860700016)(18002099003)(22082099003)(56012099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: sZldK5NMVJ5vYQ5d1qwTAuhXSrGq9c9LReArFw5thLTpesLIdXm0ih8aMBJcU8BOzaG1XHFQIp/5S7YRO9Yx3hrt18e8VE/e2fASY6usT5qwiixMDDCguNLvY0Bmk04v86r+NfgU8ktvhVwwe5J/z29rLe39KiEdmX/Ygly7jkCalJ8+ztjf6p+75c02lm7TXbzcswplEowtyri0KIpX9C0XYpltQSz3rWH6jUFuV03Vma6yCxZ2wALSjF81eOdlXeYxxuCVM4UPVJUckxwCxywNxmBgGG1rC2diZHA5u1liZZST0RfwrWbLVLpoTYQKTzwCrtB2n3EU6Ur3GEFrCzHOiC2Qsk/uZTWZyltaGPqNTP5HCNIiOKIBe0Mtc7t80+TPxFahGkXM9zN2hZagTfO7HynAO3ZRxMDMiV8mN9+3hdQ7ZkzJVRwitT1Qdgck X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2026 19:13:04.2693 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a954f102-efed-4bcf-a386-08dea16c584b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF00000047.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5511 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 17/04/2026 18:22, Tom Tromey wrote: >>>>>> Matthieu Longo writes: > >> A previous commit [1] centralized the Python code evaluation in the >> helper function eval_python_command(). However, a missed case in >> varobj_set_visualizer() requires both the exit code and the result >> of the evaluation. > >> This patch updates eval_python_command() to return both values and >> adjusts existing callers accordingly. It also replaces the use of >> PyRun_String() in varobj_set_visualizer() with a call to >> eval_python_command(). > > Could we have it just return null on failure? > And always return a gdbpy_ref<>? > Yes, we can do that. I hadn't noticed that NULL was returned in case of an error occurred during the evaluation. To be honest, the Python doc is not super-clear about what is supposed to be returned. >> --- a/gdb/python/python.c >> +++ b/gdb/python/python.c >> @@ -299,42 +299,40 @@ gdbpy_check_quit_flag (const struct extension_language_defn *extlang) >> NULL means that this is evaluating a string, not the contents of a >> file. */ > >> -int >> +std::pair> >> eval_python_command (const char *command, int start_symbol, >> const char *filename) > > Either way I think the comment needs an update to describe the return > result. > Fixed in the next revision. >> + if (mainmod == nullptr) >> + return std::make_pair(-1, nullptr); > > Space before parens throughout, though of course this is moot if > returning gdbpy_ref<>. Moot now. > > Tom Matthieu