Re: [RFC] Set process affinity in test to work around ARM ptrace bug

Pedro Alves
2016-09-02T01:00:41Z

On 09/01/2016 03:48 PM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> But since this is only for when running the testsuite alone, I could argue that
>> this masks the problem and thus makes it look like gdb works better on an
>> affected system than it really does. I think if I were working on gdb/gdbserver
>> on arm, I'd much prefer if gdb told me my system had a broken ptrace, so I
>> could act on it, rather than masking it off and pretend all is well.
>> How about we make gdb / gdbserver detect bad kernel version, and output a
>> warning to the effect? We already have precedent in
>> nat/linux-ptrace.c.
>
> Do you mean linux_ptrace_test_ret_to_nx_instr?

Yes.

>
>> I think we should probably do that regardless of any testsuite workaround.
>>
>
> Yes, I agree. I'll write a test in nat/linux-ptrace.c too.
>

> I happen to see there is a proc gdb_skip_float_test, so I write a patch
> to detect broken kernel ptrace in it, and use gdb_skip_float_test all
> over the test cases. How about the patch below?

I like it. This version LGTM. Thanks for adjusting.

--
Pedro Alves