From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4cp0Enu55mhQdiQAWB0awg (envelope-from ) for ; Wed, 08 Oct 2025 15:20:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 4706E1E0B6; Wed, 08 Oct 2025 15:20:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ABBF51E047 for ; Wed, 08 Oct 2025 15:20:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5B1653858CD1 for ; Wed, 8 Oct 2025 19:20:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5B1653858CD1 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by sourceware.org (Postfix) with ESMTPS id A55713858D38 for ; Wed, 8 Oct 2025 19:19:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A55713858D38 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A55713858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759951191; cv=none; b=RttI70wuyPdFhtS+WAWNGUw+qa7IN9LYFITwfx89XOb4LOTp5HVvlLhjov1OnFGgkU+XEFckd65n22yF/YunZgZ/ZqTnJiuef4e6RWdRvT3bf258R3EEpBSuLyGBSKJ/QzNjCYshQR2C9UEzjtElgcAQv9HeXI7aBeHgMk78s4c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759951191; c=relaxed/simple; bh=c689tOT5Ys1RSw6vpgcKJUGTv9CVHTF9ycS92ng34iE=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=L+7KrvC6lP/Q6jcbggj17EvWoAag0hi85/F26yCM1BaiVrYTyvZvcLbw09W0uhgrDkgWQZKiVghKkmUa+CWSJHoyZTgsT3OYddHNuIfjOntHVgArrPp1hvnNUglaMvVm5JyOmGkeauasoeKwkTa8+VEsx1+xXWJyJvXj530DauU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A55713858D38 Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-46e29d65728so1213635e9.3 for ; Wed, 08 Oct 2025 12:19:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759951190; x=1760555990; h=content-transfer-encoding:in-reply-to:content-language:from :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=axNKA9Goh1PXDYWWLQ6avIelfaRKsg9t5HNOka2cWvM=; b=jADwxNT3Chwb6xHhAb7CnIbaf2wAD2pXjP+iY7xUoe2EtlkvwuL8ZgzrASBBX9/UUb XVzN7x9wniQ0RwYd/2PDWdFjP5u2K8D9aTDjMrW37yokiEklAGnUE1pdETNgy1sxJp+a s9NBOdML2DcZSA6FOcbQ3xd+XJUbWARRsiBafAGT5TUnOuN1GrIw870dEO7XWm9JeOrN qbAEeFbj7+1amwZsoHCEiMoFnlIf0FT03QVQqJBzB592Oi6uIqR7bkeP+hxtVfxza+Qd vwyvsZbaIc7AZoDHSevY85SX8DeW3pIBfObwBPATWcELwBsYsgrFfkuVxesH3a9lJ7Vw jU1Q== X-Forwarded-Encrypted: i=1; AJvYcCW5n/55KdeDZPtdkAIHp3mgbWiA96Lfgz2PyrcdKGrxAZ6yEiaeKvfLyyiYfnUYcEZgqRYXLynMrip08Q==@sourceware.org X-Gm-Message-State: AOJu0YxvHqOwJgs1sfHYkDKfd9yJHneYN2Iou8kGJtAyrAwlai0cfusU +l8nr9a/wEGJX2ugOS8BmLZz19IbQn8aWqKbaypN06+eL95rPgyyK/u4sWlwLW7mHFw= X-Gm-Gg: ASbGnctvM1zPG3WY65JHvMnemAnybVhpB2Nv6hVjtzoOtqB5UUZPxI2Zl5CGJiEvBaZ ae6r+FKHgh18h5xCElYiakiWkwSN3KVkxOvxI/r6acGJlK9X1SJs5lfE8a5kkp9rVvfkuJM7fUc zCBwJNd1FR2Bp5olWDkaWsQoni4oWy54VtSAAuPSzPW/mJUxdlPTsKcPt5qyqyzo5S4edygweLT R76eYPOKmUoQ9RiZAxWeMRt5K8JVgIt2E53PrpDOTVo6s0sLWgUPpFXRZ2Zs73cP67Vrhp6VCqW MNrXj8EGOCSBoENcvW0xDA+57NsWyvVLYgsntMAoY+zWTAlh09LPOneyr/tW4LhS4BfcxVbcrgn 2UdLihkqKAG8oOgOx5pndL07TqDBgxPY1WAy7EFmMIF4SjSKxK4mJwjyJGg4V6HM+HbiPLTsekL f5HtJyZQz+ydm61w== X-Google-Smtp-Source: AGHT+IEetkywGt9oPqW40uz1nzOpj6Kt+S+ukjXynJWovzPotRHmHHQ8up1RRiXSnB3TaL+/TwpFrQ== X-Received: by 2002:a05:6000:615:b0:410:3a4f:12c5 with SMTP id ffacd0b85a97d-4266e8e6da0mr3100347f8f.60.1759951190254; Wed, 08 Oct 2025 12:19:50 -0700 (PDT) Received: from ?IPV6:2001:8a0:faca:8200:c316:a196:4fed:9f36? ([2001:8a0:faca:8200:c316:a196:4fed:9f36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fab36a773sm20969845e9.0.2025.10.08.12.19.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Oct 2025 12:19:49 -0700 (PDT) Message-ID: Date: Wed, 8 Oct 2025 20:19:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdbsupport: bump unordered_dense library to 4.6.0 To: Hannes Domani , "gdb-patches@sourceware.org" , "simon.marchi@polymtl.ca" References: <20251008161047.1381033-1-simon.marchi@polymtl.ca> <1362579628.1523332.1759945710904@mail.yahoo.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <1362579628.1523332.1759945710904@mail.yahoo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi! On 2025-10-08 18:48, Hannes Domani wrote: >> +// includes , which fails to compile if >> +// targeting GCC >= 13 with the (rewritten) win32 thread model, and >> +// targeting Windows earlier than Vista (0x600).  GCC predefines >> +// _REENTRANT when using the 'posix' model, and doesn't when using the >> +// 'win32' model. >> +#    if defined __MINGW64__ && defined __GNUC__ && __GNUC__ >= 13 && !defined _REENTRANT >> +// _WIN32_WINNT is guaranteed to be defined here because of the >> +// inclusion above. >> +#        ifndef _WIN32_WINNT >> +#            error "_WIN32_WINNT not defined" >> +#        endif >> +#        if _WIN32_WINNT < 0x600 >> +#            define ANKERL_MEMORY_RESOURCE_IS_BAD() 1 // NOLINT(cppcoreguidelines-macro-usage) >> +#        endif >> +#    endif >> +#    ifndef ANKERL_MEMORY_RESOURCE_IS_BAD >> +#        define ANKERL_MEMORY_RESOURCE_IS_BAD() 0 // NOLINT(cppcoreguidelines-macro-usage) >> +#    endif > > This mentions '(rewritten) win32' and 'posix' thread models. The win32 thread model was completely rewritten in GCC 13, that's what I meant by '(rewritten) win32'. It seems like this isn't very common knowledge, which IMHO leads to people still using other models when they probably don't need to. See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115105 > What about the 'mcf' thread model, No sure. I've never used it. Did that ever make it to GCC upstream? I'm under the impression it did not. I don't really know if there is still a point in using that model vs stock win32 since GCC 13. > or is that meant with 'rewritten win32'? No. Pedro Alves