From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 5YjRC9ofiGq9gDMAWB0awg (envelope-from ) for ; Fri, 21 Aug 2026 05:52:26 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=hbDJZM3o; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 18B8F1E033; Fri, 21 Aug 2026 05:52:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2F8A01E033 for ; Fri, 21 Aug 2026 05:52:25 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EF8AF4BB1C03 for ; Fri, 21 Aug 2026 09:52:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF8AF4BB1C03 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=hbDJZM3o Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by sourceware.org (Postfix) with ESMTPS id EF4CF4BA900E for ; Fri, 21 Aug 2026 09:51:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EF4CF4BA900E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EF4CF4BA900E Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::432 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787305912; cv=none; b=L4HMwYufNurF+k/DkE3DgCMI/N7widxo36ikRQoUQu7iNH7c6y/bp8am+8QHVZLLZW3XfFTyL5++Z/JZmEFM9Mj1ivOhScCAAqDwrrBoEarpFH40vtdbTXuEd5p0zKcpftvxTEBTRVrxPOliUEjfRv1m9M0mIlSmAdiq5A/0cZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787305912; c=relaxed/simple; bh=MfIgrgC0pM0vc5F2xwJwV+zpcn/fsRRrcJkCrod6yX0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=YxQi1lbWsQHrHYuTsGJqx0Km9xS1w8kuLOyEHs02suioaG/xZ6h331vZEgmsvlDg9nvGJRs+EFJS8MvoZcMwRAsYcFYsnTdN3Avac2oSVzr+Y9ic7pX2oyS46drDC+9kWGS96XiMJ3m3n3zL7ZcLPt30DYl8ClbuNRfUepw8vVA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256 header.s=google header.b=hbDJZM3o DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EF4CF4BA900E Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-47fde295992so575731f8f.0 for ; Fri, 21 Aug 2026 02:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1787305911; x=1787910711; darn=sourceware.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zMsakiU8LCZlZKEngL/5JajcZau4KHVIJH6V4i9/1lU=; b=hbDJZM3oh/5KqGNah0OPBj77HEiWsBvjMY7uiABnu6hfRXYKP20TdPBF/wtaJI2EV3 AS1Krv8x0MYi7wqDUEBrJGDD2g68DmVnREK10/HBqGUKeZP/zge0K4Psrg1Fad3qO9Lv VqAYCK24b2UN+kFiiDzi9x0j0GOj0a6cfr4lWKdR98CX0DJpuogAkbsyXLAQbwsK19PP rBnKCvr6khLyp/Jz67juEJLwOBGR05XVmXGKh+30tmQPb5pCnR18EaYuKm2wWZ/eM/E3 MEGfspA82XEZpFylQYDiTYDNptTT2U7ZNzXtTq/k64CA+mp51dLddUbM/h6W04d9mZD3 MXgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787305911; x=1787910711; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zMsakiU8LCZlZKEngL/5JajcZau4KHVIJH6V4i9/1lU=; b=MKMSK2lJzU767OtI/rXcvW4UCL00erWksv/AIWUjDTgiwPtOeKvSku48FXAZ4gnvzX tq55VcQtN3dnOh+GyJW94uhlGLWdGN/Q6DAZH0kSQ1gislo9KVhxIBPfyNidnhi298eF L0gusWEwG5+ERfkJ6PJaVmpVRocVxBrjYd6W+1nKZ9or5JiXnaTpx2VwgyWB0M3yV4mo NmR7rKhTLLuWPLwKVnU+Gx0b4aHzyeERGpn6tDtGe6DIqgPGEfX346awJQf1lwetmaFa bwXqJV9xLm2p+FDPmSKRaeA3djG3ufu4IWAlsolRcD6hxa+8hvEC5qPU0MYIDBot11un Aqjg== X-Forwarded-Encrypted: i=1; AHgh+Rr/5nsCh3SNAdO5xpNHxRVy5jae1dXVyMPb5VZulivaKs5Sv8v38jwfUxHQZygQfCq1auBxGbO4HQngMQ==@sourceware.org X-Gm-Message-State: AFuF++llZbQQsqcjNGbHugg6+GYrkbGxpl/DF4DGYwJC/31L/gLkYVYX z4vJlmEGF6s8Hv22Fhq+//jb+S24hrUUFEq2ZEeHl1o7eNHrCLBMfuQP7TY7JLKTy68= X-Gm-Gg: AR+sD1247jGY0H/CL1yJAeT20RrCgtMGtS9NIH1eGf5ER4dSvqpIWXSSqa+qVyLl9lU AXgcm67FLAPGCZ5cWJsz8WyU/ZkOehpKfiKY4Ztb24nO33WTNa93fnHis+JTajxZ5I7qFiXvQDl nx0c+jQQhljqnsN/t79jS8EF6kBAk+oXGseHS+WMkEwLMrzVNE14JXYsH2EcUY6SIjjwwj7rrOf prFQpAapWAURFD6qJFFju0+0gVojccVzRDpktGYe25+t2ZsCEBhOEwP4z4srzIFmIeMm1BSWddl vWVTkMaYj74adHPfFzrG2PJIb1qVni+/ebri7N99OH4MYqK07noBXmqZ+R7Sbt6OnRDA6SNf5qC g9R8gIbwkp/Yg3OC+c2OCR7FqZQXmO0pl/Nl8A5gPQbFip5npEdG+Tb8xQIXXUunWf4WKp4BGhj DyZpOsY8WZKRitl5z3Raq30r3sOdx6Quwr9aPsIXP4S+OI5ph31bTHaibMLeoYPBrWxp10TKUPO Su0FxwSLajxpKcoBlsBhFlGwufCaXPIvLMtqjl4JcKF/EYhwQTDImhBLjFI4qad X-Received: by 2002:a05:6000:3104:b0:47f:8554:a341 with SMTP id ffacd0b85a97d-482b784c4bbmr20270747f8f.13.1787305910930; Fri, 21 Aug 2026 02:51:50 -0700 (PDT) Received: from [192.168.0.55] (sals-04-b2-v4wan-167965-cust660.vm36.cable.virginm.net. [80.3.10.149]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b14b8050sm17133975f8f.19.2026.08.21.02.51.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Aug 2026 02:51:49 -0700 (PDT) Message-ID: Date: Fri, 21 Aug 2026 10:51:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add missing null pointer check in get_sal_arch To: Tom de Vries , gdb-patches@sourceware.org Cc: Simon Cook References: <20260729150617.3502554-1-craig.blackmore@embecosm.com> <48674391-f007-412e-8e47-3911d75b9378@suse.de> Content-Language: en-US From: Craig Blackmore Autocrypt: addr=craig.blackmore@embecosm.com; keydata= xsBNBFdIF8oBCACwrsvc6YVfzJRT+ZoBfL9jEb8ITwNahDxCGSG6sIWrJ9UFeTwE8fnNhMpz RyFRm0OXruS5k/8YHJHrxKxFY9cgZ3CWNftXEjRqURUWGtN/ESiw0J7nVfhSGQTo3LBzpXZ1 0JHk4ZHKDJKYa+fhybCHOs19BfP3HydHoTlc5QTKMfom0X/xo7WDdwUYeZsjD9u8IzHk7gNw 05Abk1vqni+J7Fghjp4RI8W3IsjpKOfV3f02OyO/MTSraXNyejO4JRl0A8b3q1Lq+G6Z7o5n LVief5JpkRyzWQSawTIBKmRZa9EzAKZXd6IJdY/sZt7pTir5EP7MHq4a+AtKfKuDkrDDABEB AAHNLkNyYWlnIEJsYWNrbW9yZSA8Y3JhaWcuYmxhY2ttb3JlQGVtYmVjb3NtLmNvbT7CwHgE EwECACIFAldIF8oCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGEeRQLLl5WtydMH /1nYd9jmOBaF8w5gGgjF5eOO5b/cdUegmO///VYj/5R7iF/zbB6KgF0Obo5h2gG9AIfsZG+T ybuTx7oU1DZYEIndw+YP9c9Yi5de5UzEHwbJiV57W0n+MP0Widgw7p6XJmUQ1XbHxdcWp7nY EJa8ASKLuuIhO8JFUXbQ8BcUiWbsA/JxgCzeid8iixGrzPWj6iFzoK2mX4GqP+24pXSDUamM TXmSQd2taYEsyUdJNiEkUC51ncRcMuThjdtfn6Ok+7lHjh3Zz8q0keJz5pnIp4EXdkAgKSjq U42PMrd3v1HoIFINTtr5F23OdkxoQzysu4GMO4pkw5pwz95Uckr08ojOwE0EV0gXygEIAKv/ luYHmCG/qefgzdbnegwMdG5753NJ+zGxFltFX6aaOPZ8go9Omf6zwjybUKv6Qx6AlDanwCl3 ewVQs+h9iW8uaQBRgeDmwAGMG/doBiFqs7X0jBf23exMiJezXlKb2ZlKzMAbzJ87408AzRaV sZdwEpXHVi2mRPoXtMrqL5iQEyG5hdx2ySj5164DIgVOs/ypFiaiFaDPkIcAQTzJrxsbt6pf iI9kT93DO9nRKVV0pPWztV8P5gKM8HY2rS0wQcfrqAU6T89Aa0VFw92J+w5d2spF8MUNPsvR NLm9ooCF3YME9STYHXrNH1U9fJUWpIC+b49UoWSWRD9nwl2h2i8AEQEAAcLAXwQYAQIACQUC V0gXygIbDAAKCRBhHkUCy5eVreLbB/sHPs1xu78uNV8O4UPTX7D5zBBS3nsrbDr+8stmXRap xbvo6kqKzIMAXuO3bYB/NyJ/tFzuFr9Tjd/2g56D2186bp01/kgxJ9CEl/m2T3lG3DlxIoLg pCExzTLTb8zH/7/6mdeJ17cdnrK+2QAKYctReVPAC67cq5KmUyU3bv5e1JzhV4ezz/i/O+Jv el112ZEsa54ya9KZOUHbgAR6hLnRWIa+8yQTtXqYRc3LxLRfS80Wn0Err1YvqFYzJsQMC8ND xAeEuqQ1gfk1b0jmv7tYljNqsHqzGVbuWz6hyzyLv5GjcdSDKpbw/797gRKQSY8Gty5ynfUH O4kKyuZPrE8P In-Reply-To: <48674391-f007-412e-8e47-3911d75b9378@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Tom, Thanks for the review. I will include these cleanups and the suggested comment in an updated test case which I will post shortly. Craig On 31/07/2026 14:27, Tom de Vries wrote: > On 7/29/26 5:06 PM, Craig Blackmore wrote: > > Hi, > > thanks for the patch. > > Here are some comments on the test-case. > >> new file mode 100644 >> index 00000000000..7758a591fa7 >> --- /dev/null >> +++ b/gdb/testsuite/gdb.base/bp-non-alloc.exp >> @@ -0,0 +1,36 @@ >> +# Copyright (C) 2026 Free Software Foundation, Inc. >> +# >> +# This program is free software; you can redistribute it and/or modify >> +# it under the terms of the GNU General Public License as published by >> +# the Free Software Foundation; either version 3 of the License, or >> +# (at your option) any later version. >> +# >> +# This program is distributed in the hope that it will be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program.  If not, see. >> + >> +# For an ELF that has no section called ".text" and the first >> section is >> +# non-alloc, test that a breakpoint can be set on a function. This >> previously >> +# caused GDB to crash due to a missing null pointer check. >> + >> +require is_elf_target >> + >> +global srcdir >> +global subdir >> + > > These can be dropped, they are only necessary inside a proc. > >> +standard_testfile >> + >> +set linker_script $srcdir/$subdir/$testfile.ld >> + >> +set options "debug ldscript=-Wl,-T${linker_script}" >> +if {[build_executable "failed to prepare" $testfile $srcfile >> $options]} { >> +    return -1 >> +} >> + >> +clean_restart $testfile >> + > > The clean_restart can be dropped if you use prepare_for_testing > instead of build_executable. > >> +gdb_test "break main" "Breakpoint .* at .*" > > You could also use "gdb_breakpoint main -message". > > At this point, I wouldn't mind a comment pointing out that we don't > run to main.  I tried it out, and ran into a SIGSEGV in the inferior.  > I'm assuming that's expected: > ... > $ readelf -h outputs/gdb.base/bp-non-alloc/bp-non-alloc | grep Entry >   Entry point address:               0x0 > ... > > So, perhaps something like: > ... > # The executable doesn't support actually running, so we don't run to > # main here. > ... > > Thanks, > - Tom