From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by sourceware.org (Postfix) with ESMTPS id C0940386EC28 for ; Fri, 18 Sep 2020 13:01:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org C0940386EC28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f68.google.com with SMTP id q9so5262182wmj.2 for ; Fri, 18 Sep 2020 06:01:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sEi0EALfW/xCAET1MGhmeXdLFu2qvR5JF649Comgcd4=; b=EimighxoCTeFNVPap0QbONl2aOqMzcZsL/DvUJHcj5Sx+zEgvntMCQeNG7Jo1E2vLA oXYBEQmzCf7lEpQNG2gF3FnaHTMbsoxCXR4xlNgP1GPB5gjsjNIX4fF36H0j5pdtVrlZ rzzek+bg80t8SErgx/cFAElIt8E+pBWZVba/Qv1sjqAtKDGDSvKMiW306cUf3U+NJUqW UofgTv3cx8UXEadiT2KfQoqHyMD3WWyGIjXvPB47ihBBrhVw2SLD7hv2XMRAWXHPk1yo SUZYKSSPofaaRvIAtepoZfFCaq2cRRTVfNsVzwIttbl9H6+Lka6ObOuIgzgww2arotMS YbMw== X-Gm-Message-State: AOAM530PdEMEFpOONa/GmiWQyJKb3VXxPwHJmr18DnFG4YHsnkkwDvO0 9dXTWKpUvfK7f9dkh0XMHE32f/auAL65zw== X-Google-Smtp-Source: ABdhPJwKwDupqZJp7k3fQqmlWTC/WekjjQQa7MXNy/qA0WXHgWZM0rzgfIxGCd5izRzsjkk076Bjhg== X-Received: by 2002:a1c:a953:: with SMTP id s80mr15329149wme.70.1600434112186; Fri, 18 Sep 2020 06:01:52 -0700 (PDT) Received: from ?IPv6:2001:8a0:f905:5600:eefd:c63:53e0:3e8a? ([2001:8a0:f905:5600:eefd:c63:53e0:3e8a]) by smtp.gmail.com with ESMTPSA id s17sm5354182wrr.40.2020.09.18.06.01.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Sep 2020 06:01:50 -0700 (PDT) Subject: Re: [PATCH 1/2] Split gdb.multi/multi-target.exp into separate testcases To: Simon Marchi , gdb-patches@sourceware.org References: <20200917180038.29226-1-pedro@palves.net> <20200917180038.29226-2-pedro@palves.net> <32ae5490-6e6e-0c82-f5a7-7675ea33b997@simark.ca> From: Pedro Alves Message-ID: Date: Fri, 18 Sep 2020 14:01:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <32ae5490-6e6e-0c82-f5a7-7675ea33b997@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 13:01:58 -0000 On 9/17/20 8:41 PM, Simon Marchi wrote: > On 2020-09-17 2:00 p.m., Pedro Alves wrote: >> gdb.multi/multi-target.exp sets up a debug environment with multiple >> gdbservers, multiple native processes, and multiple cores, which has >> proved useful for exercising a number of multi-target scenarios. >> >> But, as we add more tests to gdb.base/multi-target.exp, it is growing >> a bit too large (making a bit cumbersome to debug) and too slow to run >> (if you have glibc debug info). >> >> This commit thus splits the multi-target.exp into several testcases, >> one per use case. The common setup code is moved to a new >> multi-target.exp.tcl file that is included by all the resulting >> multi-target testcases. >> >> gdb/testsuite/ChangeLog: >> >> * gdb.multi/mtarg-continue.exp: New file, factored out from >> multi-target.exp. >> * gdb.multi/mtarg-info-inferiors.exp: New file, factored out from >> multi-target.exp. >> * gdb.multi/mtarg-interrupt.exp: New file, factored out from >> multi-target.exp. >> * gdb.multi/mtarg-no-resumed.exp: New file, factored out from >> multi-target.exp. >> * gdb.multi/mtarg-ping-pong-next.exp: New file, factored out from >> multi-target.exp. >> * gdb.multi/multi-target.exp.tcl: New file, factored out from >> multi-target.exp. >> * gdb.multi/multi-target.exp: Delete. > > Maybe a small comment here: I think it would be clearer to not > abbreviate "multi-target" to "mtarg", so to name the files > "multi-target-foo.exp". Abbreviations like that are a bit intimidating > when you are not familiar with them. I made that change, here and in patch #2. I agree that it does indeed look better. I also renamed the mtarg_prepare and mtarg_cleanup routines to multi_target_prepare and multi_target_cleanup. I merged this to the master and gdb 10 branches. Thanks for the review! Pedro Alves