From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83019 invoked by alias); 16 Sep 2017 13:57:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83009 invoked by uid 89); 16 Sep 2017 13:57:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 16 Sep 2017 13:57:09 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v8GDv2vu014424 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 16 Sep 2017 09:57:07 -0400 Received: by simark.ca (Postfix, from userid 112) id C849B1EA9D; Sat, 16 Sep 2017 09:57:02 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 3CBA71EA9D; Sat, 16 Sep 2017 09:56:42 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 16 Sep 2017 13:57:00 -0000 From: Simon Marchi To: Walfred Tedeschi Cc: palves@redhat.com, qiyaoltc@gmail.com, gdb-patches@sourceware.org Subject: Re: [PATCH] gdb - avx512: tests were failing due to missing memory aligment. In-Reply-To: <1504687613-14649-2-git-send-email-walfred.tedeschi@intel.com> References: <1504687613-14649-1-git-send-email-walfred.tedeschi@intel.com> <1504687613-14649-2-git-send-email-walfred.tedeschi@intel.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 16 Sep 2017 13:57:02 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00435.txt.bz2 On 2017-09-06 10:46, Walfred Tedeschi wrote: > Test was running on a fault during code execution. Analysis have shown > that the wrong instruction had been used. An instruction that takes > not alligned memory is more appropriated for the task. LGTM, you guys are the experts about that :) > ChangeLog: > > 2017-06-26 Walfred Tedeschi > > gdb/ChangeLog: > * testsuite/gdb.arch/i386-avx512.c (move_zmm_data_to_reg): Use > vmovups instead vmovaps. > (move_zmm_data_to_memory): Use vmovups instead vmovaps. > > --- > gdb/testsuite/gdb.arch/i386-avx512.c | 128 > +++++++++++++++++------------------ > 1 file changed, 64 insertions(+), 64 deletions(-) > > diff --git a/gdb/testsuite/gdb.arch/i386-avx512.c > b/gdb/testsuite/gdb.arch/i386-avx512.c > index 52c0ead..3e955a4 100644 > --- a/gdb/testsuite/gdb.arch/i386-avx512.c > +++ b/gdb/testsuite/gdb.arch/i386-avx512.c > @@ -127,44 +127,44 @@ move_k_data_to_memory (void) > void > move_zmm_data_to_reg (void) > { > - asm ("vmovaps 0(%0), %%zmm0\n\t" > - "vmovaps 64(%0), %%zmm1\n\t" > - "vmovaps 128(%0), %%zmm2\n\t" > - "vmovaps 192(%0), %%zmm3\n\t" > - "vmovaps 256(%0), %%zmm4\n\t" > - "vmovaps 320(%0), %%zmm5\n\t" > - "vmovaps 384(%0), %%zmm6\n\t" > - "vmovaps 448(%0), %%zmm7\n\t" > + asm ("vmovups 0(%0), %%zmm0 \n\t" > + "vmovups 64(%0), %%zmm1 \n\t" > + "vmovups 128(%0), %%zmm2 \n\t" > + "vmovups 192(%0), %%zmm3 \n\t" > + "vmovups 256(%0), %%zmm4 \n\t" > + "vmovups 320(%0), %%zmm5 \n\t" > + "vmovups 384(%0), %%zmm6 \n\t" > + "vmovups 448(%0), %%zmm7 \n\t" Any reason for the added trailing space? Thanks, Simon