From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id F00E2393741B for ; Tue, 17 Mar 2020 17:08:46 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1584464924; bh=Pv+3WTtvgFORvfUCF2TMOIDHPnTWfab/Oix/7guR+9c=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=ayFrI7lC5HltpRyab5TrEONvXO1ketw/DZjMqMwRg7Y/4/tzupql+e45AyRg80MsD MjLYP8Ru+mPtguAIjC9giMa6UQcHYdVJxaU/nMF9LPI3UxkvGFJkp9/Qqnkqwd2SCv UYYhCrHmIxFr9PKrCEnfneJoSqu2mYZUBfOkR5G0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MBUqF-1j94Nf0IzX-00D3FN; Tue, 17 Mar 2020 18:08:44 +0100 Subject: Re: [PATCH v4] Add support for NetBSD threads in sparc-nat.c To: Simon Marchi , gdb-patches@sourceware.org References: <20200317164603.10840-1-n54@gmx.com> <10f3399c-84ee-4cc8-b9fe-a3057fc070eb@simark.ca> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: Date: Tue, 17 Mar 2020 18:07:35 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <10f3399c-84ee-4cc8-b9fe-a3057fc070eb@simark.ca> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iGhw6Eyi34yp72U6cvYP0qoTZvMClfjGx" X-Provags-ID: V03:K1:0/Jj8DxkvsoUj92VZ+6AOU716VfQANhjKnQhbFbAOCgqL1weP5O NkZsj/4DAVmLg2gS+Yo7bViklUuW7sKiOSmUa8DJGy/0O42gKTV93bdUPOl3Rb27skukFEK X4tF7eCg18k+z0zIMjwNYRWp4PGirf4w0e8TnulmnY/5gEqBpqt4ocVk7QuUvlT8xwH8XFC 14VlzsowozsXzSwlVDURw== X-UI-Out-Filterresults: notjunk:1;V03:K0:vl8PsGCIl9U=:6K7AldJmhqfOAAqwcAxmpG EOO36U8bIO5LgLZsuPMH0ronEpj8BQXrDSPEwAJcZMf67xzTEROEEGk9NHGhU2LreKjE/f3yT Hyn+p/fLAx6VIr1mH/6vCxTdMDDh0NCGdnrgd4ShKsoyvQXiH0jfTbr05brkwefpbYxoRbc4g bQXTQkgYxD1/djazJNhjmtFyF221Eirzc0pcpoxhS5zgcgo3ytl1pQ0b0YB3r7x4pkkxONoUj B4KSpo5T/TJ5kpfLtTjZr6lhOrSwsWC0BjhrMdnOcq+tOTcANdo6VcfyvN9qJDePUGGuhOPQ6 qHAN1SU0soi62BuPxuVbAN03SpVdTGm5QhUTVcJJZ6P511NeQvxF6O4CXZmkXpwmSqs1fEyY2 JfTP2cq9oPbNZmtxmSktI0Xh3niN8Qzjv7zHw6DrlDK+xYWzXLFsIF7+Gs3jZHPA9vV1QRFBB a/uardRM81mrOWLE7nqiI9PeI+AzglvZm6OUCdPqKWm3NJ4e4KXEoLxaLqEpRV9VVh0rA1uxS 07atvJ/OnUoOqciULUTyY414HlY2MdnLiyw1XQbbFXj48IRnoD2IyGm+oyQwi0xzOuVa1Vmdh ENIBIN2zA+tt8EQfRnNU6eHRGVBLzHKQ1UFR3ULFTAk8YB2pQScXy/qFiisbdxOXrUizuj1p0 A/gzy0VGYrWwqtPwikVmZJ9y2xnr+kdxWX6d1wGAXC63kSeU1KeEe8f6ixiunA4Gdyvh12/8d UQNN5zEs5+2I0wNtjdF34BmTZ/2cULedlI5BwBTKeJS7bQyj+W+e/x2BYhvTd+ZwZT8SIeaBa DE8aNlk/YoAF5QHy86Z9h+HthVEYOfqQg4xqnspBZo4VIdcbSvCU05aaQ+evlcK2o599bxWqg 3Gcf9IHa2hHnz/+4ARje/3o9VjYc61Nx3ksF3Cgtjh0TUMYu97PnLk/J3g1/co3gklAuEuRLw VpPel4e+bOR1R8N5xA1GiOZ/x0jKXqQXfkKoGJ5ABqeNJEjBReM8Czxriy0Pc1XjvL8rTFPeb ZL4GoKA81UKHAvG8ggnyklNup0mgFjPpkbxdTY1R4ccTAarEL8L4Wx2K5FcNVnwojVJW1uzaV ESpTLPhPYs9Np/myTJ5+vHTaVMCGS1qgrgzNIGSeePFxFmDqXzJjcSn/ZVF7jlPJQuuB0Phgy U0EsFB1biQSR0FtFynx+iZwRmzpj/fOTbADxeHQ/8WF2RfR5JoNxW/yfvF0sTOzcs2mYY= X-Spam-Status: No, score=-25.4 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2020 17:08:48 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iGhw6Eyi34yp72U6cvYP0qoTZvMClfjGx Content-Type: multipart/mixed; boundary="RXM9j3qXp7VjnZNAXSSfyB6bjIy1k9Wp7"; protected-headers="v1" From: Kamil Rytarowski To: Simon Marchi , gdb-patches@sourceware.org Message-ID: Subject: Re: [PATCH v4] Add support for NetBSD threads in sparc-nat.c References: <20200317164603.10840-1-n54@gmx.com> <10f3399c-84ee-4cc8-b9fe-a3057fc070eb@simark.ca> In-Reply-To: <10f3399c-84ee-4cc8-b9fe-a3057fc070eb@simark.ca> --RXM9j3qXp7VjnZNAXSSfyB6bjIy1k9Wp7 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 17.03.2020 17:59, Simon Marchi wrote: > On 2020-03-17 12:51 p.m., Simon Marchi wrote: >> On 2020-03-17 12:46 p.m., Kamil Rytarowski wrote: >>> NetBSD ptrace(2) accepts thread id (LWP) as the 4th argument for thre= ads. >>> >>> This file is still shared with other targets that use different 4th a= rgument >>> type, that is always unused. >>> --- >>> gdb/sparc-nat.c | 50 ++++++++++++++++++++++-------------------------= -- >>> 1 file changed, 22 insertions(+), 28 deletions(-) >>> >>> diff --git a/gdb/sparc-nat.c b/gdb/sparc-nat.c >>> index dff0f521565..10cc01375ed 100644 >>> --- a/gdb/sparc-nat.c >>> +++ b/gdb/sparc-nat.c >>> @@ -78,6 +78,19 @@ typedef struct fp_status fpregset_t; >>> #define PTRACE_SETFPREGS PT_SETFPREGS >>> #endif >>> >>> +static int >>> +gdb_ptrace (int request, ptid_t pid, void *addr) >>> +{ >>> +#ifdef __NetBSD__ >>> + /* Support for NetBSD threads: unlike other ptrace implementations= in this >>> + file, NetBSD requires that we pass both the pid and lwp. */ >>> + return ptrace (request, ptid (). pid (), addr, ptid ().lwp ()); >> >> Does that even build? ptid isn't the name of a parameter, and the par= enthesis after >> "ptid" should not be there. Rename the pid parameter to ptid, and rep= lace the above >> with "ptid.pid ()" and "ptid.lwp ()". >> >> Simon >> >=20 > I tried to build this using a sparc-linux cross-compiler, and I think w= e need > to adjust gdb_ptrace to account for the various possible arguments type= s. The > following version of the function builds fine with sparc64-linux-gnu-gc= c, can you > try it with NetBSD? >=20 > static PTRACE_TYPE_RET > gdb_ptrace (PTRACE_TYPE_ARG1 request, ptid_t ptid, PTRACE_TYPE_ARG4 add= r) Does it work for you if you use PTRACE_TYPE_ARG3? addr is the 3rd argumen= t. PTRACE_TYPE_ARG4 is int on BSDs. > { > #ifdef __NetBSD__ > /* Support for NetBSD threads: unlike other ptrace implementations in= this > file, NetBSD requires that we pass both the pid and lwp. */ > return ptrace (request, ptid.pid (), addr, ptid.lwp ()); > #else > pid_t pid =3D get_ptrace_pid (ptid); > return ptrace (request, pid, addr, 0); > #endif > } >=20 > Alternatively, we could keep address as a "void *", and cast the value = inside gdb_ptrace: >=20 > return ptrace (request, ptid.pid (), (PTRACE_TYPE_ARG4) addr, ptid.lw= p ()); >=20 > All the callers of gdb_ptrace wouldn't have to cast that themselves, wh= ich is perhaps > a bit nicer. >=20 > Simon >=20 --RXM9j3qXp7VjnZNAXSSfyB6bjIy1k9Wp7-- --iGhw6Eyi34yp72U6cvYP0qoTZvMClfjGx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl5xA9cACgkQS7MI6bAu dmwmFRAAwdDgwRT3JBZU9B8z4bPdGu1lAjdg2IX+y6GBOYNoFAEXozPmX0vStjXd NB6QX5JM/+LlUuiNSPFZmenLAu2R/SERUQGWyy/+6U2rUSdjChoYveHRfa+eX6rA nsG89Y6Xeyx+Pkglw8U7kR9o1cOBL/CcjIQ5JpwYdcn8Vq9mFb+6g2ftKoi/NWyq J655oTrEOG96J41FAHIVw9uhc4PZyOpGKmT++a1Qo98mXw5Fitv0SLY5seRm1qK1 egOXmqQ/fI+dXNOXIgj5/DTssOLXWxfimmMvyF39r4AvYSbqMPvcX6w0a8AKcMGT LUF1SZc1FBqO22ewqMPEfBlN6uEXuldpot7SnbfnTNJQlerdGgRTKPssYVPiNjAr MQCuJMoQY+awuzngqO4fiFNoxkKl8vZkz8koh4D5DFreW2YZ8FIHdvH7YiSvtwhr d8iXRIQr/6OXRd9Hr+6/gLVbsmZKSpB5l2qZ9TXKU4ojF0mSmpoTntDR7Ou1z6Ij KcPRtLaPqBxcQMbOsoxIXlr2nTcNXrQXzR3w79edGmzFWAmLDbZZ4Wm/sc4/t+13 dfZUK1ZRtPRNU82wQ+TgGM2so0mTl0lXg6ylVhS6wcg7bH2Bb01m7xMNx/rkK5jF r9VQhqPA4YBQCk68UDrWsx22jxbyRS49jHU3wauVHgTDDpN45zg= =lvf7 -----END PGP SIGNATURE----- --iGhw6Eyi34yp72U6cvYP0qoTZvMClfjGx--