From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119322 invoked by alias); 3 Oct 2019 20:33:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119306 invoked by uid 89); 3 Oct 2019 20:33:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,KAM_STOCKGEN,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: userp2120.oracle.com Received: from userp2120.oracle.com (HELO userp2120.oracle.com) (156.151.31.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Oct 2019 20:33:32 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x93KTSKf015243; Thu, 3 Oct 2019 20:33:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : references : message-id : date : mime-version : in-reply-to : content-type; s=corp-2019-08-05; bh=VIi44ivL/USBNNb4OMvFli0fhBvoaRpuR9eglDAGTgg=; b=SI+hMjerRfv11KH62sU94tGmF56uOrXpiB6rHTYcxYo+wT/gvMJCcE85ehzuD/PyxTVx L65aYIO04AIBIm57bAq0TAoCSe14Vobr2RcYlWJqDb2amkU4EDYZP4aM79wZn1phMmpS JNB4baIU2mwC+YY+Tp7Yv1+4BcvY+tuqJgxeUl7jj5xogW9DJLhhSLxljz094bQadJl5 ic2r3LjS62QxB1Kp4+/sQy4jmt59WQZuCAhCxi2vICheYEVgwe11E8zC/YpXBM75xy+P XSOh0XuPvqiHm3J4OI1rkzZkR8eRgjAnSmWCRpDRL45KRpnXigZzmYLAd66gn4e0xZhf sg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2va05s6wuv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Oct 2019 20:33:29 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x93KXBWn092309; Thu, 3 Oct 2019 20:33:29 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2vcx733xde-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Oct 2019 20:33:12 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x93KWxaB022925; Thu, 3 Oct 2019 20:32:59 GMT Received: from [10.159.232.91] (/10.159.232.91) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 03 Oct 2019 13:32:59 -0700 Subject: Re: [PATCH v2] gdb: CTF support From: Wei-min Pan To: Simon Marchi , gdb-patches@sourceware.org References: <1564530195-27659-1-git-send-email-weimin.pan@oracle.com> <5377c457-52b0-583d-15b5-47024eae1f48@simark.ca> <895f47d4-3e01-4d5a-474b-43dd2dd037b4@oracle.com> <0fe82814-46b8-79c2-6a25-5f5d51b158e1@simark.ca> <1055d18f-9e5c-3344-114a-3777876c9c63@oracle.com> <3a67839f-73d0-06ed-4140-073306fc618d@simark.ca> <75851ff5-771d-16fb-0a74-661c9e0722d3@simark.ca> <93caabd4-f25d-61e3-a11d-52bcd8fbe3b6@simark.ca> <9f1e47a9-f558-5d7e-1086-7708ac394d7f@oracle.com> Message-ID: Date: Thu, 03 Oct 2019 20:33:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <9f1e47a9-f558-5d7e-1086-7708ac394d7f@oracle.com> Content-Type: multipart/mixed; boundary="------------F73B7F387880DA0B017F3440" X-SW-Source: 2019-10/txt/msg00130.txt.bz2 This is a multi-part message in MIME format. --------------F73B7F387880DA0B017F3440 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-length: 1837 On 10/3/2019 11:53 AM, Wei-min Pan wrote: > > On 10/3/2019 11:31 AM, Simon Marchi wrote: >> On 2019-10-03 2:21 p.m., Wei-min Pan wrote: >>> Let's use an example (checking omitted): >>> >>> We're replacing: >>>    name = ctf_type_aname_raw (fp, tid); >>>    TYPE_NAME (type) = obstack_strdup (&of->objfile_obstack, name); >>>    free (name); >>> >>> with >>>    gdb::unique_xmalloc_ptr name (ctf_type_aname_raw (fp, tid)); >>>    TYPE_NAME (type) = obstack_strdup (&of->objfile_obstack, name.get ()); >>> >>> >>> The allocated copy from ctf_type_aname_raw is not freed. Or did I >>> miss something? >>> >>> Weimin >> Yes, the second snippet frees the copy returned by ctf_type_aname_raw. >> >> It might just be that you are not familiar with the concept of >> std::unique_ptr in C++: >> >>    https://en.cppreference.com/w/cpp/memory/unique_ptr >> >> It's a wrapper around a simple pointer that automatically calls a >> deleter function >> when it goes out of scope.  gdb::unique_xmalloc_ptr is a >> specialization of std::unique_ptr >> that uses xfree as the deleter function. >> >> Here's a similar use: >> >> https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=blob;f=gdb/fbsd-tdep.c;h=9422e3c1a7e1a65c76b088f42bb5986bd13a089f;hb=HEAD#l1530 >> >> `fbsd_core_vnode_path` return a pointer to an allocated C String, >> which `cwd` wraps.  When >> it goes out of scope, `cwd` automatically calls `xfree` with the >> pointer. > > Oh, thanks for the explanation, reference and example. Will switch to > using gdb::unique_xmalloc_ptr<> instead. Hi Simon, I've switched to using gdb::unique_xmalloc_ptr, please see the attached patch, and ran the CTF test suite successfully. Will submit a revised patch upstream shortly. Thanks again for your reviews and help. Weimin --------------F73B7F387880DA0B017F3440 Content-Type: text/plain; charset=UTF-8; name="0001-updated2.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-updated2.patch" Content-length: 5137 NDA1YzQxMAo8ICAgZ2RiOjp1bmlxdWVfeG1hbGxvY19wdHI8Y2hhcj4gbmFt ZSAoY3RmX3R5cGVfYW5hbWVfcmF3IChmcCwgdGlkKSk7Ci0tLQo+ICAgY2hh ciAqbmFtZSA9IGN0Zl90eXBlX2FuYW1lX3JhdyAoZnAsIHRpZCk7CjQxMmM0 MTcKPCAgICAgICBTWU1CT0xfU0VUX05BTUVTIChzeW0sIG5hbWUuZ2V0ICgp LCBzdHJsZW4gKG5hbWUuZ2V0ICgpKSwgMSwgb2JqZmlsZSk7Ci0tLQo+ICAg ICAgIFNZTUJPTF9TRVRfTkFNRVMgKHN5bSwgbmFtZSwgc3RybGVuIChuYW1l KSwgMSwgb2JqZmlsZSk7CjQxNGE0MjAKPiAgICAgICBmcmVlIChuYW1lKTsK NDc4LDQ3OWM0ODQsNDg1CjwgICBnZGI6OnVuaXF1ZV94bWFsbG9jX3B0cjxj aGFyPiBjb3BpZWRfbmFtZSAoY3RmX3R5cGVfYW5hbWVfcmF3IChmcCwgdGlk KSk7CjwgICBpZiAoY29waWVkX25hbWUgPT0gTlVMTCB8fCBzdHJsZW4gKGNv cGllZF9uYW1lLmdldCAoKSkgPT0gMCkKLS0tCj4gICBuYW1lID0gY3RmX3R5 cGVfYW5hbWVfcmF3IChmcCwgdGlkKTsKPiAgIGlmIChuYW1lID09IE5VTEwg fHwgc3RybGVuIChuYW1lKSA9PSAwKQo0ODdjNDkzLDQ5Nwo8ICAgICBuYW1l ID0gb2JzdGFja19zdHJkdXAgKCZvZi0+b2JqZmlsZV9vYnN0YWNrLCBjb3Bp ZWRfbmFtZS5nZXQgKCkpOwotLS0KPiAgICAgewo+ICAgICAgIGNoYXIgKmR1 cF9uYW1lID0gbmFtZTsKPiAgICAgICBuYW1lID0gb2JzdGFja19zdHJkdXAg KCZvZi0+b2JqZmlsZV9vYnN0YWNrLCBuYW1lKTsKPiAgICAgICBmcmVlIChk dXBfbmFtZSk7Cj4gICAgIH0KNTYxYTU3Mgo+ICAgY2hhciAqbmFtZTsKNTY2 LDU2OGM1NzcsNTgyCjwgICBnZGI6OnVuaXF1ZV94bWFsbG9jX3B0cjxjaGFy PiBuYW1lIChjdGZfdHlwZV9hbmFtZV9yYXcgKGZwLCB0aWQpKTsKPCAgIGlm IChuYW1lICE9IE5VTEwgJiYgc3RybGVuIChuYW1lLmdldCgpICkgIT0gMCkK PCAgICAgVFlQRV9OQU1FICh0eXBlKSA9IG9ic3RhY2tfc3RyZHVwICgmb2Yt Pm9iamZpbGVfb2JzdGFjaywgbmFtZS5nZXQgKCkpOwotLS0KPiAgIG5hbWUg PSBjdGZfdHlwZV9hbmFtZV9yYXcgKGZwLCB0aWQpOwo+ICAgaWYgKG5hbWUg IT0gTlVMTCAmJiBzdHJsZW4gKG5hbWUpICE9IDApCj4gICAgIHsKPiAgICAg ICBUWVBFX05BTUUgKHR5cGUpID0gb2JzdGFja19zdHJkdXAgKCZvZi0+b2Jq ZmlsZV9vYnN0YWNrLCBuYW1lKTsKPiAgICAgICBmcmVlIChuYW1lKTsKPiAg ICAgfQo2MTdjNjMxCjwgICBzdHJ1Y3Qgb2JqZmlsZSAqb2YgPSBjY3AtPm9m OwotLS0KPiAgIHN0cnVjdCBvYmpmaWxlICpvYmpmaWxlID0gY2NwLT5vZjsK NjIwYTYzNQo+ICAgY2hhciAqbmFtZTsKNjIyYzYzNwo8ICAgdHlwZSA9IGFs bG9jX3R5cGUgKG9mKTsKLS0tCj4gICB0eXBlID0gYWxsb2NfdHlwZSAob2Jq ZmlsZSk7CjYyNCw2MjZjNjM5LDY0NAo8ICAgZ2RiOjp1bmlxdWVfeG1hbGxv Y19wdHI8Y2hhcj4gbmFtZSAoY3RmX3R5cGVfYW5hbWVfcmF3IChmcCwgdGlk KSk7CjwgICBpZiAobmFtZSAhPSBOVUxMICYmIHN0cmxlbiAobmFtZS5nZXQg KCkpICE9IDApCjwgICAgIFRZUEVfTkFNRSAodHlwZSkgPSBvYnN0YWNrX3N0 cmR1cCAoJm9mLT5vYmpmaWxlX29ic3RhY2ssIG5hbWUuZ2V0ICgpKTsKLS0t Cj4gICBuYW1lID0gY3RmX3R5cGVfYW5hbWVfcmF3IChmcCwgdGlkKTsKPiAg IGlmIChuYW1lICE9IE5VTEwgJiYgc3RybGVuIChuYW1lKSAhPSAwKQo+ICAg ICB7Cj4gICAgICAgVFlQRV9OQU1FICh0eXBlKSA9IG9ic3RhY2tfc3RyZHVw ICgmb2JqZmlsZS0+b2JqZmlsZV9vYnN0YWNrLCBuYW1lKTsKPiAgICAgICBm cmVlIChuYW1lKTsKPiAgICAgfQo2MzBjNjQ4CjwgICByZXR0eXBlID0gZ2V0 X3RpZF90eXBlIChvZiwgY2ZpLmN0Y19yZXR1cm4pOwotLS0KPiAgIHJldHR5 cGUgPSBnZXRfdGlkX3R5cGUgKG9iamZpbGUsIGNmaS5jdGNfcmV0dXJuKTsK NjM0YzY1Mgo8ICAgcmV0dXJuIHNldF90aWRfdHlwZSAob2YsIHRpZCwgdHlw ZSk7Ci0tLQo+ICAgcmV0dXJuIHNldF90aWRfdHlwZSAob2JqZmlsZSwgdGlk LCB0eXBlKTsKNjQ2YTY2NQo+ICAgY2hhciAqbmFtZTsKNjUwLDY1MmM2Njks Njc0CjwgICBnZGI6OnVuaXF1ZV94bWFsbG9jX3B0cjxjaGFyPiBuYW1lIChj dGZfdHlwZV9hbmFtZV9yYXcgKGZwLCB0aWQpKTsKPCAgIGlmIChuYW1lICE9 IE5VTEwgJiYgc3RybGVuIChuYW1lLmdldCAoKSkgIT0gMCkKPCAgICAgVFlQ RV9OQU1FICh0eXBlKSA9IG9ic3RhY2tfc3RyZHVwICgmb2YtPm9iamZpbGVf b2JzdGFjaywgbmFtZS5nZXQgKCkpOwotLS0KPiAgIG5hbWUgPSBjdGZfdHlw ZV9hbmFtZV9yYXcgKGZwLCB0aWQpOwo+ICAgaWYgKG5hbWUgIT0gTlVMTCAm JiBzdHJsZW4gKG5hbWUpICE9IDApCj4gICAgIHsKPiAgICAgICBUWVBFX05B TUUgKHR5cGUpID0gb2JzdGFja19zdHJkdXAgKCZvZi0+b2JqZmlsZV9vYnN0 YWNrLCBuYW1lKTsKPiAgICAgICBmcmVlIChuYW1lKTsKPiAgICAgfQo4ODBh OTAzCj4gICBjaGFyICpuYW1lOwo5MDMsOTA3YzkyNiw5MjkKPCAJeyAKPCAJ ICBnZGI6OnVuaXF1ZV94bWFsbG9jX3B0cjxjaGFyPiBuYW1lIChjdGZfdHlw ZV9hbmFtZV9yYXcgKGZwLCB0aWQpKTsKPCAJICBidGlkID0gY3RmX3R5cGVf cmVmZXJlbmNlIChmcCwgdGlkKTsKPCAJICB0eXBlID0gcmVhZF90eXBlZGVm X3R5cGUgKGNjcCwgdGlkLCBidGlkLCBuYW1lLmdldCAoKSk7CjwgCX0gCi0t LQo+IAluYW1lID0gY3RmX3R5cGVfYW5hbWVfcmF3IChmcCwgdGlkKTsKPiAJ YnRpZCA9IGN0Zl90eXBlX3JlZmVyZW5jZSAoZnAsIHRpZCk7Cj4gCXR5cGUg PSByZWFkX3R5cGVkZWZfdHlwZSAoY2NwLCB0aWQsIGJ0aWQsIG5hbWUpOwo+ IAlmcmVlIChuYW1lKTsKMTA4OGExMTExCj4gICBjaGFyICpuYW1lOwoxMTAz YzExMjYKPCAgIGdkYjo6dW5pcXVlX3htYWxsb2NfcHRyPGNoYXI+IG5hbWUg KGN0Zl90eXBlX2FuYW1lX3JhdyAoY2NwLT5mcCwgaWR4KSk7Ci0tLQo+ICAg bmFtZSA9IGN0Zl90eXBlX2FuYW1lX3JhdyAoY2NwLT5mcCwgaWR4KTsKMTEw NWExMTI5Cj4gICBmcmVlIChuYW1lKTsKMTMyMWExMzQ2Cj4gICBjaGFyICpu YW1lOwoxMzI2LDEzMjdjMTM1MSwxMzUyCjwgICBnZGI6OnVuaXF1ZV94bWFs bG9jX3B0cjxjaGFyPiBuYW1lIChjdGZfdHlwZV9hbmFtZV9yYXcgKGNjcC0+ ZnAsIHRpZCkpOwo8ICAgaWYgKG5hbWUgPT0gTlVMTCB8fCBzdHJsZW4gKG5h bWUuZ2V0ICgpKSA9PSAwKQotLS0KPiAgIG5hbWUgPSBjdGZfdHlwZV9hbmFt ZV9yYXcgKGNjcC0+ZnAsIHRpZCk7Cj4gICBpZiAobmFtZSA9PSBOVUxMIHx8 IHN0cmxlbiAobmFtZSkgPT0gMCkKMTM2OGMxMzkzCjwgICAgIGFkZF9wc3lt Ym9sX3RvX2xpc3QgKG5hbWUuZ2V0ICgpLCBzdHJsZW4gKG5hbWUuZ2V0ICgp KSwgdHJ1ZSwKLS0tCj4gICAgIGFkZF9wc3ltYm9sX3RvX2xpc3QgKG5hbWUs IHN0cmxlbiAobmFtZSksIHRydWUsCjEzNzJhMTM5OAo+ICAgZnJlZSAobmFt ZSk7CjE0MjVjMTQ1MQo8ICAgICAgIGdkYjo6dW5pcXVlX3htYWxsb2NfcHRy PGNoYXI+IHRuYW1lIChjdGZfdHlwZV9hbmFtZV9yYXcgKGNmcCwgdGlkKSk7 Ci0tLQo+ICAgICAgIGNoYXIgKnRuYW1lID0gY3RmX3R5cGVfYW5hbWVfcmF3 IChjZnAsIHRpZCk7CjE0NDhjMTQ3NAo8ICAgICAgIGFkZF9wc3ltYm9sX3Rv X2xpc3QgKHRuYW1lLmdldCAoKSwgc3RybGVuICh0bmFtZS5nZXQgKCkpLCB0 cnVlLAotLS0KPiAgICAgICBhZGRfcHN5bWJvbF90b19saXN0ICh0bmFtZSwg c3RybGVuICh0bmFtZSksIHRydWUsCjE0NTFhMTQ3OAo+ICAgICAgIGZyZWUg KHRuYW1lKTsK --------------F73B7F387880DA0B017F3440--