Re: [PATCH] gdb, testsuite, btrace: relax unneeded stepi expected output

Luis Machado via Gdb-patches
2021-04-01T16:54:19Z

On 3/16/21 6:26 AM, Markus Metzger via Gdb-patches wrote:
> In gdb.btrace/reconnect.exp, we test that we can disconnect and reconnect
> again to a GDB session that is recording with the btrace recording format.
> It does not really matter what we are recording.
>
> The test assumed that stepping from _start will bring us into an area
> without debug information. This is not correct on all systems.
>
> Relax the expected output to also support systems where we do have debug
> information for that code.
>
> gdb/testsuite/ChangeLog:
> 2021-03-08 Markus Metzger <markus.t.metzger@intel.com>
>
> * gdb.btrace/reconnect.exp: Relax expected stepi output.
> ---
> gdb/testsuite/gdb.btrace/reconnect.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/gdb.btrace/reconnect.exp b/gdb/testsuite/gdb.btrace/reconnect.exp
> index 2e61d3591f3..26578706eaf 100644
> --- a/gdb/testsuite/gdb.btrace/reconnect.exp
> +++ b/gdb/testsuite/gdb.btrace/reconnect.exp
> @@ -51,7 +51,7 @@ gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
> # Create a record, check, reconnect
> with_test_prefix "first" {
> gdb_test_no_output "record btrace" "record btrace enable"
> - gdb_test "stepi 19" "($hex in .* from .*|$hex\t$decimal.*)"
> + gdb_test "stepi 19" ".*"
>
> gdb_test "info record" [multi_line \
> "Active record target: .*" \
>

Investigating some racy tests under make check-read1, isn't there a
better matching pattern that we can use here to prevent future
non-determinism?