Re: [PATCH] gdb, testsuite, btrace: relax unneeded stepi expected output

Luis Machado via Gdb-patches
2021-04-12T11:05:33Z

Hi,

On 4/12/21 5:22 AM, Metzger, Markus T wrote:
> Hello Luis,
>
>>> @@ -51,7 +51,7 @@ gdb_target_cmd $gdbserver_protocol $gdbserver_gdbport
>>> # Create a record, check, reconnect
>>> with_test_prefix "first" {
>>> gdb_test_no_output "record btrace" "record btrace enable"
>>> - gdb_test "stepi 19" "($hex in .* from .*|$hex\t$decimal.*)"
>>> + gdb_test "stepi 19" ".*"
>>>
>>> gdb_test "info record" [multi_line \
>>> "Active record target: .*" \
>>>
>>
>> Investigating some racy tests under make check-read1, isn't there a
>> better matching pattern that we can use here to prevent future
>> non-determinism?
>
> The test now ignores all output since it doesn't really matter where we end up
> after stepping. This should be the most future-proof pattern. Were you looking
> for a less lax pattern?

Yeah, I was looking for a more meaningful kind of test other than
expecting anything.

In any case, I was worried about possible races in the test...

>
> I ran gdb.btrace with check-read1 on IA and didn't find any issues.

... and since you verified it with read1, I guess it should be fine.

Thanks,
Luis