From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41565 invoked by alias); 18 Jul 2018 02:29:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41545 invoked by uid 89); 18 Jul 2018 02:29:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=letter X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Jul 2018 02:29:38 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w6I2TV4x029154 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Jul 2018 22:29:36 -0400 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0924B1E059; Tue, 17 Jul 2018 22:29:30 -0400 (EDT) Subject: Re: [RFA 02/15] Remove some unneeded psymtab initializations From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20180510222357.27332-1-tom@tromey.com> <20180510222357.27332-3-tom@tromey.com> <9582d8730cf1f62af176a5dea8e41e51@polymtl.ca> Message-ID: Date: Wed, 18 Jul 2018 02:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <9582d8730cf1f62af176a5dea8e41e51@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00536.txt.bz2 On 2018-07-17 11:27 AM, Simon Marchi wrote: > Hi Tom, > > This LGTM, I just have one comment. I think it can be pushed on its own > too. > > On 2018-05-10 18:23, Tom Tromey wrote: >> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c >> index 8960fdc38d..be477e3d30 100644 >> --- a/gdb/dwarf2read.c >> +++ b/gdb/dwarf2read.c >> @@ -6517,13 +6517,7 @@ dwarf2_create_include_psymtab (const char >> *name, struct partial_symtab *pst, >> subpst->dependencies[0] = pst; >> subpst->number_of_dependencies = 1; >> >> - subpst->globals_offset = 0; >> - subpst->n_global_syms = 0; >> - subpst->statics_offset = 0; >> - subpst->n_static_syms = 0; >> - subpst->compunit_symtab = NULL; >> subpst->read_symtab = pst->read_symtab; >> - subpst->readin = 0; > > Just above this, there is: > > subpst->textlow = 0; > subpst->texthigh = 0; > > Can they be removed too? Same thing in xcoffread. > > Simon > Ahh, when the series is applied on top of the other psymtab series (as you mention in the cover letter), these bits are already gone. Sorry about that. Simon