From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id A94BD38930F8 for ; Sat, 20 Jun 2020 17:54:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org A94BD38930F8 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-9TZbhzSbPvaxg0k0CTF4CA-1; Sat, 20 Jun 2020 13:54:29 -0400 X-MC-Unique: 9TZbhzSbPvaxg0k0CTF4CA-1 Received: by mail-wr1-f71.google.com with SMTP id m14so6698683wrj.12 for ; Sat, 20 Jun 2020 10:54:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=oYfpVhz15TNAnRcyP4EMgGrU281OJflzr018niSXXng=; b=MC3qhggU9NvXCzc+U+qwis2rCqHyNyybIAqldeZ2Qdw2198i/tXAJ/k74eJxGDG37F W20IzUwuldwn+Ing09wLUickhFrC4Fw1narTT2tG/7Th73pFDAntlsXVeDEIgmKfFC+v Q1eqegSFOuvhEfA9GB4x97VJwub/X6pyadrzMir5Yga1GS2HAy7oxuLO0wa8M9u/+HEq b5ENvsy1RIIf2FI3kJiGxf5IiIeZYel3EAgdVfq8QFPkmTE4g7UhNNEkyCO/SwEaNbKM A0AI7BA3EbL32m1p7EfLBq+15xhP2JJFZj3uu2eTOi30OxIealUezweGSjpS91xjdh5+ ZbLg== X-Gm-Message-State: AOAM532Ba942EDB+27PUSKO2pyPSEt8VXQbVBUBSrJfYn/nwAvSp+BR/ L384wobtqcVKsq1MBuYbEwItsZsM1M61YL3WJv/NBvTrCEGv78PhMjk+s0s3Ko0nA38oDkxEp5q wBWGlexpje/xjdCF4lsmJ5g== X-Received: by 2002:a1c:3b8b:: with SMTP id i133mr9503778wma.111.1592675668201; Sat, 20 Jun 2020 10:54:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8bcNPyDVqB1+r0yT+oTXmqD9zH8kdyjUx08dXVrU93SqrjwpqpAcrZ5rexILET7HCiPooMQ== X-Received: by 2002:a1c:3b8b:: with SMTP id i133mr9503769wma.111.1592675668017; Sat, 20 Jun 2020 10:54:28 -0700 (PDT) Received: from ?IPv6:2001:8a0:f922:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f922:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id a12sm1141026wrv.41.2020.06.20.10.54.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 20 Jun 2020 10:54:27 -0700 (PDT) Subject: Re: [patch] testsuite: Disable parts of gdb.base/source-dir.exp on remote host. To: Sandra Loosemore , "gdb-patches@sourceware.org" References: <6ac784c5-25e4-c2b5-06e1-9fd527533e4d@codesourcery.com> From: Pedro Alves Message-ID: Date: Sat, 20 Jun 2020 18:54:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <6ac784c5-25e4-c2b5-06e1-9fd527533e4d@codesourcery.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jun 2020 17:54:32 -0000 On 6/20/20 6:44 PM, Sandra Loosemore wrote: > One set of tests in gdb.base/source-dir.exp does a lot of complicated directory manipulations to force a specific DW_AT_comp_dir format and gdb directory search path.  As it's written, everything assumes host == build, and it does not seem to me that there is any obvious way to rewrite this so it will work in general on remote host.  For instance, our harness for testing on remote Windows host normally does all compilation and GDB execution in $cwd using relative pathnames and I'm not sure all these directory tricks would set up the scenario it's trying to test even if they were correctly performed on host rather than build.  So I think it's reasonable just to disable this on remote host instead. > > I also noted that it's using the wrong search path syntax for Windows host in the "set directories" command and conditionalized that while I was looking at it.  That's a necessary fix to make this work in a situation where host == build and it's Windows, but I'm not actually set up to test that it's sufficient, too. > > OK to check this in? This is OK, but please make sure that the info above ends up in the commit log as well (wrapped at 72-character columns per standard git convention). (Nit -- convention is to not end the subject line with a period.) Thanks, Pedro Alves