From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cXdMNC1hL2mCDBIAWB0awg (envelope-from ) for ; Tue, 02 Dec 2025 16:59:09 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=LssdvcEX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id C52371E0B3; Tue, 02 Dec 2025 16:59:09 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C6CCC1E048 for ; Tue, 02 Dec 2025 16:59:08 -0500 (EST) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2EDE54BBC097 for ; Tue, 2 Dec 2025 21:59:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2EDE54BBC097 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=labware.com header.i=@labware.com header.a=rsa-sha256 header.s=mimecast20220511 header.b=LssdvcEX Received: from us-smtp-delivery-114.mimecast.com (us-smtp-delivery-114.mimecast.com [170.10.129.114]) by sourceware.org (Postfix) with ESMTP id 26AA14BBC08E for ; Tue, 2 Dec 2025 21:58:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 26AA14BBC08E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=labware.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=labware.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 26AA14BBC08E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.114 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764712722; cv=none; b=CYvV+K6ZWlz1k4QVwV3U/OX1SXoU09Nt7xUeUFqegqMrM0IcCziLMFjZYhmOsXj81R1VB7ko6NTroJBab/wHa6LY+Tke0epHL5TdXLABAwZ04udMztU24Ph498f/YreHh77oC6o0y0M6rlVA55uxdLa+kfwmB98XnAPJFYvGYb0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1764712722; c=relaxed/simple; bh=JyhxLNgUnKfbCWRvJh1HXvfH4yYDaA7MAuLQEAZmxko=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=R6jLGQz/EIjCsUO1rj+P/G4RM8SqtOHSJhhJGDRQ6QxoS4A8jEDarDwK7nn7n0GSillHiEFu/bd3p4Qir2xL2GEz9RhwdYzB/RTIptGgpY3hG19fdkgcOUG0E5puLaVpjw5mZKcuDgoXz8p6mBLMdUKPliHaXa0D8l8MxK2bsWk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26AA14BBC08E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=labware.com; s=mimecast20220511; t=1764712721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JyhxLNgUnKfbCWRvJh1HXvfH4yYDaA7MAuLQEAZmxko=; b=LssdvcEXrFoiz10W+Xr/eSxUaqaQ211vmleYVWT9RFoSAsRi0FV7wNI8yjavwvFNfJZ8lr e1ihaqVk/5b80GS0/L4H3Cb5rsgFplVQQdo/lWzIFGG7dO//tLPnIWGKhxQea5Pgz0ShqB qQWpHA/vnfcxTrW3dzeZc/EULbjueMk= Received: from BN1PR04CU002.outbound.protection.outlook.com (mail-eastus2azon11020089.outbound.protection.outlook.com [52.101.56.89]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-653-maah5nDvOtyL9ALNHRFYkw-1; Tue, 02 Dec 2025 16:58:40 -0500 X-MC-Unique: maah5nDvOtyL9ALNHRFYkw-1 X-Mimecast-MFC-AGG-ID: maah5nDvOtyL9ALNHRFYkw_1764712720 Received: from SA1PR17MB5365.namprd17.prod.outlook.com (2603:10b6:806:1d8::11) by LV8PR17MB7111.namprd17.prod.outlook.com (2603:10b6:408:189::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9388.9; Tue, 2 Dec 2025 21:58:38 +0000 Received: from SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e]) by SA1PR17MB5365.namprd17.prod.outlook.com ([fe80::9a:538a:fa42:730e%3]) with mapi id 15.20.9388.003; Tue, 2 Dec 2025 21:58:38 +0000 From: =?iso-8859-15?Q?Jan_Vran=FD?= To: "tom@tromey.com" CC: "gdb-patches@sourceware.org" , "simon.marchi@efficios.com" Subject: Re: [pushed] gdb: change blockvector::contains() to handle blockvectors with "holes" Thread-Topic: [pushed] gdb: change blockvector::contains() to handle blockvectors with "holes" Thread-Index: AQHcYG3oDHBb5lrX2EOK4Bd8g45ZOrUOpQdSgABHvIA= Date: Tue, 2 Dec 2025 21:58:38 +0000 Message-ID: References: <20251128134950.1763596-1-jan.vrany@labware.com> <20251128134950.1763596-2-jan.vrany@labware.com> <87ecpc93xk.fsf@tromey.com> In-Reply-To: <87ecpc93xk.fsf@tromey.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SA1PR17MB5365:EE_|LV8PR17MB7111:EE_ x-ms-office365-filtering-correlation-id: c71c688a-4aab-440d-9f2d-08de31edf2ca x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|38070700021 x-microsoft-antispam-message-info: =?iso-8859-15?Q?pu0Gu++RdGY/3RtWG9Ush4JO1bFY3NXoPn249Goa5e1fq/1mTIh5Ykifl?= =?iso-8859-15?Q?IAt0Rqpg86dUYpjCS3KQC+vx+eHyFuviRdhgX+1hM/vHuyQYHloI16sM8?= =?iso-8859-15?Q?8i52k5kimvGwobUYFGgXXGg99qKG2fKMfeDP6zPDSK+f+nGElfz7sc/o1?= =?iso-8859-15?Q?zisSASr1JBsHdKNzXWpFE0a3CvBS9LGtdPlJARFMnAZVjCB+g6ey1c4lj?= =?iso-8859-15?Q?SihW7srmb53EZ6JHH3/5klaSzUrV1du3opetCYzDETRLeTXA7P5JMwZmM?= =?iso-8859-15?Q?EW71CdxVFR6RMYyzkZpGAQTSX1fYdt2WyOTQxZnsDXPi86RVxOccWOVK6?= =?iso-8859-15?Q?HfE6k4wxFjJbB9a0r0uA3BEqXUQbd8lY+lyB5jbnKitxpNNqIZ3G9j+Nl?= =?iso-8859-15?Q?ZLVEijE0PHUhu8hCbOJzbNp9ZFDxDjPtigMcM5fSHq1FuRYQou7liOnPO?= =?iso-8859-15?Q?TGp5Dgd6o4VW8+Ko5v39XwCMB9/DFXGCTgdEewroP/jhs/s+aH0WdYWx5?= =?iso-8859-15?Q?J9uGXR4UljApUNk2TvvxA2yOx9QTTYIr/+TfOGOBFrcY6C88l6mCfMsnM?= =?iso-8859-15?Q?1ZwREpeXJHasPMwOlGD+BuWATO2kCaS3aBoJd5SeJgAgAPdgDdRtvTNhc?= =?iso-8859-15?Q?3Dt2tnVdMPQ+WlWQLbSe2KvuivU+31upmpmRW4BStPfP7UWYO0l6SxkFa?= =?iso-8859-15?Q?K75yflD+4gwP9ECRz5WoFFJlUJwEK3Rzvesc8F+fSi7twSw9EUvvRWrpB?= =?iso-8859-15?Q?P+P56Tko+k6o2LZn0hrdydJlcKJyPIto/LckMCXL6M7YCFT0hstd6dEC/?= =?iso-8859-15?Q?QQUj1UgwELs5dDPJCwllkr6p489iEGpyMawc4+Z+buvoGTgMtCf/CzFWH?= =?iso-8859-15?Q?eGaLI4xLcuJirGuk9oTpAVMq3ZGEiNToT5HpAFYuwpdzt1JPc75LhzLqc?= =?iso-8859-15?Q?Au5aQjO7zo2wHhWmn2tk9LanQKGzMsp440eTa8YZR3pHWSDUNAt0nnE28?= =?iso-8859-15?Q?piJLsL0z1PiiigCCSGfrvQ6EU5AJ+hD+oNPNsYV+pfaeFUYrffNhOQ8Ts?= =?iso-8859-15?Q?xxJflf/3FF4iHHW29x2yzQrmIqQkxU7zZTwoWlDBmajCEyCoC9HLPIsLy?= =?iso-8859-15?Q?7/i8zfbeFCtld6DAP7qylbOqF3UthFiY9lWU/lwv2FhP6hzQfnIGVpnsH?= =?iso-8859-15?Q?MKSdXXrnFHVM1nE0iVjxUoD1qox47+AyQj5snF64PUF75pgc1qEMmHb4i?= =?iso-8859-15?Q?L4Y1Hu7JiwyJooPo7qxvaSFPUdzyUncEgm+uDaOYVUbzfD8mwzPkZSG9m?= =?iso-8859-15?Q?4DuCF10Z5jYwrvpKvLnUFzH6+M3Qyrr9YH5KnPEnDH9qqNlpzvTiR2Ix7?= =?iso-8859-15?Q?2i88+yhAJosE8wV+RHLU2kOQFNagkxPflyJw0lk2v3e9yPttwhRU+CBdo?= =?iso-8859-15?Q?9w2uDD3RUPY+ugmGlQrBgo1VbCtBqwKL/u/WrNPUFSeHMxEEzsato5zHL?= =?iso-8859-15?Q?7oFJp2tCLtAelz4ZanKyE+SxFdUc5TKio5j6PEk7GN8dpNf8ATJA9N4kv?= =?iso-8859-15?Q?5xftKgTHZZ+bEqh+5j5OgMX/MTnvanCsgMhqZ7YqjEyOAjRMB/XiFP?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SA1PR17MB5365.namprd17.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(366016)(1800799024)(38070700021); DIR:OUT; SFP:1102 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-15?Q?Xx3LlUZrW09JHdCREBrVSJhLKuXMsRy2rntL2yitrse//8ajZHr0RdF1p?= =?iso-8859-15?Q?jTGIzr8EhkaRtPP6Cc0L8NehWhB5wXc5g8bmsR1LBOrGF63kYVxYugSdB?= =?iso-8859-15?Q?7WR4aQCayVGTnplYVERO90UeqrGGTHzaBAq+b/LugZTcgCBeAuWnJeV0K?= =?iso-8859-15?Q?ukV9hIWrphX7X8idoIAW8baYsKaxVj+ld+m3fMap+R5qJ6ra0AFZXUc+Q?= =?iso-8859-15?Q?ydQy37A0PChqFODhQUY71UT2q98MW12xbFoGdUrQ7KbyfNQHkfGbXYmKK?= =?iso-8859-15?Q?BjGTdohef9hcfIdCR1yQlYuKamsJf3sZoapzLqwRooqiWY6g090vUVy0+?= =?iso-8859-15?Q?NKhnjhYwwLgCXpePJVcjs513iR0YCwMrwutVgbiyq3SB1mWN0p8OE3piX?= =?iso-8859-15?Q?85/GfqQhyIuynBO1F5fmaLlmbP2ql+blOFpXooi4tFhmqyAr/E5451TIQ?= =?iso-8859-15?Q?zYdZzxRg7RbpudZDR33bbLLFVrns4MMceMkEH6ASYnt/OrgstFuJopjRL?= =?iso-8859-15?Q?NOd1/vCSY+LNswL4nUP7y7ismG1gbaxVQfzD8YpkeU6KSPoTl3tl2P3U9?= =?iso-8859-15?Q?84XsSGyaKeCSyEAzVeCfWVM2O2nyjWWoLStAGO545BPYzCbcuuok8bZ6y?= =?iso-8859-15?Q?VdqXP0/JntweafU7uQS44bkiV2/1u9+5FXLjbee203y89zckA4RqLozoP?= =?iso-8859-15?Q?uQwWwdqbDPTBLYzRIQMjhXxuVSMy888u7yCYiSVJuNdnGEoY0btPElanL?= =?iso-8859-15?Q?Bj+PK2FdgBApkNRlRFtjKdYUYZ9J/mjLo0jfP1BqlpNTJGzv1d/oGMLcH?= =?iso-8859-15?Q?XroBy3TpvwZiOZ3KRGq2JUloD1kpSG9LLV2ljW37lxdaVvD/Ma5gYSw93?= =?iso-8859-15?Q?AKCMuBM+Ad0ckr9eM1EwsHGZNTIWNBZPs+9QFf5TG7jrrqxIeJdtOWABu?= =?iso-8859-15?Q?oQPf4yVAbGssxspN+oWhshsYXrFj0zhcUz4uqGEg5qKzZTacHsG7f3Phd?= =?iso-8859-15?Q?qtLK5VInS+POVRfNNe2yz4f1qLytwj9C5tQzwYgemoflLMXcpxAhudqSJ?= =?iso-8859-15?Q?Tk4MOzY0ldWeBGIW/y2oNvVYho71J7/63OKWWD8W2fWfJa/TgtKb6D2vn?= =?iso-8859-15?Q?eem09SaP85AkI2mkRhNO/hOmXklpgjqu70eQGrZY279uQCqFVRZehzs5f?= =?iso-8859-15?Q?XH7rrXGMGPPHGcmEM5AdB5hqh7U95s0Z0nR2CW0td9/7wTpgwsMKmKuy6?= =?iso-8859-15?Q?38T7MD6DKUKyLQHcP9jISGUIuWCyu1dZVxtqYdeqHiofTnz1KMEe+4Jc+?= =?iso-8859-15?Q?geiBpTsEChYNlH9JXyUhcxtmhUfRlSZgmJXjN5NB0VSXfi6WoOL8p1rvP?= =?iso-8859-15?Q?kkwVj8H6sKKHLcgyFuiTy9zy/cx5ZsIx+iVkGJNgXDNVkOAq7Bxeaq1VT?= =?iso-8859-15?Q?uCTWAnP0v6j4igaF4RaHTaD5o2ajzYC79VrZ34t7JLVUjyCQ9Z1z2oyB/?= =?iso-8859-15?Q?D9RExdImm4X11Mq1+V5iH0wDVPNSH6//XGnQjhErA0LZYFP5QAILb+ngD?= =?iso-8859-15?Q?Ly3OTjFXaJ3zhwHoouNs8WgOfbZzWd/FrguJBeFUcbtZgPwfRtQc19GtF?= =?iso-8859-15?Q?ZOutH5Y5ObOVgsQ4lnfkXhVHMrWWzj88GejVroR/xxGPjUqNNNvU0S2+1?= =?iso-8859-15?Q?jHpq2K9ELg2xdauRDVYckSWHoQ=3D=3D?= MIME-Version: 1.0 X-OriginatorOrg: labware.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SA1PR17MB5365.namprd17.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c71c688a-4aab-440d-9f2d-08de31edf2ca X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2025 21:58:38.3504 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b5db0322-1aa0-4c0a-859c-ad0f96966f4c X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7aW0JGjJWLJAY66Lv0VV0fvpffY1kss6XPYmkjaK/15bF7dEYTHXUCthJqgE4nSp+9fkcbw62W5a1xvjYYTSwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR17MB7111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OC-pUT2DmLUu4E6i7DeEBHK6nhuLPKWWxIvSUSejNV0_1764712720 X-Mimecast-Originator: labware.com Content-Language: en-US Content-Type: text/plain; charset=ISO-8859-15 Content-ID: <03AC3EE421E09D48BCF5E25CBA9D4865@namprd17.prod.outlook.com> Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, 2025-12-02 at 10:41 -0700, Tom Tromey wrote: > > > > > > "Jan" =3D=3D Jan Vrany writes: >=20 > Jan> Finally, I was considering of making this change up in lookup method > Jan> but in the end decided to be bit more conservative because comment i= n > Jan> original find_block_in_blockvector() suggested that returning a stat= ic > Jan> block from there is an expected situation. >=20 > FWIW it seems to me that the blockvector should just have a single > lookup function, and it should be used to find precisely the code block > containing the given address.=A0 That is, it should never return the > static or global block, since those aren't really "code" but instead > just containing scopes.=A0 This is the direction I was trying to head by > removing calls to map(); the one remaining call is one of these weird > ones... I agree, I just do not really understand why there was the difference in fi= rst place. In fact, it seems that it matters - I've got a report that this commit caus= ed regression on arm (still investigating, I do not have armhf system at hand,= so need to set it up first). Jan >=20 > Anyway I consider this important for supporting expandable blockvectors, > which in turn is important for lazy CU expansion. >=20 > Tom