From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26735 invoked by alias); 31 Oct 2019 16:42:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26678 invoked by uid 89); 31 Oct 2019 16:42:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Oct 2019 16:42:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1572540149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HTWJ24D41dLTpnKDn90vefDyCvkIjpvlw2dl1lBujXQ=; b=gHTQuPq/54P+GaUuZ/Yw1ckgkiE/pKx2wS9uBGIm48kWjYARrBpihFAWCjDyIhLmMIDcEv q4f/QdE8OwhHwCxUa14ZO58er4jV7CVjWu5G5ovmoucCs9v713BFXqgbwPTNCE80pAWhdM UuZqmAR3eQA3ur2NVq4VZ6ZdFdkg1OU= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-2765l1gcOw-04g2koJsPnw-1; Thu, 31 Oct 2019 12:42:25 -0400 Received: by mail-wr1-f71.google.com with SMTP id e3so1270829wrs.17 for ; Thu, 31 Oct 2019 09:42:25 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id r5sm4240803wrl.86.2019.10.31.09.42.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Oct 2019 09:42:23 -0700 (PDT) Subject: Re: [PATCHv2] Make "skip" work on inline frames To: Bernd Edlinger , Simon Marchi , "gdb-patches@sourceware.org" References: <8fc93db4-8906-4f4e-53f4-225ebfa0115d@simark.ca> <215bbf9c-4c3c-5cd2-c657-51aa7262f234@simark.ca> From: Pedro Alves Message-ID: Date: Thu, 31 Oct 2019 16:42:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-10/txt/msg01171.txt.bz2 On 10/30/19 9:56 PM, Bernd Edlinger wrote: > +if { [prepare_for_testing "failed to prepare" "skip2" \ > + {skip2.c skip1.c } \ > + {debug nowarnings optimize=3D-O2}] } { Instead of -O2, could you make this use -O0 (the default), and then use attribute((always_inline)) to force inlining?=20 We do that in some tests. E.g., gdb.opt/inline-locals.c. Quickly skimming the patch, I noticed a number of duplicated test names. See: https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Make_sure_test_message= s_are_unique Thanks, Pedro Alves