From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55982 invoked by alias); 20 Mar 2019 16:21:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55973 invoked by uid 89); 20 Mar 2019 16:21:04 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.1 spammy=H*MI:sk:2019032 X-HELO: mail-wr1-f67.google.com Received: from mail-wr1-f67.google.com (HELO mail-wr1-f67.google.com) (209.85.221.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Mar 2019 16:21:03 +0000 Received: by mail-wr1-f67.google.com with SMTP id g12so3467207wrm.5 for ; Wed, 20 Mar 2019 09:21:02 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id t2sm4804271wra.9.2019.03.20.09.21.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Mar 2019 09:21:00 -0700 (PDT) Subject: Re: [PATCH] Merge handle_inferior_event and handle_inferior_event_1 To: Tom Tromey , gdb-patches@sourceware.org References: <20190320140846.13031-1-tromey@adacore.com> From: Pedro Alves Message-ID: Date: Wed, 20 Mar 2019 16:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190320140846.13031-1-tromey@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-03/txt/msg00433.txt.bz2 On 03/20/2019 02:08 PM, Tom Tromey wrote: > I noticed that handle_inferior_event is just a small wrapper that > frees the value chain. This patch replaces it with a > scoped_value_mark, reducing the number of lines of code here. > > Regression tested on x86-64 Fedora 29. > > gdb/ChangeLog > 2019-03-20 Tom Tromey > > * infrun.c (handle_inferior_event): Rename from > handle_inferior_event_1. Create a scoped_value_mark. > (handle_inferior_event): Remove. OK. Thanks, Pedro Alves