From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58358 invoked by alias); 10 Feb 2020 22:33:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58347 invoked by uid 89); 10 Feb 2020 22:33:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-wm1-f66.google.com Received: from mail-wm1-f66.google.com (HELO mail-wm1-f66.google.com) (209.85.128.66) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 10 Feb 2020 22:33:06 +0000 Received: by mail-wm1-f66.google.com with SMTP id g1so1062984wmh.4 for ; Mon, 10 Feb 2020 14:33:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=A6+R6cu4vxnV+67E7JVoa85FrcB99T+JNv/gGsvWOKs=; b=OnRwbv/IIFO58byUWlWTZn3x2o54rwvUKEUc/pFpwe/DPw9ibNDIvlQihdPynSYzUM G9s2H7utcBE9TBNyjZcXz1MMR7r5cLi8lFMGBz7d0NtPBdCtHrFGeVldDRG2oQpUx5En qCw2aRNJ6Mt23R5dNGtDcujFOQM8H+PY4pcePRmmegACuG6IZ+ojzBx4eMcSxnfBg71b rOo4KWHPQSFwDyfCB0kDQKNwkewIEb06m9//C9qFWaVujYF5fltbXeQog6GpwX3zYWEr HfDpPcWzrIj084I3VCUdNicDW7wqxW69Fn5k6CcBfBYggbm0AGKSWlceFS05InFphzfW GUqQ== Return-Path: Received: from [172.29.6.113] (26.124.146.82.ipv4.evonet.be. [82.146.124.26]) by smtp.gmail.com with ESMTPSA id k8sm2302060wrq.67.2020.02.10.14.33.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Feb 2020 14:33:02 -0800 (PST) Subject: Re: [PATCH] Fix kill of processes created by win32_create_inferior To: Hannes Domani , gdb-patches@sourceware.org References: <20200208182539.5775-1-ssbssa.ref@yahoo.de> <20200208182539.5775-1-ssbssa@yahoo.de> From: Luis Machado Message-ID: Date: Mon, 10 Feb 2020 22:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200208182539.5775-1-ssbssa@yahoo.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2020-02/txt/msg00301.txt.bz2 On 2/8/20 3:25 PM, Hannes Domani via gdb-patches wrote: > handle_v_kill uses signal_pid because win32 doesn't support multi-process. > > gdbserver/ChangeLog: > > 2020-02-08 Hannes Domani > > * win32-low.c (win32_create_inferior): Set signal_pid. > --- > gdbserver/win32-low.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/gdbserver/win32-low.c b/gdbserver/win32-low.c > index 9d0343788f..557c90d97c 100644 > --- a/gdbserver/win32-low.c > +++ b/gdbserver/win32-low.c > @@ -709,6 +709,9 @@ win32_create_inferior (const char *program, > (assuming success). */ > cs.last_ptid = win32_wait (ptid_t (current_process_id), &cs.last_status, 0); > > + /* Necessary for handle_v_kill. */ > + signal_pid = current_process_id; > + > return current_process_id; > } > > Thanks. This one looks OK to me. It would be nice to augment the description with what situation this fixes. I suppose it doesn't kill the process properly?