From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GpFdBIpGdGJkhwQAWB0awg (envelope-from ) for ; Thu, 05 May 2022 17:50:02 -0400 Received: by simark.ca (Postfix, from userid 112) id 015821E058; Thu, 5 May 2022 17:50:01 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=rBpieSrc; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 65A9C1E00D for ; Thu, 5 May 2022 17:50:01 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A196D3857375 for ; Thu, 5 May 2022 21:50:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A196D3857375 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1651787400; bh=zY44yTTp0bFk6YSg3KLHNTzngQR4a0PXuHgnNKyjzpI=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=rBpieSrc3kkIp1ES/zaKXca4iPkH5P1KzKIh7X4/+eTaSDDSDnS2wqbwuDcm3PQSf MjPr4l64vPd+qDUnW454Gz5tT9L4ody7tbslWb1hcfPZNTIOU5Ap6TwR/pQO9DaXw5 nyyLzRwo/v+m1xP9IH/O16G2YmQ79NoNfUq4g1xA= Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id DC7EF3858016 for ; Thu, 5 May 2022 21:49:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC7EF3858016 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 245KNkPE002345; Thu, 5 May 2022 21:49:37 GMT Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3fvnk29d4t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 May 2022 21:49:37 +0000 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 245LmFgh024622; Thu, 5 May 2022 21:49:35 GMT Received: from b03cxnp07027.gho.boulder.ibm.com (b03cxnp07027.gho.boulder.ibm.com [9.17.130.14]) by ppma02wdc.us.ibm.com with ESMTP id 3frvra4acf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 May 2022 21:49:35 +0000 Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp07027.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 245LnZH725100690 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 5 May 2022 21:49:35 GMT Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 09611136055; Thu, 5 May 2022 21:49:35 +0000 (GMT) Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C7391136061; Thu, 5 May 2022 21:49:34 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.152.172]) by b03ledav002.gho.boulder.ibm.com (Postfix) with ESMTP; Thu, 5 May 2022 21:49:34 +0000 (GMT) Message-ID: To: Pedro Alves , gdb-patches@sourceware.org Date: Thu, 05 May 2022 14:49:34 -0700 In-Reply-To: <20220505185020.3648774-2-pedro@palves.net> References: <20220505185020.3648774-1-pedro@palves.net> <20220505185020.3648774-2-pedro@palves.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 8MmdtBJm3xJTi8FECWG1YH8aMYq_rMrD X-Proofpoint-GUID: 8MmdtBJm3xJTi8FECWG1YH8aMYq_rMrD Subject: Re: [PATCH 1/3] Fix "b f(std::string)", always use DMGL_VERBOSE X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.858,Hydra:6.0.486,FMLib:17.11.64.514 definitions=2022-05-05_09,2022-05-05_01,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 mlxlogscore=935 spamscore=0 clxscore=1015 mlxscore=0 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2205050138 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Carl Love via Gdb-patches Reply-To: Carl Love Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Pedro: I pulled down a fresh copy of gdb and tried to apply the first patch. There were issues with patching the files: patch -p 1 < Fix__b_f_std_string__,_always_use_DMGL_VERBOSE_1.patch (Stripping trailing CRs from patch; use --binary to disable.) patching file gdb/cp-name-parser.y (Stripping trailing CRs from patch; use --binary to disable.) patching file gdb/cp-support.c (Stripping trailing CRs from patch; use --binary to disable.) patching file gdb/cp-support.h patching file gdb/testsuite/gdb.cp/break-f-std-string.cc (renamed from gdb/testsuite/gdb.cp/no-dmgl-verbose.cc) (Stripping trailing CRs from patch; use --binary to disable.) patching file gdb/testsuite/gdb.cp/break-f-std-string.exp (Stripping trailing CRs from patch; use --binary to disable.) patching file gdb/testsuite/gdb.cp/no-dmgl-verbose.exp Reversed (or previously applied) patch detected! Assume -R? [n] n Apply anyway? [n] n Skipping patch. 1 out of 1 hunk ignored -- saving rejects to file gdb/testsuite/gdb.cp/no-dmgl-verbose.exp.rej The issue seems to be with deleting the file: gdb/testsuite/gdb.cp/no-dmgl-verbose.exp I manually deleted it. I then used git to commit the patch to my local git directory so I could add the second patch. The second patch applied cleanly. The third patch applied cleanly. I ran the test gdb.cp/break-f-std-string.exp. It runs without errors on a Power 10 system. testcase gdb/testsuite/gdb.cp/break-f-std-string.exp completed in 1 seconds === gdb Summary === # of expected passes 16 I also ran the full regression suite with and without the patch. No regression failures were found. Other than the patch not cleanly removing gdb/testsuite/gdb.cp/no-dmgl- verbose.exp it all looks good. Thanks for fixing this test. Carl Love