From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110644 invoked by alias); 3 Oct 2019 17:59:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110625 invoked by uid 89); 3 Oct 2019 17:58:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: userp2120.oracle.com Received: from userp2120.oracle.com (HELO userp2120.oracle.com) (156.151.31.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 03 Oct 2019 17:58:58 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x93HsmPs080882; Thu, 3 Oct 2019 17:58:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=AD0linse5Ccf1utM/vRyiwKaTNdgpb7WbXYYW7LukiQ=; b=nZWEodRvd2L3KtKyG9gyC9xEyerUlHV3M3gZLWgGDlTAW28xnJxPDk1y80GhxjNxVQBC NLToIAAzpcNs96uHLkkA+GZDNuXfPT1elTDzxIlTmcercoEo/QH7LTjejwmjEM1ZHNMB hNamhqRyIMCT4mQFyt1Z4Kb80Ro2T+Cvrqs+uj2jv9fSMFah3lgdHcYrhH+w6mYrt1ud 35WAqn5SR1jNe0N7hUb5uzO8TDF0WmrW+UfTPf50gUtIyc9BxpZnB3NF2ii+kKrFXReR BIGqrn0x88H9e/9jRIPxlymdJ8VhLUv7Z7PgNUYvoVJNb0D/5p1H6q43R4BCI2AhrFk3 hQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 2va05s5w91-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Oct 2019 17:58:53 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x93Hwd7p074401; Thu, 3 Oct 2019 17:58:53 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2vcx72vptd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 03 Oct 2019 17:58:50 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x93Hw6Sr027629; Thu, 3 Oct 2019 17:58:06 GMT Received: from [10.159.232.91] (/10.159.232.91) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 03 Oct 2019 10:58:06 -0700 Subject: Re: [PATCH v2] gdb: CTF support To: Simon Marchi , gdb-patches@sourceware.org References: <1564530195-27659-1-git-send-email-weimin.pan@oracle.com> <5377c457-52b0-583d-15b5-47024eae1f48@simark.ca> <895f47d4-3e01-4d5a-474b-43dd2dd037b4@oracle.com> <0fe82814-46b8-79c2-6a25-5f5d51b158e1@simark.ca> <1055d18f-9e5c-3344-114a-3777876c9c63@oracle.com> <3a67839f-73d0-06ed-4140-073306fc618d@simark.ca> From: Wei-min Pan Message-ID: Date: Thu, 03 Oct 2019 17:59:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <3a67839f-73d0-06ed-4140-073306fc618d@simark.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-10/txt/msg00119.txt.bz2 On 10/3/2019 5:40 AM, Simon Marchi wrote: > On 2019-10-02 7:09 p.m., Wei-min Pan wrote: >> It doesn't seem using gdb::unique_xmalloc_pointer is appropriate in >> these cases >> because we want to keep these symbol/type names around in the symbol table. > I mean, instead of calling `free` by hand, that copy could be managed with > a gdb::unique_xmalloc_pointer. The name duplicated into the symbol table > won't change. But the `free` call is needed to free up space allocated by libctf's ctf_type_aname_raw. > Simon >