From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id z5LzLTuZGWAWMwAAWB0awg (envelope-from ) for ; Tue, 02 Feb 2021 13:26:03 -0500 Received: by simark.ca (Postfix, from userid 112) id AE3BD1EF80; Tue, 2 Feb 2021 13:26:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 246691E939 for ; Tue, 2 Feb 2021 13:26:02 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 97E14398B421; Tue, 2 Feb 2021 18:26:01 +0000 (GMT) Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id 06331398B847 for ; Tue, 2 Feb 2021 18:25:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 06331398B847 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=mentor.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=abid_qadeer@mentor.com IronPort-SDR: n9V7nQm648P5TVynx03msuN4h++xnSlzzEGx0JPxjnl0lvJ0IqouyVHZYZWSS1ADIoXHJOgv2n mg3Q9HrxCQJOf5P4W2pf6rF2l10CA5eiywhAU+EWDV/upVVx6wqxNSZir4FoQAg1nEX+oFjGMx IcCbaXO69nZJry1q7UeiPR7AVEDEzstjNKtWbJjg3hNNC6KdOwABn7jFlAX8IaQ9m14uTCQsqH GBvTTPrPGKWygrIC38YLXd4DB3zoXZaDH15kd+0qzKYaPzG4xnpJWtgobtgE+0ivlPT9/Ir++6 PpE= X-IronPort-AV: E=Sophos;i="5.79,396,1602576000"; d="scan'208";a="57688877" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 02 Feb 2021 10:25:58 -0800 IronPort-SDR: IVNYXUtFjEZhkkrVAehUcl0/yWRjqgxRE53Ii8NLvf115SD/NORQsgJaW51orcvpDeMECjP3Aq /0U3a91iI/aNt4+MakUxYwIptOveEZHnNX3FAbCIlVhdyz8D3a4bgZI5Bws4kyRRoC50xRx8uC khe7kntSp/KOmbMmDx+uARZW53te496tH6fwc/WYojYpRh2vrregZUhRzlUmR6CK4yndtrdo4+ PNnd75/1eHk4ug/B0nTe471iYbZAdkkA1RbnGRz4QHjZbtKoJHDo0TOTP4N/mjW1Gc3oEBcu5i qNE= Subject: Re: [PATCH][gdb] Fix internal-error in process_event_stop_test To: Tom de Vries , Tom Tromey References: <20210105132923.GA15843@delia> <87y2h4v77m.fsf@tromey.com> From: Hafiz Abid Qadeer Message-ID: Date: Tue, 2 Feb 2021 18:25:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 08/01/2021 05:23, Tom de Vries wrote: > On 1/7/21 9:10 PM, Tom Tromey wrote: >>>>>>> "Tom" == Tom de Vries writes: >> Tom> Fix this by only trying to install the master exception breakpoint in >> Tom> libgcc.debug using the _Unwind_DebugHook method, if the install using probes >> Tom> in libgcc failed. >> >> This seems like a reasonable idea. >> >> Tom> Any comments? >> >> I suspect this would be a bit shorter if the loop only examined >> "primary" objfiles (ones that don't have a backlink) and then delegated >> to a helper function that did the search. What do you think? > I've made the loop now over "primary" objfiles. Also, I've split up the > helper function into one using probes, and the other using the hook, > which hopefully helps to make the code a bit clearer. > > I'll put this through testing and commit, unless there are further comments. Hi Tom, I observed that nextoverthrow.exp is now failing for many targets including arm-none-eabi after this change. > + /* Iterate over separate debug objects and try an _Unwind_DebugHook > + kind breakpoint. */ > + for (objfile *sepdebug = obj->separate_debug_objfile; > + sepdebug != nullptr; sepdebug = sepdebug->separate_debug_objfile) > + if (create_exception_master_breakpoint_hook (sepdebug)) > + break; This bit seems to be problematic as it is stopping exception breakpoint to be installed when separate_debug_objfile is null. Thanks, -- Hafiz Abid Qadeer Mentor, a Siemens Business