From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 10P5NhdNcl/rMAAAWB0awg (envelope-from ) for ; Mon, 28 Sep 2020 16:52:39 -0400 Received: by simark.ca (Postfix, from userid 112) id D39531E591; Mon, 28 Sep 2020 16:52:39 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2584C1E58E for ; Mon, 28 Sep 2020 16:52:39 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B83E1394C01A; Mon, 28 Sep 2020 20:52:38 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 195753857C55 for ; Mon, 28 Sep 2020 20:52:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 195753857C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 99C841E58E; Mon, 28 Sep 2020 16:52:35 -0400 (EDT) Subject: Re: [PATCH 1/5] Include the x86-bsd-nat.h header and fix the NetBSD/i386 build To: Kamil Rytarowski , Christian Biesinger References: <20200923042515.28245-1-n54@gmx.com> <20200923042515.28245-2-n54@gmx.com> <21296855-3b77-9fea-0295-7213cbe99143@netbsd.org> From: Simon Marchi Message-ID: Date: Mon, 28 Sep 2020 16:52:35 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <21296855-3b77-9fea-0295-7213cbe99143@netbsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-09-23 9:29 a.m., Kamil Rytarowski wrote: > On 23.09.2020 15:15, Christian Biesinger wrote: >> On Wed, Sep 23, 2020 at 6:26 AM Kamil Rytarowski wrote: >>> >>> In file included from ../../gdb/i386-nbsd-nat.c:26: >>> ../../gdb/i386-bsd-nat.h:34:53: error: expected template-name before '<' token >>> 34 | class i386_bsd_nat_target : public x86bsd_nat_target >>> | ^ >> >> Seems like x86-bsd-nat.h should be included by i386-bsd-nat.h instead? >> > > I have got no opinion. This patch replicates what FreeBSD does. Indeed, i386-bsd-nat.h uses x86bsd_nat_target, so it needs to include x86-bsd-nat.h. The patch is ok with that fixed. Simon