Re: [PATCH] aarch64: Check for valid inferior thread/regcache before reading pauth registers

[Luis Machado via Gdb-patches <gdb-patches@sourceware.org>]

On 3/17/23 17:29, Simon Marchi wrote:
> 
>> What would be the outcome of this call when there is no active register cache because the inferior
>> has been killed? I think it would assert in find_inferior_pid with a null_ptid.
>>
>> aarch64_remove_non_address_bits gets called for any memory access, so we may be in a state where we have
>> a valid stopped thread, a valid running thread, core file, no inferiors (just reading symbols/bfd) and so
>> on.
>>
>> Or were you considering doing a check for inferior_ptid == null_ptid before calling get_thread_regcache?
> 
> Yes, a check for inferior_ptid == null_ptid would make sense.  I was
> really just thinking about the initial problem, which is
> aarch64_remove_non_address_bits being called while processing the event
> in thread-db.

I could switch to using inferior_ptid instead of using the helper functions to check current_thread_ if it is
deemed more appropriate.

If the threads are running while we try to read memory, the try/catch block will guard against register read errors.

> 
> Simon