Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@polymtl.ca>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] enum_flags: Use C++11 std::underlying_type
Date: Sat, 05 Nov 2016 02:28:00 -0000	[thread overview]
Message-ID: <c5bacec93a702b2d3438dd32bf9d6fb2@polymtl.ca> (raw)
In-Reply-To: <1478229738-24469-2-git-send-email-palves@redhat.com>

On 2016-11-03 23:22, Pedro Alves wrote:
>  template <typename E>
>  class enum_flags
>  {
>  public:
>    typedef E enum_type;

I have a question about this, even though it's not a change part of this 
patch.  Is it useful to have a typedef to define enum_type?  Can't we 
directly use template <typename enum_type> above the class?


  reply	other threads:[~2016-11-05  2:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-04  3:23 [PATCH 0/3] enum_flags: Fix problems and add comprehensive unit tests Pedro Alves
2016-11-04  3:23 ` [PATCH 2/3] " Pedro Alves
2016-11-05  2:47   ` Simon Marchi
2016-11-05  3:05   ` Simon Marchi
2016-11-04  3:23 ` [PATCH 1/3] enum_flags: Use C++11 std::underlying_type Pedro Alves
2016-11-05  2:28   ` Simon Marchi [this message]
2016-11-04  3:23 ` [PATCH 3/3] enum_flags: Fix ternary operator and remove implicit convertion to raw enum Pedro Alves
2016-11-07 13:33 ` [PATCH 0/3] enum_flags: Fix problems and add comprehensive unit tests Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5bacec93a702b2d3438dd32bf9d6fb2@polymtl.ca \
    --to=simon.marchi@polymtl.ca \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox