From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6Rb+JTq7R2ouvSMAWB0awg (envelope-from ) for ; Fri, 03 Jul 2026 09:38:02 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bueAe/F6; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 95FBB1E098; Fri, 03 Jul 2026 09:38:02 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C58A51E024 for ; Fri, 03 Jul 2026 09:38:01 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D8DE44BA2E18 for ; Fri, 3 Jul 2026 13:38:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D8DE44BA2E18 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bueAe/F6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 43E744BA2E1A for ; Fri, 3 Jul 2026 13:37:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 43E744BA2E1A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 43E744BA2E1A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783085855; cv=none; b=Q3APz4VQ5TkVxjCbYsAUsFan4WQMqMdf04YBC/3NNw33lILI0U3FOdGIrKg2FgL00LK5lwZEvWab/ZZkRUCKCYozYcsd5J9fnxHtUkypDOa2wCg5WWnuQmfwJlkVrcafrzljzccaO6Xd5TQifdJi34TCXYB5z2v0zPnZ6nUJuxo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783085855; c=relaxed/simple; bh=vTncbBWIqg0wS9xcEuWV3StfXwjT+Ll9O0ai+MhIrhk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=WFKGH+kc96QR0qJKhwm3Hwm1PuAzYbF/xtnfrkEYAs3fGqYaxc9VmfbqN7xbr3ZL9f9ie/eKVdN37j4x0qEi3bcL6J7VBo3OZEqyLtJV5ZXguBz9DywkC5ntGmiYgPHWiXEsXVi41dyjn0rpPw7DmpyCBWZuwdVo5Pej4NRFdNI= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bueAe/F6 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 43E744BA2E1A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1783085854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nWp6SFT+8EkJbvVuRs74RLosBlT4Cc++zw8RUqdJKuQ=; b=bueAe/F6gRo541KICFGrHh9sMbbu6dI2pYLXkRXeSjG8tn48UebfWudNKPuF1dUh8R2K0d kOA51zrrIm6V9zcR9FVK0QHTiMLgPZ/94SVhLb3FliOUnwpy0GRvEKvHxqX/ctcCcCfkaA dUoJ6SAHLUOvGZJPRzdAjQxjXkGXqAk= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-19-IMIOn-X9P8KSLLbRPCpfAQ-1; Fri, 03 Jul 2026 09:37:33 -0400 X-MC-Unique: IMIOn-X9P8KSLLbRPCpfAQ-1 X-Mimecast-MFC-AGG-ID: IMIOn-X9P8KSLLbRPCpfAQ_1783085852 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-c88e0f04e51so665742a12.0 for ; Fri, 03 Jul 2026 06:37:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783085852; x=1783690652; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nWp6SFT+8EkJbvVuRs74RLosBlT4Cc++zw8RUqdJKuQ=; b=JIfAwkusPsnDzNQj/YJbuCHJdOZsSB1eacbOnE7e1JlwQjhO5FFQ/qktUFxumpoW1m jBRhIy+SjklKAKSaXx2qLK3e5bp+RZu9O80/lI+IMD/QrhdUW1JbSB/sQllADR6wV0ZF qGu/UhlJokCGnOZ9s+IKv4bqjC5r/qT+QNmOphmkcDM7sXuMmwpaPu9R0HVnribR+paY tR2L4n3LTFekMg6C8PBFzNYmb790++6giEjQPdhFhIXH+70fJtBRqmk11tX0xVgEnqy2 6R09HTrsxcETvX3FY132PEEdZckn1+biP+CeFMqrnK/FzrphPSYm//0Z7TsxqEiOAhsL sBiA== X-Gm-Message-State: AOJu0YxB6rbZW7nvasN4yaFTvjiPcWHp2ukieI/vYrXg51vjxUBbEK7u F6k5iT2LZOJpxihmGSYwiKHhgcM/oe672DZSKi70MKqeXAmCb4vLx98C+uKSBHaoc41eGU5XGJn dCDWcmoQddVgalFZG5VLGFAMzeqBVlkzeMh40GftctmjoHzeIrLUzduPynUfP7yv30uIQ1Cx2gQ 5wiBdP1qxwmLMyw7H0S4g0rmJjyIlH5c1Ufw2Ase6Ulu6yb1ar X-Gm-Gg: AfdE7cmAQIQGSHipa4E/EguLfZo1g3nk6Rkk/qcXMe61S7sUvVGiTvBCHUqFWCgWjTb Phi0+Q/7FpoQJYUyl4pmotgo4075LHLirBln4Mj/e/EHWz29tlX+TV+0t9FZIeR4MYro0ZjMgBN 6g298W6ko9mscFuitRFIJmA/0/mfZvf4gG48XarndXsryR19HpyXMP+rfAy7dljbUPq6jkF7ZHB aDNmOhKT4N5z+kKiSKwB8kxFq1i1/hdeajZx7ujDLta2PxyMouczya2OcaOoOIaofAKaYtNmykK HdVpvADLAGKXcCSpVx0mXK84Al5ihUEffSSXSDWcxQxn56YXGZb6UknJFsU1cTspEqHn6D6Qoe3 mkWw8iUUUL/OO9l+gXWNH X-Received: by 2002:a05:6a20:9185:b0:3b2:a8cd:ef4a with SMTP id adf61e73a8af0-3bff4255da9mr10468732637.30.1783085852395; Fri, 03 Jul 2026 06:37:32 -0700 (PDT) X-Received: by 2002:a05:6a20:9185:b0:3b2:a8cd:ef4a with SMTP id adf61e73a8af0-3bff4255da9mr10468678637.30.1783085851662; Fri, 03 Jul 2026 06:37:31 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b3ececfe4sm22184293c88.8.2026.07.03.06.37.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Jul 2026 06:37:31 -0700 (PDT) Message-ID: Date: Fri, 3 Jul 2026 10:37:26 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/8] refactor the internals of record-full To: gdb-patches@sourceware.org References: <20260615161500.34181-1-guinevere@redhat.com> From: Guinevere Larsen In-Reply-To: <20260615161500.34181-1-guinevere@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Bk6zomQAVLVgFYm6I_-jS8eQejXZW1qrwIaWOBYg_EA_1783085852 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/15/26 1:14 PM, Guinevere Larsen wrote: > This series introduces a refactor and modernization to the record-full > history, moving it form a manually managed doubly-linked list into an > std::deque, which can make better use of caching and might make > execution faster. > > The main driving force behind this change is the plan to implement > support for multithreaded inferiors, since each instruction will need to > know the thread that executed it, and it'll be much easier if there is a > more consistent spot to find all this information. > > All patches in this series have received review tags, so I plan to > approve it myself and pushing it next monday if no further reviews > happen. > > Changes for v5: Added an assert that we are always assigning entries to > uninitialized entries, and comment explaining the reasoning. > > Changes for v4: Split the first commit into the majority of the > refactor and the refactoring of reading/writing to a corefile. The rest > was mostly cosmetic changes suggested by Christina. > > Changes for v3: Made the former "cleanup" functions into actual > destructors. To do that and avoid double-frees, I made it so > record_full_entry (and the 2 classes under it) can't be copied, only > moved. Also implemented almost all the feedback from Christina on the > changes. I checked these in, since they've been on the list for 2 weeks with no comments. -- Cheers, Guinevere Larsen it/its she/her (deprecated) > Guinevere Larsen (8): > gdb/record: Refactor record history > gdb/record: factor out reading and writing the execution log to > corefile > gdb/record: remove record_full_insn_num > gdb/record: c++ify internal structures of record-full.c > gdb/record: make record_full_history more c++-like > gdb/record: extract the PC to record_full_instruction > gdb/record: Define new version of the record-save section > gdb/record: rename record_full_list to record_full_log > > gdb/NEWS | 4 + > gdb/aarch64-tdep.c | 2 - > gdb/amd64-linux-tdep.c | 3 - > gdb/arm-tdep.c | 2 - > gdb/i386-linux-tdep.c | 3 - > gdb/i386-tdep.c | 4 - > gdb/loongarch-tdep.c | 2 - > gdb/moxie-tdep.c | 2 - > gdb/ppc-linux-tdep.c | 3 - > gdb/record-full.c | 1740 +++++++++++++++++++--------------------- > gdb/record-full.h | 1 - > gdb/riscv-tdep.c | 3 - > gdb/rs6000-tdep.c | 4 - > gdb/s390-linux-tdep.c | 3 - > gdb/s390-tdep.c | 2 - > 15 files changed, 848 insertions(+), 930 deletions(-) > > > base-commit: d62f64e17b33fb76653fa0c008c61b782d07f8ec