From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56021 invoked by alias); 27 Apr 2017 21:40:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 56005 invoked by uid 89); 27 Apr 2017 21:40:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=Hx-languages-length:1919, awesome X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 27 Apr 2017 21:40:16 +0000 Received: by simark.ca (Postfix, from userid 33) id 2609C1E48D; Thu, 27 Apr 2017 17:40:17 -0400 (EDT) To: Tom Tromey Subject: Re: [RFA 2/2] PR cli/19551 - change formatting of "Reading symbols" messages X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 27 Apr 2017 21:40:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org, Tom Tromey In-Reply-To: <20170413041504.14435-3-tom@tromey.com> References: <20170413041504.14435-1-tom@tromey.com> <20170413041504.14435-3-tom@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00756.txt.bz2 On 2017-04-13 00:15, Tom Tromey wrote: > From: Tom Tromey > > PR cli/19551 notes that the "Reading symbols" messages can be messy, > for > example: > > (gdb) file /bin/gdb > Reading symbols from /bin/gdb...Reading symbols from /bin/gdb...(no > debugging symbols found)...done. > (no debugging symbols found)...done. > > In this case the first message is being interrupted by the message for > the minidebug info; then the subsequent output is emitted strangely. > > This patch changes gdb to use a progress bar when reading debug info. > It modifies the DWARF reader(s) to update the progress. Any printing > is deferred until the first progress report, so the messages no longer > clash. > > While printing the status message it looks like: > > Reading symbols from ./gdb > [############## ] > > The "#"s show the progress; these are only printed on a terminal. > > When it is finished it looks like: > > Reading symbols from .gnu_debugdata for /usr/bin/gdb > Reading symbols from /bin/gdb > > I made the MI implementation do nothing. MI has a > "status-async-output" production in the grammar: > > 'STATUS-ASYNC-OUTPUT ==>' > '[ TOKEN ] "+" ASYNC-OUTPUT NL' > > ... which maybe could be used for this sort of thing. Currently I > think > it's only used for "load" progress (see mi_load_progress); so it wasn't > clear to me whether this would be a good idea. Hi Tom, I think that having a progress bar would be really awesome (right after making GDB load debug info faster so fast that we don't need one). However, I think that feature would deserve a patch of its own with a more expressive title. I am sure many people will be interested, but like this it's hidden under some obscure bug fix. Would it be possible to make this patch a simple bug fix and put the progress bar in a patch of its own? Thanks, Simon