From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tKwwOXQ5g2HzWwAAWB0awg (envelope-from ) for ; Wed, 03 Nov 2021 21:37:56 -0400 Received: by simark.ca (Postfix, from userid 112) id D787F1F0C1; Wed, 3 Nov 2021 21:37:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 480231E940 for ; Wed, 3 Nov 2021 21:37:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 52F1E385843C for ; Thu, 4 Nov 2021 01:37:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 52F1E385843C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635989875; bh=5CL/0+u31Ts253m6azOAmKPeZrOK7w3RTx3ee4YhKys=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=Z2JCVqExsH6MaRHKJPHqnZ6cqH7AC71NWYz0cREfP1uuXFmccWM1B6DQu8pQHp274 dVdRZdoEnAri8oeN/ckBfsAIJJNRI24Dpvn48sMVjR0eiwtnVUJU2s6f1JvMO5v8rt 8+VFyX+vGSK7UEI7se7a/wJQaA3nqmATsAv5URIU= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 396F03857C4E for ; Thu, 4 Nov 2021 01:37:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 396F03857C4E Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1A41bU30010566 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 3 Nov 2021 21:37:35 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1A41bU30010566 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 57E441E940; Wed, 3 Nov 2021 21:37:30 -0400 (EDT) Message-ID: Date: Wed, 3 Nov 2021 21:37:30 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 3/3] PR gdb/27570: missing support for debuginfod in core_target::build_file_mappings Content-Language: en-US To: Aaron Merey , gdb-patches@sourceware.org, tom@tromey.com References: <20210812042406.75637-1-amerey@redhat.com> <20210812042406.75637-4-amerey@redhat.com> In-Reply-To: <20210812042406.75637-4-amerey@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 4 Nov 2021 01:37:30 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-08-12 00:24, Aaron Merey wrote: > Add debuginfod support to core_target::build_file_mappings and > locate_exec_from_corefile_build_id to enable the downloading of > missing core file executables and shared libraries. > > Also add debuginfod support to solib_map_sections so that previously > downloaded shared libraries can be retrieved from the debuginfod > cache. > > When core file shared libraries are found locally, verify > that their build-ids match the corresponding build-id found in > the core file. If there is a mismatch, print a warning and attempt > to query debuginfod for the correct build of the shared library: > > warning: Build-id of /lib64/libc.so.6 does not match core file. > Downloading XY.Z MB executable for /lib64/libc.so.6 Since this is getting a bit old, it doesn't apply anymore. Can you send a new version of the series (including fixes to patch 2)? Thanks Simon