From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23903 invoked by alias); 25 May 2017 11:07:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23008 invoked by uid 89); 25 May 2017 11:07:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 May 2017 11:07:08 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 080817F4BC; Thu, 25 May 2017 11:07:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 080817F4BC Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 080817F4BC Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0E8BC17DEE; Thu, 25 May 2017 11:07:08 +0000 (UTC) Subject: Re: [PATCH] Introduce "set debug separate-debug-file" To: Simon Marchi , gdb-patches@sourceware.org References: <1495668248-16716-1-git-send-email-simon.marchi@ericsson.com> From: Pedro Alves Message-ID: Date: Thu, 25 May 2017 11:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1495668248-16716-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-05/txt/msg00538.txt.bz2 I think this is a good idea. You're missing NEWS and manual bits though. On 05/25/2017 12:24 AM, Simon Marchi wrote: > + if (separate_debug_file_debug) > + printf_unfiltered (" Trying %s\n", link); > + Missing "_()" in several of these new calls. > + > + add_setshow_boolean_cmd ("separate-debug-file", no_class, > + &separate_debug_file_debug, _("\ > +Set printing of separate debug info file search debug."), _("\ > +Show printing of separate debug info file search debug."), _("\ > +When on, GDB will print the searched locations while looking for separate \ > +debug info files."), NULL, NULL, &setdebuglist, &showdebuglist); FWIW, I think it's better to avoid future tense when possible: "When on, GDB prints the searched locations" Thanks, Pedro Alves