From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53944 invoked by alias); 19 Apr 2017 04:03:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53930 invoked by uid 89); 19 Apr 2017 04:03:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=commented, Hx-languages-length:1197 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Apr 2017 04:03:46 +0000 Received: by simark.ca (Postfix, from userid 33) id 8313F1E165; Wed, 19 Apr 2017 00:03:46 -0400 (EDT) To: Pedro Alves Subject: Re: [PATCH 1/4] Change field separator in gdbarch.sh X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 19 Apr 2017 04:03:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <1e5568c8-eead-c0b1-8b34-736b9b6ff5d0@redhat.com> References: <20170416141430.2585-1-simon.marchi@polymtl.ca> <20170416141430.2585-2-simon.marchi@polymtl.ca> <1e5568c8-eead-c0b1-8b34-736b9b6ff5d0@redhat.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00545.txt.bz2 On 2017-04-18 16:20, Pedro Alves wrote: > On 04/16/2017 03:14 PM, Simon Marchi wrote: >> --- a/gdb/gdbarch.h >> +++ b/gdb/gdbarch.h >> @@ -129,7 +129,7 @@ extern void set_gdbarch_bits_big_endian (struct >> gdbarch *gdbarch, int bits_big_e >> >> /* Number of bits in a char or unsigned char for the target machine. >> Just like CHAR_BIT in but describes the target machine. >> - v:TARGET_CHAR_BIT:int:char_bit::::8 * sizeof (char):8::0: >> + v;TARGET_CHAR_BIT;int;char_bit;;;;8 * sizeof (char);8;;0; > > BTW, do you know why does this bit appear in the .h file in the > first place? It's in gdbarch.h because gdbarch.sh thinks it's part of the comment above short_bit, so it gets copied verbatim to the .h. I don't know why it's there though. It seems like it's been there for a really long time, but has always been commented out. I had not seen it before doing this patch, and didn't worry too much about it. Perhaps it was seen as a possible extension in case someone would bother adding support for targets with non-8-bit-bytes? If so, the addressable_memory_unit_size method kind of took that place. Any better guess? Simon