From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id ED60E385E006 for ; Thu, 26 Mar 2020 23:25:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ED60E385E006 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1585265113; bh=TpBbMw7eTmYZgRYLOtQCPqLkXLzMwjDD3fMfwe4jl7o=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=iNxBq8MixQ3hIORNDRbgYAbzzur9aLiOt6AIqFDxYsBtnfAUFleaWlsmykB9ystZg x74jKTiivn4XCuhqKcoe/6F/4yocLEbicn6lOZcYbAkR4NvXezZLEKn0TzG23MwFQN wdRiG/sqjOp016RAEY0fU0H6IdiFwe9ZdNWaa86E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1M72sJ-1jAAHX3fpv-008XY0; Fri, 27 Mar 2020 00:25:13 +0100 Subject: Re: [PATCH] Implement "info proc mappings" for NetBSD To: John Baldwin , Tom Tromey Cc: gdb-patches@sourceware.org References: <20200316173424.25375-1-n54@gmx.com> <875zezm421.fsf@tromey.com> <2b16c08b-330f-1aa8-7c69-c14774847047@gmx.com> <87eetmlv2y.fsf@tromey.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: Date: Fri, 27 Mar 2020 00:24:03 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:W33TzSgNXmfsG+hwP8YIx2J7cY1c+uy2VJuuKiHxqpZXqAVqcFK sK9bljZ22MsIuDmyQ4CRKh1e8r28sLV25ylO/V4ly0lJN20FVrOcmo12QEhri85fG0wKQvU mjbtowsYGzFEbw51pUBHnflL4Zhkm2/qg8xxwHVhwAcjWMXt3sHao0L8ZLbi/JJGxIGuG3n 1jsDngqL9KGhJXD0Ar5DA== X-UI-Out-Filterresults: notjunk:1;V03:K0:npt06NoknzU=:MfNzoAE3ZfHvpvSX3fToNn QINm04WO/c8FMM+f2jaqxf1DJ4KNPniZ9nNVaPPsaGCOPI4kLk/kOh//EN6Zi+izRQkGIjpVt dj6YOy04app6rAaGPeZd/sGskyAebxgA79vlDDHMNqhIDUe3LXziP21hLT3lZndENSLSK6GTl INJ1J3ue5U11SrkOWoEVThXGWOABZOZ3s00T5ddeZ6e8B2dwq+QmGwefj+9RJG2HH25KoPLyo Jj7HTryGFT9D34hOcyq7McjHnjGI0HLllWdtgxsTcHMToXH356Zf3g0KKceJ9CR8WjkviEcAR ydEMvMKFxNEyuKB8UGqq8NBG8lFvFvLTN7BWeJ+ua86qtvURckHEfxWqbaj7TTTIHuQXSbKcz 6ztcjUEkJRnbMaPbbkVimrke6vbuwyrwTtj46RBbt+4tpW3scgqAhTThJeVQ4R+iczFxQtXBv pxnQ00ZMZsEJ/Jb2a2qsCUQOxmg/L13LUKoEKGUb/SVYj5AGcQo1ep3tnHZknGBlTj1bOw6On be/GNB7PsX6BjIG6xExmZiOsL8m2wdtJJxmKDYTWPSdl7sfqQChSFYO6SG+lv6J/vLqLm2Yro kdWVfv/2FeNLF0J7+OEgRChCmSQN/QD1bRy2oCBSxW8/ZgX5jYt7wNC/oe3xS+/OIgrcYAJ16 ETzRO7zApqKtl9XkfB6p10cvQryrGBQfzcmXz7z0tzTCc0ebVGHC71HtOd6I4QzMPcEL5Xuf5 mrdU2zsJ/VrbWESJBq0FhdgEysddMbeQAOuW7K75ycVBeK4vZcttHs8za538v0gN05qa4mdbX dX+frdPUogGJZq5Mj/nCAQMYK7Ar5SIjuHsHWgHGmlwNrpR1O8E8Pcg/bhnqNCDSMAu53qd1y MWmSypbakFOenGMbaxOedoWpHehyq8UFagRWoDQZRDaMXJkiPWlA6nIz6YO+xNKTGfhKBOrch lzxabrHOWCxc/9WdQ63frLn9zbPSXOozHca7qh7cwPtd5tIAjgC/n8tJaCKI01TmpfW1YZSxs Z6Z9zJF75voBjJxF+7T5FhKahHYf/mOcEZK/g5whB9obu7BVVGjaimvtJSPnEB83HhBO0nNc/ e0GC5B/GDBXgS5O+73xXTibdJyQKTOGcInG/0plsXVKUMdDz7xIJT/Mzckt6maqGangrZfhha qVh46VLYMH49JMR8vxxOEuc7WmMMZ0fbOvC7MiTtHR8L2Hc0XXWQQxrz4AxRAtQqYZK20= X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Mar 2020 23:25:52 -0000 On 25.03.2020 17:36, John Baldwin wrote: > On 3/20/20 11:50 AM, Tom Tromey wrote: >>>>>>> "Kamil" =3D=3D Kamil Rytarowski writes: >> >> Kamil> I see. I prefer to keep this called obfd, as it matches the Free= BSD code >> Kamil> more closely. If we want to rename it, we shall do it also in Fr= eeBSD. >> >> Well, that FreeBSD code is wrong too... > > I looked, and I think that name was just inherited. The callback argume= nt commonly > passed to this function is in fact the bfd for a core file being generat= ed (e.g. > from gcore_memory_sections) and other functions like objfile_find_memory= _regions() > still use 'obfd' here. I think it's perfectly reasonable to rename the > variable. The exec target uses 'data' which it gained when it became a = C++ class > instead of setting to_find_memory_regions to objfile_find_memory_regions= directly. > OK, I can rename obfd to data. >>>> What if they stop matching? >> >> Kamil> Not a concern. >> >> Kamil> If that will ever change, it will be patched, same as the other >> Kamil> existing NetBSD support. >> >> How will cross debugging to different versions work in this situation? > > From FreeBSD's perspective, we probably won't ever change these bitfield= s as our > struct kinfo_vmentry is a public structure that we make ABI promises abo= ut that > is supposed to be the "public" version of internal kernel structures. I= suspect > NetBSD is following a similar model. > Yes. > FWIW, I did the code in the tdep file to support core file debugging and= cross > debugging (which works). I think the Linux tdep code also does info pro= c > in the tdep file for similar reasons. In the case of Linux, linux-tdep.= c > handles core dumps, while procfs.c appears to handle native processes. > > The formatting of using manual tables, etc. for info proc is also someth= ing the > Linux and procfs backends do. It might indeed be much cleaner to use ui= -out > (and probably more friendly to mi if we did so?) > My code is not different to prior art. So, is this patch fine for merging after the obfd->data rename?