From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id zh8eJ8ejTWIXNwAAWB0awg (envelope-from ) for ; Wed, 06 Apr 2022 10:29:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 878711ED17; Wed, 6 Apr 2022 10:29:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 146A41ED17 for ; Wed, 6 Apr 2022 10:29:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 984C43864C15 for ; Wed, 6 Apr 2022 14:29:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 984C43864C15 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1649255366; bh=1fgxj3ihCYyfGzD+cx41BHYVn2+Gz8AISG9KPr0HRh0=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=UBM06y4k+Xxm8dJSldVVrBj9xkHpgKy3nalc5/3vCPcfHSZKjQCtp8Jn+MyS15m4s b4ifnzM+fZHzub1mCI99i86LpkG2QGypVVKQWBRfg4n1451QpmajVnDIDAHTyTdRTw ROX9KoFrJrQEDc7mn0EeoOwLueN+IxzeCmwrlIF0= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id E64DC385840C for ; Wed, 6 Apr 2022 14:29:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E64DC385840C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 236ESx0a011221 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 6 Apr 2022 10:29:04 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 236ESx0a011221 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9A57D1ED17; Wed, 6 Apr 2022 10:28:59 -0400 (EDT) Message-ID: Date: Wed, 6 Apr 2022 10:28:59 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 16/16] gdb: update comments throughout reggroups.{c,h} files Content-Language: en-US To: Andrew Burgess , gdb-patches@sourceware.org References: <5c4a9642f0e6a0ec78b2a6c13e5fdbf6762614a5.1648760270.git.aburgess@redhat.com> In-Reply-To: <5c4a9642f0e6a0ec78b2a6c13e5fdbf6762614a5.1648760270.git.aburgess@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 6 Apr 2022 14:28:59 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > @@ -73,7 +83,7 @@ extern const reggroup *reggroup_gdbarch_new (struct gdbarch *gdbarch, > const char *name, > enum reggroup_type type); > > -/* Add a register group (with attribute values) to the pre-defined list. */ > +/* Add a register group GROUP to the list of register groups for GDBARCH. */ Just a nit: I would remove the indefinite article "a", since you are now referring to a specific register group. Simon