From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69314 invoked by alias); 22 Jul 2018 02:26:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63691 invoked by uid 89); 22 Jul 2018 02:25:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 22 Jul 2018 02:25:24 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 0E28E1E077; Sat, 21 Jul 2018 22:25:23 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1532226323; bh=QBg6ncFgWaMNElb1MIjNZPOSPX04pst2EGyxuxwH5yA=; h=Subject:To:References:From:Date:In-Reply-To:From; b=gWYaYKT5DB4yxndLNw9JaaSkYc8lkMo//UDBy/6l5zwzAaO7uaaiUTenq00A1bb7Q 8iZihIQ0Bhm5Y7fzG9/LkhVtRv1nn1Q2yceRrQi9vtVbilURSGttQBRI+2HhyUB/NX X0HVOI6wOmxQxzvU1CtZdBlZrz4TfROu86O/j76U= Subject: Re: [RFA v2 00/13] Add -Wunused-variable To: Tom Tromey , gdb-patches@sourceware.org References: <20180721184720.3263-1-tom@tromey.com> From: Simon Marchi Message-ID: Date: Sun, 22 Jul 2018 02:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180721184720.3263-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00651.txt.bz2 On 2018-07-21 02:47 PM, Tom Tromey wrote: > This is v2 of the patch series to add -Wunused-variable to the build. > > I believe this addresses all the review comments. This LGTM, but please wait for Ulrich's answer on patch 2. Otherwise I think it's ready to go. Simon