From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 1395B3870875 for ; Mon, 20 Apr 2020 14:11:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1395B3870875 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 9F4DA1E581; Mon, 20 Apr 2020 10:11:13 -0400 (EDT) Subject: Re: [OB PATCH] Fix compilation error with clang in gdb/testsuite/gdb.trace/tspeed.c To: Gary Benson , gdb-patches@sourceware.org References: <1587391684-8650-1-git-send-email-gbenson@redhat.com> From: Simon Marchi Message-ID: Date: Mon, 20 Apr 2020 10:11:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1587391684-8650-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-23.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 14:11:15 -0000 On 2020-04-20 10:08 a.m., Gary Benson via Gdb-patches wrote: > Clang fails to compile the above file, with the following error: > warning: using the result of an assignment as a condition without > parentheses [-Wparentheses] > > This prevents the following testcase from executing: > gdb.trace/tspeed.exp > --- > gdb/testsuite/ChangeLog | 5 +++++ > gdb/testsuite/gdb.trace/tspeed.c | 2 +- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.trace/tspeed.c b/gdb/testsuite/gdb.trace/tspeed.c > index b2c26bb..39a6646 100644 > --- a/gdb/testsuite/gdb.trace/tspeed.c > +++ b/gdb/testsuite/gdb.trace/tspeed.c > @@ -75,7 +75,7 @@ > > /* Keep trying the speed test, with more iterations, until > we get to a reasonable number. */ > - while (problem = trace_speed_test()) > + while ((problem = trace_speed_test())) > { > /* If iteration isn't working, give up. */ > if (iters > max_iters) > -- > 1.8.3.1 > Hi Gary, For some reason, we don't see you ChangeLog entry in the patch (although the diffstat shows changes to it), but it looks like: +2020-04-20 Gary Benson + + * gdb/testsuite/gdb.trace/tspeed.c: Fix compilation error with + clang. The filename should not have the gdb/testsuite part. Simon