From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19112 invoked by alias); 20 Mar 2017 16:48:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 18375 invoked by uid 89); 20 Mar 2017 16:48:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy= X-HELO: mail-wr0-f170.google.com Received: from mail-wr0-f170.google.com (HELO mail-wr0-f170.google.com) (209.85.128.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Mar 2017 16:48:26 +0000 Received: by mail-wr0-f170.google.com with SMTP id u48so96373969wrc.0 for ; Mon, 20 Mar 2017 09:48:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=4AeAbMjhhBnhK9qGY0c/E2CLnktb9f69Ci1RLy9AV8Y=; b=lFkFOMqjAk3lRfmDlyVlId+YXS06JyJPEvJnUFti/J5nLM0UV1DgxWIyOv8zui66OL fapWkXpP3COM5BisLvC2JyiWSUmX6BL/enRJUhD6gPza6Ayr04LSYPHkZjsGTy1IDyiV XUS4O3xDh31ndwl8bVGNNSC8Rt76NsRi2M1btK0SqfIZ7YOyS4zokg6NTVS37ctUAkAG jtrFPc3m/Uuilq9fgRVQlgzuOA4Qy7Tzl0/ZXR15j21Bg94hD4ZK/OkbzfC4p+Tscn4T KmHwMk5wA1F8hnNNjsL3Z+j1s3m/WGM7Jxi+1ukifxYg4C/a9iglWDhXaGycv0rjfQ0r 1fAA== X-Gm-Message-State: AFeK/H3RuIxTKSQG8kAULYzIMUkOmsLNq12BjzX/ylkE1OWl0/zpUa/9nWMaU/5yjFWMsmJl X-Received: by 10.223.136.33 with SMTP id d30mr28353986wrd.117.1490028505499; Mon, 20 Mar 2017 09:48:25 -0700 (PDT) Received: from [192.168.0.101] ([37.189.166.198]) by smtp.gmail.com with ESMTPSA id l41sm21350624wre.23.2017.03.20.09.48.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Mar 2017 09:48:24 -0700 (PDT) Subject: Re: [PATCH] [PR tdep/20928] Decode properly flags of %ccr register on sparc64 To: Ivo Raisr , gdb-patches@sourceware.org References: <37ce765b-9064-a766-c843-a25b69030528@oracle.com> <705eae25-cf4e-fc81-dd8e-1e622b340486@oracle.com> <118a1bb4-80c3-3458-26ae-de3248a82dea@oracle.com> From: Pedro Alves Message-ID: Date: Mon, 20 Mar 2017 16:48:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-03/txt/msg00340.txt.bz2 On 03/20/2017 03:54 PM, Ivo Raisr wrote: > On 17.3.2017 17:42, Pedro Alves wrote: >> On 03/14/2017 08:37 AM, Ivo Raisr wrote: >> I was hoping that someone who actually knows sparc would >> take a look. :-) >> >> My only comment would be wondering about a adding some test. >> E.g., some small assembly test in gdb.arch/ that you'd single-step >> and make sure that the expected changes can be observed in >> the affected registers / flags. > > Please see attached new patch extended with new tests added. > > Only the following files were added (compared to previous patch submission): > > gdb/testsuite/gdb.arch/sparc64-regs.S > gdb/testsuite/gdb.arch/sparc64-regs.exp > > I. Very nice! Feel free to push with a couple nits below fixed. > diff --git a/gdb/testsuite/gdb.arch/sparc64-regs.exp b/gdb/testsuite/gdb.arch/sparc64-regs.exp > new file mode 100644 > index 0000000..fff9964 > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/sparc64-regs.exp > @@ -0,0 +1,117 @@ > +# Copyright 2017-2017 Free Software Foundation, Inc. Single "2017". > +########################################## > +set lno [gdb_get_line_number "sparc64-regs.exp: after first %fsr" $srcfile] > +gdb_test "break $srcfile:$lno" "Breakpoint \[0-9\] at .*" Give this gdb_test a 3rd parameter that avoids showing the line number in gdb.sum, to avoid spurious/unnecessary gdb.sum change if/when the test source changes. Thanks, Pedro Alves