From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4794 invoked by alias); 23 Oct 2018 12:49:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125124 invoked by uid 89); 23 Oct 2018 12:49:13 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:3604, simark, sk:cooked_, regcachec X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Oct 2018 12:49:04 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-MBX-03.mgc.mentorg.com) by relay1.mentorg.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) id 1gEw7D-0005xN-B9 from abid_qadeer@mentor.com ; Tue, 23 Oct 2018 05:48:55 -0700 Received: from [137.202.204.206] (137.202.0.90) by SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) with Microsoft SMTP Server (TLS) id 15.0.1320.4; Tue, 23 Oct 2018 13:48:51 +0100 Subject: Re: [1/2] C-SKY Port To: Simon Marchi , CC: References: <1b689bab-bb28-7ba9-9602-d66f0568ff28@simark.ca> <1799f181-2531-dc53-4934-6f436a2b858c@simark.ca> From: Hafiz Abid Qadeer Message-ID: Date: Tue, 23 Oct 2018 12:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1799f181-2531-dc53-4934-6f436a2b858c@simark.ca> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-SW-Source: 2018-10/txt/msg00507.txt.bz2 On 21/10/18 04:22, Simon Marchi wrote: > On 2018-10-20 11:04 p.m., Hafiz Abid Qadeer wrote: >> On 20/10/18 19:55, Simon Marchi wrote: >>> On 2018-07-25 6:54 a.m., Hafiz Abid Qadeer wrote: >> >>> Hi Hafiz, >>> >>> I noticed the "cooked_read" selftest fails with c-sky (ever since the c-sky support was added): >>> >>> (gdb) maintenance selftest cooked_read >>> Running selftest regcache::cooked_read_test. >>> ... >>> Self test failed: arch csky: self-test failed at /home/simark/src/binutils-gdb/gdb/regcache.c:1697 >>> Self test failed: arch csky:ck510: self-test failed at /home/simark/src/binutils-gdb/gdb/regcache.c:1697 >>> Self test failed: arch csky:ck610: self-test failed at /home/simark/src/binutils-gdb/gdb/regcache.c:1697 >>> Self test failed: arch csky:ck801: self-test failed at /home/simark/src/binutils-gdb/gdb/regcache.c:1697 >>> Self test failed: arch csky:ck802: self-test failed at /home/simark/src/binutils-gdb/gdb/regcache.c:1697 >>> Self test failed: arch csky:ck803: self-test failed at /home/simark/src/binutils-gdb/gdb/regcache.c:1697 >>> Self test failed: arch csky:ck807: self-test failed at /home/simark/src/binutils-gdb/gdb/regcache.c:1697 >>> Self test failed: arch csky:ck810: self-test failed at /home/simark/src/binutils-gdb/gdb/regcache.c:1697 >>> Self test failed: arch csky:any: self-test failed at /home/simark/src/binutils-gdb/gdb/regcache.c:1697 >>> ... >>> Self test failed: self-test failed at /home/simark/src/binutils-gdb/gdb/selftest-arch.c:86 >>> Ran 1 unit tests, 1 failed >>> >>> Could you take a look? >> Hi Simon, >> Thanks for letting me know. I am traveling at the moment. Will take a >> look at it when I am back in a few days. > > Ok, thanks! > > A quick investigation shows it's because some raw registers are not in the > save reggroup. So csky should probably be added to that big if in the test: > > if (bfd_arch == bfd_arch_frv || bfd_arch == bfd_arch_h8300 > || bfd_arch == bfd_arch_m32c || bfd_arch == bfd_arch_sh > || bfd_arch == bfd_arch_alpha || bfd_arch == bfd_arch_v850 > || bfd_arch == bfd_arch_msp430 || bfd_arch == bfd_arch_mep > || bfd_arch == bfd_arch_mips || bfd_arch == bfd_arch_v850_rh850 > || bfd_arch == bfd_arch_tic6x || bfd_arch == bfd_arch_mn10300 > || bfd_arch == bfd_arch_rl78 || bfd_arch == bfd_arch_score > || bfd_arch == bfd_arch_riscv) > { > /* Raw registers. If raw registers are not in save_reggroup, > their status are unknown. */ > if (gdbarch_register_reggroup_p (gdbarch, regnum, save_reggroup)) > SELF_CHECK (status == REG_VALID); > else > SELF_CHECK (status == REG_UNKNOWN); > } > else > SELF_CHECK (status == REG_VALID); > When I was reviewing the test results for csky, I saw this fail in unittest.exp and fixed it by adding csky to the big if list as you mentioned above. Somehow I missed that patch when upstreaming the port. So if you are happy with that change then I will push it. > But I'm tempted to replace all of that with simply; > > /* Raw registers. If raw registers are not in save_reggroup, > their status are unknown. */ > if (gdbarch_register_reggroup_p (gdbarch, regnum, save_reggroup)) > SELF_CHECK (status == REG_VALID); > else > SELF_CHECK (status == REG_UNKNOWN); > > We won't have to maintain this big list, and I don't think we lose any testing > coverage/safety. For architectures for which all raw registers are in the > save_reggroup (all arches not listed above), we will still always assert that > status == REG_VALID. I have not looked at this code much but your suggestion makes sense to me. Regards, -- Hafiz Abid Qadeer Mentor Embedded/CodeSourcery