From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EJlGBrAXUWOOsA4AWB0awg (envelope-from ) for ; Thu, 20 Oct 2022 05:41:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 14A511E112; Thu, 20 Oct 2022 05:41:04 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=TEWAmQWj; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B899A1E0D5 for ; Thu, 20 Oct 2022 05:41:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DD3C23986426 for ; Thu, 20 Oct 2022 09:40:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DD3C23986426 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666258831; bh=9yaiREs4hr+8MWXAgIaar2Q8T/GS3dNAAD3l3KlEt6M=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TEWAmQWjXAQkGNG8I2NkBRS5hotybG4AOkbTgIIqmfMUHCrvjQ5PTRJrWXImqZzGf Tcpdn0Gl065kXLHcD2Q8yPrZ9nBB/4/rjlIkbj6MpVhXZ+CaA7i1ce8uUslSe1Eb9a zIcrC2FWSYKIuBgZqb//NJXlU0EGcDpmoCaZZj+o= Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id B81E938EA2E1 for ; Thu, 20 Oct 2022 09:39:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B81E938EA2E1 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 15BE8300089; Thu, 20 Oct 2022 09:39:02 +0000 (UTC) To: Tsukasa OI , Andrew Burgess , Mike Frysinger , Nick Clifton Subject: [PATCH 35/40] sim/sh: Initialize some variables Date: Thu, 20 Oct 2022 09:32:40 +0000 Message-Id: In-Reply-To: References: Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tsukasa OI via Gdb-patches Reply-To: Tsukasa OI Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Clang generates a warning if a variable may be used uninitialized on some cases ("-Wsometimes-uninitialized"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). The cause of this error, $(builddir)/sim/sh/ppi.c is generated from $(srcdir)/sim/sh/gencode.c. Clang will detect the variable res may be used uninitialized when used on some cases. Likewise, GCC generates a warning if a variable may be used uninitialized on some cases ("-Wmaybe-uninitialized"). GCC will detect variables res, res_grd, carry, overflow and greater_equal may be used uninitialized on some cases. Despite that GCC will not cause a build failure even when "--enable-werror" is specified, it would be better to fix this as well since the cause is in the same function. --- sim/sh/gencode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/sh/gencode.c b/sim/sh/gencode.c index 5eb7caf2589..03979695b08 100644 --- a/sim/sh/gencode.c +++ b/sim/sh/gencode.c @@ -3257,8 +3257,8 @@ ppi_gensim (void) printf (" static char const u_tab[] = { 8, 10, 7, 5};\n"); printf ("\n"); printf (" int z;\n"); - printf (" int res, res_grd;\n"); - printf (" int carry, overflow, greater_equal;\n"); + printf (" int res = 0, res_grd = 0;\n"); + printf (" int carry = 0, overflow = 0, greater_equal = 0;\n"); printf ("\n"); printf (" switch (ppi_table[iword >> 4]) {\n"); -- 2.34.1