Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Jim Wilson <jim.wilson@linaro.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] aarch64 sim big-endian support
Date: Thu, 30 Jun 2016 08:13:00 -0000	[thread overview]
Message-ID: <c38886b0-1fc3-762d-ddc0-dfb541c05b89@redhat.com> (raw)
In-Reply-To: <CABXYE2XPToNdOMvrp5HMh+Lk=5VND7vZk5V1vkHKw4Kg5NW0sw@mail.gmail.com>

Hi Jim,

> The problem is with the
> GRegisterValue untion.  You have
> typedef union GRegisterValue
> {
>   int8_t   s8;
> ...
>   int64_t s64;
> } GRegister;
> On a little-endian host, the s8 member will match the low-byte of the
> s64 member, which is what we want.  However, on a big-endian host, the
> s8 member will match the high-byte of the u64 member, and the
> simulator fails.

Ah, yes.  I had not considered this.

> Fixing the problem this way means that we require either an ISO C 2011
> compiler, or a compiler that supports GCC extensions to ISO C 1990 or
> 1999. 

I have no problems with this requirement.

I have now checked in your patch (to save time).  Thanks very much for
persuing this matter.

Cheers
  Nick


  reply	other threads:[~2016-06-30  8:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03  2:36 Jim Wilson
2016-06-10 16:24 ` Jim Wilson
2016-06-13 12:38   ` Nick Clifton
2016-06-30  1:33     ` Jim Wilson
2016-06-30  8:13       ` Nick Clifton [this message]
2016-06-10 18:06 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c38886b0-1fc3-762d-ddc0-dfb541c05b89@redhat.com \
    --to=nickc@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jim.wilson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox