Re: [PATCH 3/9] gdb/testsuite/dap: write requests to gdb.log

Simon Marchi via Gdb-patches
2023-01-26T03:02:15Z

On 1/25/23 17:01, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Simon> This helps following what happens when reading gdb.log. The downside is
> Simon> that it becomes harder to tell what text is from GDB and what text is
> Simon> going to GDB, but I think that seeing responses without seeing requests
> Simon> is even more confusing. At least, the lines are prefix with >>>, so
> Simon> when you see this, you know that until the end of the line, it's
> Simon> something that was sent to GDB, and not GDB output.
>
> I meant to mention -- the full DAP I/O is in the test subdir.
> E.g. look at gdb/testsuite/outputs/gdb.dap/basic-dap/dap.log.1 in the
> build tree.

Yeah, I saw that. But to debug the actual test, I found that having the
full communication in gdb.log was a bit easier, to correlate with passes
and fails.

Simon