Re: [PATCH 04/10] remote: multiple remote_arch_state instances per arch

Simon Marchi
2018-05-18T21:04:34Z

On 2018-05-16 10:18 AM, Pedro Alves wrote:
> Currently, we associate gdbarch-related remote protocol state on a
> per-gdbarch data object. Things like the size of the g/G packet, and
> the max remote packet size. If we'll support being connected to
> different remote servers at the same time, then we need to cope with
> each having their own packet sizes, even if they are each debugging
> programs of the same architecture. I.e., a single instance of
> remote_arch_state per arch is not sufficient.
>
> This patch moves the remote_arch_state object to a map of
> gdbarch-to-remote_arch_state saved in the remote_state structure.
> Usually there will only be one entry in the map, though we may see
> more with stubs that support multi-process and/or archs with multiple
> ABIs (e.g, one remote_arch_state for 64-bit inferiors and another for
> 32-bit inferiors).

LGTM.

Simon