From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-135439-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 57407 invoked by alias); 30 Nov 2016 12:30:30 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 56245 invoked by uid 89); 30 Nov 2016 12:30:20 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:752, States, H*M:1000, states
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 30 Nov 2016 12:30:07 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 208881285;	Wed, 30 Nov 2016 12:30:06 +0000 (UTC)
Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAUCU5RP030778;	Wed, 30 Nov 2016 07:30:05 -0500
Subject: Re: [PATCH 20/22] Class-ify ui_out_table
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20161124152428.24725-1-simon.marchi@polymtl.ca> <20161124153228.25177-20-simon.marchi@polymtl.ca> <ee7cca769500ebe89393bd07a2f3027f@polymtl.ca>
From: Pedro Alves <palves@redhat.com>
Message-ID: <c34952d7-8113-1000-fb43-85590404ed0f@redhat.com>
Date: Wed, 30 Nov 2016 12:30:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <ee7cca769500ebe89393bd07a2f3027f@polymtl.ca>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-11/txt/msg00979.txt.bz2

On 11/26/2016 05:18 PM, Simon Marchi wrote:
> On 2016-11-24 10:32, Simon Marchi wrote:
>> +  /* States (steps) of a table generation.  */
>> +
>> +  enum state
>> +  {
>> +    /* We are generating the table headers.  */
>> +    TABLE_STATE_HEADERS,
>> +
>> +    /* We are generating the table body.  */
>> +    TABLE_STATE_BODY,
>> +  };
> 
> I changed the enum to:
> 
>   /* States (steps) of a table generation.  */
> 
>   enum class state
>   {
>     /* We are generating the table headers.  */
>     HEADERS,
> 
>     /* We are generating the table body.  */
>     BODY,
>   };
> 
> and adjusted the references.

I looked at your branch to see the end result, and it
looks good to me.  But please post the final result for
the archives.

Thanks,
Pedro Alves