From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29008 invoked by alias); 16 Jun 2019 22:34:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 28999 invoked by uid 89); 16 Jun 2019 22:34:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.2 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=integrate, H*f:sk:2019053, HX-Languages-Length:1208, fedora X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Jun 2019 22:34:23 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9B0A1AE40; Sun, 16 Jun 2019 22:34:21 +0000 (UTC) Subject: Re: [RFC] Only compute realpath when basenames_may_differ is set To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20190530170315.9938-1-tromey@adacore.com> <87zhmkme75.fsf@tromey.com> From: Tom de Vries Message-ID: Date: Sun, 16 Jun 2019 22:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <87zhmkme75.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00303.txt.bz2 On 14-06-19 16:30, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> A user noted that, when sources are symlinked, gdb annotations will > Tom> print the real path, rather than the name of the symlink. > > Tom> It seems to me that it is better to print the name of the file that > Tom> was actually used in the build, unless there is some reason not to. > > Tom> This patch implements this, with the caveat that it will not work when > Tom> basenames-may-differ is enabled. The way this mode is currently > Tom> implemented, returning the symbolic (not real) path is not possible. > > Tom> While I think it would be good to redo the source file name cache and > Tom> perhaps integrate it with class source_cache, I haven't done so here. > > Tom> Regression tested on x86-64 Fedora 29. > > Tom> gdb/ChangeLog > Tom> 2019-05-30 Tom Tromey > > Tom> * source.c (find_and_open_source): Respect basenames_may_differ. > > I'm checking this in now. > This caused PR24687 - "FAIL: gdb.base/fullname.exp: set breakpoint by full path before/after loading symbols - built relative". Thanks, - Tom