From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZU6gLEsx+V/yQgAAWB0awg (envelope-from ) for ; Fri, 08 Jan 2021 23:30:03 -0500 Received: by simark.ca (Postfix, from userid 112) id AF53B1E99A; Fri, 8 Jan 2021 23:30:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4B6D51E4F4 for ; Fri, 8 Jan 2021 23:30:02 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 08D213985474; Sat, 9 Jan 2021 04:30:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 08D213985474 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610166602; bh=JAzIs0fK6iWjXNeDw+/hWv17xJBBzucGQOlt3qfPWyU=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DGQJ1eKWUHr7m9ovHySd62k34MVmInDNe38R2P2pxm4aGbHX12mfLG/SJzHf7/VCm b6NPaE8SnViky4Ai/RzUex8qwfTCqxUu/XJ3w+DtvbtxL/1yEbrdA2FJVA8gv4gpo1 gxjkN8WYS45z/8Y/xma+/kr2C3zcLibdUGCjq8Uc= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 9FD1A3985472 for ; Sat, 9 Jan 2021 04:29:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9FD1A3985472 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1094TowJ022418 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 8 Jan 2021 23:29:55 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1094TowJ022418 Received: from [10.0.0.213] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B58551E4F4; Fri, 8 Jan 2021 23:29:50 -0500 (EST) Subject: Re: [PATCH 1/5] gdb: change jit_debug to a bool To: Simon Marchi References: <20210109042816.4140840-1-simon.marchi@polymtl.ca> Message-ID: Date: Fri, 8 Jan 2021 23:29:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210109042816.4140840-1-simon.marchi@polymtl.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 9 Jan 2021 04:29:50 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Gdb-patches Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Hi Mihails, Since you deal with JIT a lot, would you mind giving this patch a look? Thanks! Simon On 2021-01-08 11:28 p.m., Simon Marchi wrote: > gdb/ChangeLog: > > * jit.c (jit_debug): Change type to bool. > (_initialize_jit): Adjust. > > Change-Id: Ic2b1eec28eafe8ccb2899f38ddc91ba9703cb38e > --- > gdb/jit.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/gdb/jit.c b/gdb/jit.c > index ad951cdfbb52..474ba838b86b 100644 > --- a/gdb/jit.c > +++ b/gdb/jit.c > @@ -58,9 +58,9 @@ static void jit_inferior_exit_hook (struct inferior *inf); > > static struct gdbarch_data *jit_gdbarch_data; > > -/* Non-zero if we want to see trace of jit level stuff. */ > +/* True if we want to see trace of jit level stuff. */ > > -static unsigned int jit_debug = 0; > +static bool jit_debug = false; > > static void > show_jit_debug (struct ui_file *file, int from_tty, > @@ -1251,13 +1251,13 @@ _initialize_jit () > { > jit_reader_dir = relocate_gdb_directory (JIT_READER_DIR, > JIT_READER_DIR_RELOCATABLE); > - add_setshow_zuinteger_cmd ("jit", class_maintenance, &jit_debug, > - _("Set JIT debugging."), > - _("Show JIT debugging."), > - _("When non-zero, JIT debugging is enabled."), > - NULL, > - show_jit_debug, > - &setdebuglist, &showdebuglist); > + add_setshow_boolean_cmd ("jit", class_maintenance, &jit_debug, > + _("Set JIT debugging."), > + _("Show JIT debugging."), > + _("When non-zero, JIT debugging is enabled."), > + NULL, > + show_jit_debug, > + &setdebuglist, &showdebuglist); > > gdb::observers::inferior_created.attach (jit_inferior_created_hook); > gdb::observers::inferior_execd.attach (jit_inferior_created_hook); >