From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8oo3JM3el2r8cR4AWB0awg (envelope-from ) for ; Wed, 02 Sep 2026 04:31:09 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=o2.pl header.i=@o2.pl header.a=rsa-sha256 header.s=20241105 header.b=dBIgdOwE; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 70B791E166; Wed, 02 Sep 2026 04:31:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 698031E09B for ; Wed, 02 Sep 2026 04:31:07 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7D6E14BA79A0 for ; Wed, 2 Sep 2026 08:31:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D6E14BA79A0 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=o2.pl header.i=@o2.pl header.a=rsa-sha256 header.s=20241105 header.b=dBIgdOwE Received: from mx-out.tlen.pl (mx-out.tlen.pl [193.222.135.158]) by sourceware.org (Postfix) with ESMTPS id 6ED5A4BA2E0A for ; Wed, 2 Sep 2026 08:30:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6ED5A4BA2E0A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=o2.pl Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=o2.pl ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6ED5A4BA2E0A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=193.222.135.158 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788337830; cv=none; b=NfBqRFcGRk5gG+HgnJ6X6+eEDJUd8ArITAg+sROdrrsQi7F74x4LEQwQkOxD2WZkfPr0vNmqP+vKpjNAMH2oSckLsI1G7Pz7JkDKN/76scyAenaHqOytSsAZjjKeKaCxgZSvAvstewwfTrb55gPb0aWW0r0x9OBhGo4GYhEimhU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788337830; c=relaxed/simple; bh=ducIjjHSoOLD3GiVY0yNFxDa7tRN8KqyfUXF2loS1XE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=B8qWld7qSuOsdtpZ94M+DUYK+molYqTO6/zZMPF92BiYMagWkVXjnfdjeVBq3v5iN3E89N8AayYNQvLTccllnDv5s67sqc19n/RYXDZ78n4LkRZrRgC4hYvl3t6fY8VUZXS1Rm/pD0kG00/W1NGJtn1aT5J94zETZIkkehlNh28= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=o2.pl header.i=@o2.pl header.a=rsa-sha256 header.s=20241105 header.b=dBIgdOwE DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6ED5A4BA2E0A Received: (wp-smtpd smtp.tlen.pl 16530 invoked from network); 2 Sep 2026 10:30:15 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=o2.pl; s=20241105; t=1788337815; bh=j/gnCr6tFq7pr4Mt4O3b2q/wIoPDe1cI5TosNpZCWIs=; h=Subject:To:Cc:From; b=dBIgdOwEml1RQWpICN0DiRoh4hFRugtobmsjTmxjLM/9gTycrt7d2oH0VJSBgEUtY 3MXNVe67+2kibzJQix/si6XT/RoLxooBJgdbBuMFLaa1WpDxNn3Sr9/SzLIt433fhQ 2cAK6l2pcQ6eTHihHxWlD1VTVsX+SxIJgAxt4B6RJH4w2vd+EqTjWBFc7LhmoUdtC8 PBs/ss70w9LObYN0CrfXBkzJN85ERhcUnWuWSxk+fjnTxW67BDRkIzTtdfjyKLSewN H65TZy+1TgkQw1Od1/mVjng1surJZDg+Gyg07ee6e+pXsDO1rCwsvE0xGL4LPTDUu7 QrYQZF8/WzjSA== Received: from [192.168.0.1] (ip-94-42-229-65.multimo.pl [94.42.229.65]) (envelope-sender ) by smtp.tlen.pl (WP-SMTPD) with TLS_AES_256_GCM_SHA384 encrypted SMTP for ; 2 Sep 2026 10:30:15 +0200 Message-ID: Date: Wed, 2 Sep 2026 10:30:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] H8/300: sim: Fix simulator hang caused by qsort on Windows/MinGW To: Jeff Law , gdb-patches@sourceware.org Cc: Tom Tromey References: <20260901071022.1682657-1-jdx@o2.pl> Content-Language: pl From: Jan Dubiec In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-WP-MailID: 0488626fd9908c7ed55b1b927515f0a3 X-WP-AV: skaner antywirusowy Poczty o2 X-WP-SPAM: NO 0000000 [gVMM] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2.09.2026 05:47, Jeff Law wrote: [...] > One class of pure formatting nit you should probably fix: > > >> + >> +  /* The 3rd sort key  */ >> +  cmp = strcmp(p1->name, p2->name); > GNU style guidelines require a space between the function name and the > open paren for the argument list.  The same nit appears several times in > this patch (strlen, strchr, strncmp calls) Version 3 has been posted in a new thread. /J.D.