From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by sourceware.org (Postfix) with ESMTP id 104A73851C0C for ; Sat, 23 May 2020 11:51:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 104A73851C0C Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-414--O8BrKcKM_-qQAUpvnwOYQ-1; Sat, 23 May 2020 07:51:21 -0400 X-MC-Unique: -O8BrKcKM_-qQAUpvnwOYQ-1 Received: by mail-wr1-f72.google.com with SMTP id l18so387541wrm.0 for ; Sat, 23 May 2020 04:51:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w5frvuoycIPjHE3PLdBpJNliAHLGMu/o9Xrbpdlym8k=; b=IsO7vMcH7FoE/ylrfjedWWywJqQuulOCt/p9wWDqo5ALd/kU08lTTz0esR60BojPy6 vNfIW16ur/eh8zogl0t6pkCPf+DlXMqVNvKm4aSjQesfz14cAfssnaoCzwYPYhlKix1D LqvUNFMIPiB03xPkcT9JMlKNArPVyutXIZvAaobXeA55aBwUFfa322PNjXVR5PBzM6av boSxoIM6Pq4cPHsWOVzNfLrKyYj5dpmBcXDcYYydCboqLlT33EuQmcWkXTpKQ/wPBedJ K9raCdJrCHN56wBg4zKqun2AKEnwDZ0MRC7T9+wmIWwY5LI4TCpE8GBG5zB4vM4/IADQ wL+A== X-Gm-Message-State: AOAM530a/JWFWrKGS5bQBccTZFJysbIJaoqEEntaBHcQMfYAN6DVxz+k AiMd7Uss7hctRE1yHl3WwtnGdOD/bwHpYktPQWsh1Rd3M8NnWQ6k7JZXtK76ZnjL2w8Nka32gNV ldF7X2URRrDn/2xQrT+L9Yg== X-Received: by 2002:a05:6000:1c5:: with SMTP id t5mr7816007wrx.229.1590234680335; Sat, 23 May 2020 04:51:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcy1g3uRHLbJHRUB3YVSkiKq72VZ7b6yWr1vL8KeXszGmHe/qx0USsDedxTLVYGrTAIgiegA== X-Received: by 2002:a05:6000:1c5:: with SMTP id t5mr7815997wrx.229.1590234680123; Sat, 23 May 2020 04:51:20 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id t14sm1021146wrb.94.2020.05.23.04.51.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 May 2020 04:51:19 -0700 (PDT) Subject: Re: [PATCH] Use safe-ctype.h (ISSPACE etc.) in symbol parsing & comparison To: Tom Tromey , Pedro Alves via Gdb-patches References: <20200522202636.3027-1-palves@redhat.com> <87v9kn1zee.fsf@tromey.com> From: Pedro Alves Message-ID: Date: Sat, 23 May 2020 12:51:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <87v9kn1zee.fsf@tromey.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 May 2020 11:51:25 -0000 On 5/22/20 9:35 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves via Gdb-patches writes: > > Pedro> The baseline mean time was > Pedro> gdb 2.515 > Pedro> This patch brings the number down to > Pedro> gdb 2.096 > Pedro> Which is an around 16% improvement. > > Nice. > > Pedro> + Copyright (C) 2019 Free Software Foundation, Inc. > > 2020 Fixed. > > Otherwise, looks good to me. Thanks, I've merged it. Pedro Alves